[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

Compile is broken after that patch. I get:

/cluster-3.1.5/group/dlm_controld/plock.c:744:2: warning: #warning DLM_PLOCK_FL_CLOSE undefined. Enabling build workaround.
/cluster-3.1.5/group/dlm_controld/plock.c: In function \u2018process_plocks\u2019:
/cluster-3.1.5/group/dlm_controld/plock.c:1595: error: \u2018struct dlm_plock_info\u2019 has no member named \u2018flags\u2019
make[2]: *** [plock.o] Error 1
make[2]: Leaving directory `/home/dietmar/pve2-devel/redhat-cluster-pve/cluster-3.1.5/group/dlm_controld'
make[1]: *** [all] Error 2

- Dietmar

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Fabio M. Di Nitto]

On 8/24/2011 8:18 AM, Dietmar Maurer wrote:
> Compile is broken after that patch. I get:
> 
> /cluster-3.1.5/group/dlm_controld/plock.c:744:2: warning: #warning DLM_PLOCK_FL_CLOSE undefined. Enabling build workaround.
> /cluster-3.1.5/group/dlm_controld/plock.c: In function \u2018process_plocks\u2019:
> /cluster-3.1.5/group/dlm_controld/plock.c:1595: error: \u2018struct dlm_plock_info\u2019 has no member named \u2018flags\u2019
> make[2]: *** [plock.o] Error 1
> make[2]: Leaving directory `/home/dietmar/pve2-devel/redhat-cluster-pve/cluster-3.1.5/group/dlm_controld'
> make[1]: *** [all] Error 2
> 
> - Dietmar
> 
> 

I pushed a workaround for this, but you need to update your kernel headers.

Fabio

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

Thank, the fix works well.

- Dietmar

> -----Original Message-----
> From: Dietmar Maurer
> Sent: Mittwoch, 24. August 2011 08:18
> To: 'cluster-devel at redhat.com'
> Subject: Problems with [PATCH] dlm_controld: fix plock dev_write no op
> 
> Compile is broken after that patch. I get:
> 
> /cluster-3.1.5/group/dlm_controld/plock.c:744:2: warning: #warning
> DLM_PLOCK_FL_CLOSE undefined. Enabling build workaround.
> /cluster-3.1.5/group/dlm_controld/plock.c: In function
> \u2018process_plocks\u2019:
> /cluster-3.1.5/group/dlm_controld/plock.c:1595: error: \u2018struct
> dlm_plock_info\u2019 has no member named \u2018flags\u2019
> make[2]: *** [plock.o] Error 1
> make[2]: Leaving directory `/home/dietmar/pve2-devel/redhat-cluster-
> pve/cluster-3.1.5/group/dlm_controld'
> make[1]: *** [all] Error 2
> 
> - Dietmar

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

> On 8/24/2011 8:18 AM, Dietmar Maurer wrote:
> > Compile is broken after that patch. I get:
> >
> > /cluster-3.1.5/group/dlm_controld/plock.c:744:2: warning: #warning
> DLM_PLOCK_FL_CLOSE undefined. Enabling build workaround.
> > /cluster-3.1.5/group/dlm_controld/plock.c: In function
> \u2018process_plocks\u2019:
> > /cluster-3.1.5/group/dlm_controld/plock.c:1595: error: \u2018struct
> > dlm_plock_info\u2019 has no member named \u2018flags\u2019
> > make[2]: *** [plock.o] Error 1
> > make[2]: Leaving directory `/home/dietmar/pve2-devel/redhat-cluster-
> pve/cluster-3.1.5/group/dlm_controld'
> > make[1]: *** [all] Error 2
> >
> > - Dietmar
> >
> >
> 
> I pushed a workaround for this, but you need to update your kernel headers.

Well, I use headers from recent RHEL6 kernel (131.6.1.el6). 

Is that fixed in newer RHEL6 kernels or what kernel version do you suggest? 

- Dietmar

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Fabio M. Di Nitto]

On 8/25/2011 7:10 AM, Dietmar Maurer wrote:
>> On 8/24/2011 8:18 AM, Dietmar Maurer wrote:
>>> Compile is broken after that patch. I get:
>>>
>>> /cluster-3.1.5/group/dlm_controld/plock.c:744:2: warning: #warning
>> DLM_PLOCK_FL_CLOSE undefined. Enabling build workaround.
>>> /cluster-3.1.5/group/dlm_controld/plock.c: In function
>> \u2018process_plocks\u2019:
>>> /cluster-3.1.5/group/dlm_controld/plock.c:1595: error: \u2018struct
>>> dlm_plock_info\u2019 has no member named \u2018flags\u2019
>>> make[2]: *** [plock.o] Error 1
>>> make[2]: Leaving directory `/home/dietmar/pve2-devel/redhat-cluster-
>> pve/cluster-3.1.5/group/dlm_controld'
>>> make[1]: *** [all] Error 2
>>>
>>> - Dietmar
>>>
>>>
>>
>> I pushed a workaround for this, but you need to update your kernel headers.
> 
> Well, I use headers from recent RHEL6 kernel (131.6.1.el6). 
> 
> Is that fixed in newer RHEL6 kernels or what kernel version do you suggest? 

You need kernel from RHEL6.2.

Fabio

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

> >> I pushed a workaround for this, but you need to update your kernel headers.
> >
> > Well, I use headers from recent RHEL6 kernel (131.6.1.el6).
> >
> > Is that fixed in newer RHEL6 kernels or what kernel version do you suggest?
> 
> You need kernel from RHEL6.2.

Are there known bugs with 131.6.1.el6 (rhel6.2 is still beta)?

-Dietmar

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Fabio M. Di Nitto]

On 8/25/2011 10:29 AM, Dietmar Maurer wrote:
>>>> I pushed a workaround for this, but you need to update your kernel headers.
>>>
>>> Well, I use headers from recent RHEL6 kernel (131.6.1.el6).
>>>
>>> Is that fixed in newer RHEL6 kernels or what kernel version do you suggest?
>>
>> You need kernel from RHEL6.2.
> 
> Are there known bugs with 131.6.1.el6 (rhel6.2 is still beta)?

I am not sure I understand the question... kernel is kind of big and a
query in bugzilla.redhat.com will answer your question too :)

Fabio

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

> > Are there known bugs with 131.6.1.el6 (rhel6.2 is still beta)?
> 
> I am not sure I understand the question... kernel is kind of big and a query in
> bugzilla.redhat.com will answer your question too :)

You suggested to use another kernel, so I thought you are aware of a specific bug related to old dlm_plock.c as used in  131.6.1.el6?

- Dietmar

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Fabio M. Di Nitto]

On 8/25/2011 10:42 AM, Dietmar Maurer wrote:
>>> Are there known bugs with 131.6.1.el6 (rhel6.2 is still beta)?
>>
>> I am not sure I understand the question... kernel is kind of big and a query in
>> bugzilla.redhat.com will answer your question too :)
> 
> You suggested to use another kernel, so I thought you are aware of a specific bug related to old dlm_plock.c as used in  131.6.1.el6?

The new kernel has a plock fix that the old one does not have. Unless
you are using posix locks, it doesn?t affect you.

You need a new kernel to build the userland counterpart without workaround.

Fabio

[Cluster-devel] Problems with [PATCH] dlm_controld: fix plock dev_write no op

[Dietmar Maurer]

> -----Original Message-----
> From: Fabio M. Di Nitto [mailto:fdinitto at redhat.com]
> Sent: Donnerstag, 25. August 2011 10:52
> To: Dietmar Maurer
> Cc: cluster-devel at redhat.com
> Subject: Re: [Cluster-devel] Problems with [PATCH] dlm_controld: fix plock
> dev_write no op
> 
> On 8/25/2011 10:42 AM, Dietmar Maurer wrote:
> >>> Are there known bugs with 131.6.1.el6 (rhel6.2 is still beta)?
> >>
> >> I am not sure I understand the question... kernel is kind of big and
> >> a query in bugzilla.redhat.com will answer your question too :)
> >
> > You suggested to use another kernel, so I thought you are aware of a specific
> bug related to old dlm_plock.c as used in  131.6.1.el6?
> 
> The new kernel has a plock fix that the old one does not have. Unless you are
> using posix locks, it doesn?t affect you.
> 
> You need a new kernel to build the userland counterpart without workaround.

Seems I can just cherry pick the fix from:

http://git.kernel.org/?p=linux/kernel/git/stable/linux-3.0.y.git;a=commitdiff;h=901025d2f3194b4868980c8ba80df4cc0aa1282c

So far that seems to work.

- Dietmar