From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Paul Clements <paul.clements-eviPjrN/1CxBDgjK7y7TUQ@public.gmane.org>
Cc: nbd-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] nbd: add support for feature negotiation
Date: Wed, 07 Sep 2011 19:52:42 +0200 [thread overview]
Message-ID: <4E67AF6A.9090400@redhat.com> (raw)
In-Reply-To: <CAECXXi4YW++_302mcSTX=cPjbguSqcw3Weec85VrLFv1qNHXug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 09/07/2011 06:30 PM, Paul Clements wrote:
> Could you name this as NBD_SET_FLAGS, as that's more consistent with
> what it's really doing?
I named it differently intentionally, actually, because it should not
use the flags field from the network protocol as is. Also, "features"
sounds more like something that is optional, while unrecognized "flags"
should probably cause a failure.
What about renaming the struct field and leaving this as
NBD_SET_FEATURES or NBD_ENABLE_FEATURES?
Paolo
------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Paul Clements <paul.clements@us.sios.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
nbd-general@lists.sourceforge.net
Subject: Re: [PATCH 2/3] nbd: add support for feature negotiation
Date: Wed, 07 Sep 2011 19:52:42 +0200 [thread overview]
Message-ID: <4E67AF6A.9090400@redhat.com> (raw)
In-Reply-To: <CAECXXi4YW++_302mcSTX=cPjbguSqcw3Weec85VrLFv1qNHXug@mail.gmail.com>
On 09/07/2011 06:30 PM, Paul Clements wrote:
> Could you name this as NBD_SET_FLAGS, as that's more consistent with
> what it's really doing?
I named it differently intentionally, actually, because it should not
use the flags field from the network protocol as is. Also, "features"
sounds more like something that is optional, while unrecognized "flags"
should probably cause a failure.
What about renaming the struct field and leaving this as
NBD_SET_FEATURES or NBD_ENABLE_FEATURES?
Paolo
next prev parent reply other threads:[~2011-09-07 17:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 14:41 [PATCH 0/3] nbd: add support for DISCARD Paolo Bonzini
2011-09-07 14:41 ` Paolo Bonzini
[not found] ` <1315406503-7883-1-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-07 14:41 ` [PATCH 1/3] nbd: remove unused flags fields Paolo Bonzini
2011-09-07 14:41 ` Paolo Bonzini
2011-09-07 14:41 ` [PATCH 2/3] nbd: add support for feature negotiation Paolo Bonzini
2011-09-07 14:41 ` Paolo Bonzini
[not found] ` <1315406503-7883-3-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-07 16:30 ` Paul Clements
2011-09-07 16:30 ` Paul Clements
[not found] ` <CAECXXi4YW++_302mcSTX=cPjbguSqcw3Weec85VrLFv1qNHXug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-07 17:52 ` Paolo Bonzini [this message]
2011-09-07 17:52 ` Paolo Bonzini
[not found] ` <4E67AF6A.9090400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-07 21:54 ` Paul Clements
2011-09-07 21:54 ` Paul Clements
[not found] ` <CAECXXi6NO1gvmREr_31ve-k67fsirqerdm7=ZX0tYqx+Yj52Sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-08 7:00 ` Paolo Bonzini
2011-09-08 7:00 ` Paolo Bonzini
2011-09-07 14:41 ` [PATCH 3/3] nbd: map DISCARD requests to a new nbd request type Paolo Bonzini
[not found] ` <1315406503-7883-4-git-send-email-pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-08 1:13 ` Paul Clements
2011-09-08 1:13 ` Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E67AF6A.9090400@redhat.com \
--to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nbd-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=paul.clements-eviPjrN/1CxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.