* [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability
@ 2011-09-08 10:44 Jan Kiszka
2011-09-09 5:01 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2011-09-08 10:44 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
eepro100 was the last user. Now pci_add_capability is powerful enough.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/pci.c | 6 ------
hw/pci.h | 2 --
2 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 57ff7b1..63c346d 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2028,12 +2028,6 @@ void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size)
pdev->config[PCI_STATUS] &= ~PCI_STATUS_CAP_LIST;
}
-/* Reserve space for capability at a known offset (to call after load). */
-void pci_reserve_capability(PCIDevice *pdev, uint8_t offset, uint8_t size)
-{
- memset(pdev->used + offset, 0xff, size);
-}
-
uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id)
{
return pci_find_capability_list(pdev, cap_id, NULL);
diff --git a/hw/pci.h b/hw/pci.h
index 391217e..f2dae63 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -209,8 +209,6 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
-void pci_reserve_capability(PCIDevice *pci_dev, uint8_t offset, uint8_t size);
-
uint8_t pci_find_capability(PCIDevice *pci_dev, uint8_t cap_id);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability
2011-09-08 10:44 [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability Jan Kiszka
@ 2011-09-09 5:01 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-09-09 5:01 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel
On Thu, Sep 08, 2011 at 12:44:47PM +0200, Jan Kiszka wrote:
> eepro100 was the last user. Now pci_add_capability is powerful enough.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Applied, thanks.
> ---
> hw/pci.c | 6 ------
> hw/pci.h | 2 --
> 2 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 57ff7b1..63c346d 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -2028,12 +2028,6 @@ void pci_del_capability(PCIDevice *pdev, uint8_t cap_id, uint8_t size)
> pdev->config[PCI_STATUS] &= ~PCI_STATUS_CAP_LIST;
> }
>
> -/* Reserve space for capability at a known offset (to call after load). */
> -void pci_reserve_capability(PCIDevice *pdev, uint8_t offset, uint8_t size)
> -{
> - memset(pdev->used + offset, 0xff, size);
> -}
> -
> uint8_t pci_find_capability(PCIDevice *pdev, uint8_t cap_id)
> {
> return pci_find_capability_list(pdev, cap_id, NULL);
> diff --git a/hw/pci.h b/hw/pci.h
> index 391217e..f2dae63 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -209,8 +209,6 @@ int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
>
> void pci_del_capability(PCIDevice *pci_dev, uint8_t cap_id, uint8_t cap_size);
>
> -void pci_reserve_capability(PCIDevice *pci_dev, uint8_t offset, uint8_t size);
> -
> uint8_t pci_find_capability(PCIDevice *pci_dev, uint8_t cap_id);
>
>
> --
> 1.7.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-09 5:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 10:44 [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability Jan Kiszka
2011-09-09 5:01 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.