All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: [PATCH] qemu: Fix inject-nmi
Date: Thu, 22 Sep 2011 17:50:20 +0800	[thread overview]
Message-ID: <4E7B04DC.1030407@cn.fujitsu.com> (raw)
In-Reply-To: <4E76C6AA.9080403@cn.fujitsu.com>


From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH] Fix inject-nmi

Now, inject-nmi sends NMI to all cpus...but this doesn't emulate
pc hardware 'NMI button', which triggers LINT1.

So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to
all cpus without checking LINT1 mask.

Because Linux masks LINT1 of cpus other than 0, this makes trouble.
For example, kdump cannot run sometimes.
---
 hw/apic.c |    7 +++++++
 hw/apic.h |    1 +
 monitor.c |    4 ++--
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/hw/apic.c b/hw/apic.c
index 69d6ac5..020305b 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -205,6 +205,13 @@ void apic_deliver_pic_intr(DeviceState *d, int level)
     }
 }
 
+void apic_deliver_lint1_intr(DeviceState *d)
+{
+    APICState *s = DO_UPCAST(APICState, busdev.qdev, d);
+
+   apic_local_deliver(s, APIC_LVT_LINT1);
+}
+
 #define foreach_apic(apic, deliver_bitmask, code) \
 {\
     int __i, __j, __mask;\
diff --git a/hw/apic.h b/hw/apic.h
index c857d52..7ccf214 100644
--- a/hw/apic.h
+++ b/hw/apic.h
@@ -10,6 +10,7 @@ void apic_deliver_irq(uint8_t dest, uint8_t dest_mode,
                              uint8_t trigger_mode);
 int apic_accept_pic_intr(DeviceState *s);
 void apic_deliver_pic_intr(DeviceState *s, int level);
+void apic_deliver_lint1_intr(DeviceState *s);
 int apic_get_interrupt(DeviceState *s);
 void apic_reset_irq_delivered(void);
 int apic_get_irq_delivered(void);
diff --git a/monitor.c b/monitor.c
index cb485bf..d740478 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2614,9 +2614,9 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
 static int do_inject_nmi(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     CPUState *env;
-
+    /* This emulates hardware NMI button. So, trigger LINT1 */
     for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu_interrupt(env, CPU_INTERRUPT_NMI);
+        apic_deliver_lint1_intr(env->apic_state);
     }
 
     return 0;
-- 1.7.4.1 

WARNING: multiple messages have this Message-ID (diff)
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: [Qemu-devel] [PATCH] qemu: Fix inject-nmi
Date: Thu, 22 Sep 2011 17:50:20 +0800	[thread overview]
Message-ID: <4E7B04DC.1030407@cn.fujitsu.com> (raw)
In-Reply-To: <4E76C6AA.9080403@cn.fujitsu.com>


From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: [PATCH] Fix inject-nmi

Now, inject-nmi sends NMI to all cpus...but this doesn't emulate
pc hardware 'NMI button', which triggers LINT1.

So, now, LINT1 mask is ignored by inject-nmi and NMIs are sent to
all cpus without checking LINT1 mask.

Because Linux masks LINT1 of cpus other than 0, this makes trouble.
For example, kdump cannot run sometimes.
---
 hw/apic.c |    7 +++++++
 hw/apic.h |    1 +
 monitor.c |    4 ++--
 3 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/hw/apic.c b/hw/apic.c
index 69d6ac5..020305b 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -205,6 +205,13 @@ void apic_deliver_pic_intr(DeviceState *d, int level)
     }
 }
 
+void apic_deliver_lint1_intr(DeviceState *d)
+{
+    APICState *s = DO_UPCAST(APICState, busdev.qdev, d);
+
+   apic_local_deliver(s, APIC_LVT_LINT1);
+}
+
 #define foreach_apic(apic, deliver_bitmask, code) \
 {\
     int __i, __j, __mask;\
diff --git a/hw/apic.h b/hw/apic.h
index c857d52..7ccf214 100644
--- a/hw/apic.h
+++ b/hw/apic.h
@@ -10,6 +10,7 @@ void apic_deliver_irq(uint8_t dest, uint8_t dest_mode,
                              uint8_t trigger_mode);
 int apic_accept_pic_intr(DeviceState *s);
 void apic_deliver_pic_intr(DeviceState *s, int level);
+void apic_deliver_lint1_intr(DeviceState *s);
 int apic_get_interrupt(DeviceState *s);
 void apic_reset_irq_delivered(void);
 int apic_get_irq_delivered(void);
diff --git a/monitor.c b/monitor.c
index cb485bf..d740478 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2614,9 +2614,9 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
 static int do_inject_nmi(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     CPUState *env;
-
+    /* This emulates hardware NMI button. So, trigger LINT1 */
     for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu_interrupt(env, CPU_INTERRUPT_NMI);
+        apic_deliver_lint1_intr(env->apic_state);
     }
 
     return 0;
-- 1.7.4.1 

       reply	other threads:[~2011-09-22  9:48 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110913093835.GB4265@localhost.localdomain>
     [not found] ` <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com>
     [not found]   ` <4E705BC3.5000508@cn.fujitsu.com>
     [not found]     ` <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com>
     [not found]       ` <4E71B28F.7030201@cn.fujitsu.com>
     [not found]         ` <4E72F3BA.2000603@jp.fujitsu.com>
     [not found]           ` <4E73200A.7040908@jp.fujitsu.com>
     [not found]             ` <4E76C6AA.9080403@cn.fujitsu.com>
2011-09-22  9:50               ` Lai Jiangshan [this message]
2011-09-22  9:50                 ` [Qemu-devel] [PATCH] qemu: Fix inject-nmi Lai Jiangshan
2011-09-22 14:51                 ` Jan Kiszka
2011-09-22 14:51                   ` [Qemu-devel] " Jan Kiszka
2011-09-23  9:31                   ` Lai Jiangshan
2011-09-23  9:31                     ` Lai Jiangshan
2011-09-23  9:35                     ` Jan Kiszka
2011-09-23  9:35                       ` Jan Kiszka
2011-09-25 14:07                     ` Avi Kivity
2011-09-25 14:07                       ` [Qemu-devel] " Avi Kivity
2011-09-25 17:22                       ` Jan Kiszka
2011-09-25 17:22                         ` [Qemu-devel] " Jan Kiszka
2011-09-26  8:21                         ` Avi Kivity
2011-09-26  8:21                           ` [Qemu-devel] " Avi Kivity
2011-10-10  6:06                           ` Lai Jiangshan
2011-10-10  6:06                             ` [Qemu-devel] " Lai Jiangshan
2011-10-10  6:06                           ` [PATCH] kernel/kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:06                             ` [Qemu-devel] [PATCH] kernel/kvm: fix improper nmi emulation (was: " Lai Jiangshan
2011-10-10  6:40                             ` [PATCH] kernel/kvm: fix improper nmi emulation Jan Kiszka
2011-10-10  6:40                               ` [Qemu-devel] " Jan Kiszka
2011-10-10 10:26                             ` Avi Kivity
2011-10-10 10:26                               ` [Qemu-devel] " Avi Kivity
2011-10-11 17:00                               ` [PATCH 1/1 V2] " Lai Jiangshan
2011-10-11 17:00                                 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 18:06                                 ` Jan Kiszka
2011-10-11 18:06                                   ` [Qemu-devel] " Jan Kiszka
2011-10-14  0:54                                   ` [PATCH 1/1 V3] " Lai Jiangshan
2011-10-14  0:54                                     ` [Qemu-devel] " Lai Jiangshan
2011-10-16  8:54                                     ` Avi Kivity
2011-10-16  8:54                                       ` [Qemu-devel] " Avi Kivity
2011-10-16  9:05                                       ` Jan Kiszka
2011-10-16  9:05                                         ` [Qemu-devel] " Jan Kiszka
2011-10-16  9:28                                         ` Avi Kivity
2011-10-16  9:28                                           ` [Qemu-devel] " Avi Kivity
2011-10-12  7:02                                 ` [PATCH 1/1 V2] " Kenji Kaneshige
2011-10-12  7:02                                   ` [Qemu-devel] " Kenji Kaneshige
2011-10-12  7:01                               ` [PATCH] " Kenji Kaneshige
2011-10-12  7:01                                 ` [Qemu-devel] " Kenji Kaneshige
2011-10-10  6:06                           ` [PATCH] qemu-kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:06                             ` [Qemu-devel] [PATCH] qemu-kvm: fix improper nmi emulation (was: " Lai Jiangshan
2011-10-10  6:49                             ` [PATCH] qemu-kvm: fix improper nmi emulation Jan Kiszka
2011-10-10  6:49                               ` [Qemu-devel] " Jan Kiszka
2011-10-10  9:47                               ` Andreas Färber
2011-10-10  9:47                                 ` [Qemu-devel] " Andreas Färber
2011-10-11 17:03                               ` [PATCH 1/2 V2] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-11 17:03                                 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 17:03                               ` [PATCH 2/2 V2] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-11 17:03                                 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 18:17                                 ` Jan Kiszka
2011-10-11 18:17                                   ` [Qemu-devel] " Jan Kiszka
2011-10-14  0:53                                   ` Lai Jiangshan
2011-10-14  0:53                                     ` Lai Jiangshan
2011-10-14  5:53                                     ` Jan Kiszka
2011-10-14  5:53                                       ` Jan Kiszka
2011-10-14  6:36                                       ` [PATCH 1/1 V4] " Lai Jiangshan
2011-10-14  6:36                                         ` [Qemu-devel] " Lai Jiangshan
2011-10-14  6:49                                         ` Jan Kiszka
2011-10-14  6:49                                           ` [Qemu-devel] " Jan Kiszka
2011-10-14  7:43                                           ` Lai Jiangshan
2011-10-14  7:43                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14  8:31                                             ` Jan Kiszka
2011-10-14  8:31                                               ` [Qemu-devel] " Jan Kiszka
2011-10-14  9:03                                           ` [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14  9:03                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14  9:07                                             ` Jan Kiszka
2011-10-14  9:07                                               ` [Qemu-devel] " Jan Kiszka
2011-10-14  9:27                                               ` Lai Jiangshan
2011-10-14  9:27                                                 ` Lai Jiangshan
2011-10-14  9:32                                                 ` Jan Kiszka
2011-10-14  9:32                                                   ` Jan Kiszka
2011-10-16  9:39                                             ` Avi Kivity
2011-10-16  9:39                                               ` [Qemu-devel] " Avi Kivity
2011-10-17  9:17                                               ` Lai Jiangshan
2011-10-17  9:17                                                 ` [Qemu-devel] " Lai Jiangshan
2011-10-17  9:54                                                 ` Avi Kivity
2011-10-17  9:54                                                   ` [Qemu-devel] " Avi Kivity
2011-10-17 10:21                                                   ` Jan Kiszka
2011-10-17 10:21                                                     ` [Qemu-devel] " Jan Kiszka
2011-10-17  9:40                                               ` Lai Jiangshan
2011-10-17  9:40                                                 ` [Qemu-devel] " Lai Jiangshan
2011-10-17  9:49                                                 ` Avi Kivity
2011-10-17  9:49                                                   ` [Qemu-devel] " Avi Kivity
2011-10-17 16:00                                                   ` [PATCH 1/1 V6] qemu-kvm: " Lai Jiangshan
2011-10-17 16:00                                                     ` [Qemu-devel] " Lai Jiangshan
2011-10-18 19:41                                                     ` Jan Kiszka
2011-10-18 19:41                                                       ` [Qemu-devel] " Jan Kiszka
2011-10-19  6:33                                                       ` Lai Jiangshan
2011-10-19  6:33                                                         ` [Qemu-devel] " Lai Jiangshan
2011-10-19 10:57                                                         ` Jan Kiszka
2011-10-19 10:57                                                           ` [Qemu-devel] " Jan Kiszka
2011-10-19 15:21                                                           ` [PATCH 1/1 V6] qemu: " Lai Jiangshan
2011-10-19 15:21                                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-19  9:29                                                       ` [PATCH 1/1 V6] qemu-kvm: " Avi Kivity
2011-10-19  9:29                                                         ` [Qemu-devel] " Avi Kivity
2011-10-19 15:32                                                         ` Lai Jiangshan
2011-10-19 15:32                                                           ` [Qemu-devel] " Lai Jiangshan
2011-12-07 10:29                                                     ` Avi Kivity
2011-12-07 10:29                                                       ` [Qemu-devel] " Avi Kivity
2011-12-08  9:42                                                       ` Jan Kiszka
2011-12-08  9:42                                                         ` [Qemu-devel] " Jan Kiszka
2011-12-08 10:20                                                         ` Jan Kiszka
2011-12-08 10:20                                                           ` [Qemu-devel] " Jan Kiszka
2011-10-14  9:03                                           ` [PATCH 1/2 V5] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14  9:03                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14  9:03                                           ` [PATCH 2/2 V5] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-14  9:03                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14  9:22                                             ` Jan Kiszka
2011-10-14  9:22                                               ` [Qemu-devel] " Jan Kiszka
2011-10-14  9:51                                           ` [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14  9:51                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14 11:59                                             ` Sasha Levin
2011-10-14 11:59                                               ` [Qemu-devel] " Sasha Levin
2011-10-14 12:07                                               ` Jan Kiszka
2011-10-14 12:07                                                 ` Jan Kiszka
2011-10-16 15:01                                                 ` Lai Jiangshan
2011-10-16 15:01                                                   ` Lai Jiangshan
2011-10-14  9:51                                           ` [PATCH 1/2 V5 tuning] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14  9:51                                             ` [Qemu-devel] " Lai Jiangshan
2011-10-14  0:54                                   ` [PATCH 1/1 V3] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-14  0:54                                     ` [Qemu-devel] " Lai Jiangshan
2011-10-10  6:06                           ` [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:06                             ` [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: " Lai Jiangshan
2011-10-28 12:08                             ` [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT Kenji Kaneshige
2011-10-28 12:08                               ` [Qemu-devel] " Kenji Kaneshige
2011-10-28 12:19                               ` Gleb Natapov
2011-10-28 12:19                                 ` [Qemu-devel] " Gleb Natapov
2011-10-28 12:48                               ` Jun Koi
2011-10-28 12:48                                 ` Jun Koi
2011-10-31  8:00                                 ` Kenji Kaneshige
2011-10-31  8:00                                   ` Kenji Kaneshige
2011-10-30 14:44                             ` Avi Kivity
2011-10-30 14:44                               ` [Qemu-devel] " Avi Kivity
2011-10-30 14:44                               ` Avi Kivity
2011-10-30 14:44                                 ` [Qemu-devel] " Avi Kivity
2011-10-10  6:06                           ` [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:06                             ` [Qemu-devel] [PATCH 2/2] seabios: fix mptable nmi entry (was: " Lai Jiangshan
2011-10-30 17:52                             ` [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] " Kevin O'Connor
2011-10-30 17:52                               ` [Qemu-devel] [PATCH 2/2] seabios: fix mptable nmi entry (was: " Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7B04DC.1030407@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.