From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Jun Koi <junkoi2004@gmail.com>
Cc: Avi Kivity <avi@redhat.com>, Jan Kiszka <jan.kiszka@web.de>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
seabios@seabios.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
gleb@redhat.com, kevin@koconnor.net,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT
Date: Mon, 31 Oct 2011 17:00:52 +0900 [thread overview]
Message-ID: <4EAE55B4.30604@jp.fujitsu.com> (raw)
In-Reply-To: <CA+g7VZ3wH++QFgEMdeQZAVDx-VJeU5Qe7kEjvdHuBndag=x7fw@mail.gmail.com>
(2011/10/28 21:48), Jun Koi wrote:
> 2011/10/28 Kenji Kaneshige<kaneshige.kenji@jp.fujitsu.com>:
>> Avi, Jan,
>>
>> Could you comment on these patches?
>>
>> Inject-NMI doesn't work on Windows guest without these patches.
>
> sorry but i am really curious here: why Windows still works well even
> if it desnt see the inject-NMI?
> or there are still invisible side-effects that we are not awere of???
Without this patch, LVT LINT1 is not configured by Windows guest because
seabios MADT has no ACPI NMI structure which is used by Windows to setup
LVT. So NMI interrupt would not be sent to CPUs when NMI signal happens
on LINT1. But qemu/kvm inject-nmi feature had a bug that it sent NMI to
CPUs without emulating LAPIC LVT. As a result, NMI interrupt is sent to
all the CPUs even though LVT LINT1 is not configured. This is why
inject-nmi behaves as if it works well on Windows guest.
Regards,
Kenji Kaneshige
WARNING: multiple messages have this Message-ID (diff)
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Jun Koi <junkoi2004@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
seabios@seabios.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
gleb@redhat.com, kevin@koconnor.net,
Jan Kiszka <jan.kiszka@web.de>, Avi Kivity <avi@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT
Date: Mon, 31 Oct 2011 17:00:52 +0900 [thread overview]
Message-ID: <4EAE55B4.30604@jp.fujitsu.com> (raw)
In-Reply-To: <CA+g7VZ3wH++QFgEMdeQZAVDx-VJeU5Qe7kEjvdHuBndag=x7fw@mail.gmail.com>
(2011/10/28 21:48), Jun Koi wrote:
> 2011/10/28 Kenji Kaneshige<kaneshige.kenji@jp.fujitsu.com>:
>> Avi, Jan,
>>
>> Could you comment on these patches?
>>
>> Inject-NMI doesn't work on Windows guest without these patches.
>
> sorry but i am really curious here: why Windows still works well even
> if it desnt see the inject-NMI?
> or there are still invisible side-effects that we are not awere of???
Without this patch, LVT LINT1 is not configured by Windows guest because
seabios MADT has no ACPI NMI structure which is used by Windows to setup
LVT. So NMI interrupt would not be sent to CPUs when NMI signal happens
on LINT1. But qemu/kvm inject-nmi feature had a bug that it sent NMI to
CPUs without emulating LAPIC LVT. As a result, NMI interrupt is sent to
all the CPUs even though LVT LINT1 is not configured. This is why
inject-nmi behaves as if it works well on Windows guest.
Regards,
Kenji Kaneshige
next prev parent reply other threads:[~2011-10-31 8:01 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110913093835.GB4265@localhost.localdomain>
[not found] ` <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com>
[not found] ` <4E705BC3.5000508@cn.fujitsu.com>
[not found] ` <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com>
[not found] ` <4E71B28F.7030201@cn.fujitsu.com>
[not found] ` <4E72F3BA.2000603@jp.fujitsu.com>
[not found] ` <4E73200A.7040908@jp.fujitsu.com>
[not found] ` <4E76C6AA.9080403@cn.fujitsu.com>
2011-09-22 9:50 ` [PATCH] qemu: Fix inject-nmi Lai Jiangshan
2011-09-22 9:50 ` [Qemu-devel] " Lai Jiangshan
2011-09-22 14:51 ` Jan Kiszka
2011-09-22 14:51 ` [Qemu-devel] " Jan Kiszka
2011-09-23 9:31 ` Lai Jiangshan
2011-09-23 9:31 ` Lai Jiangshan
2011-09-23 9:35 ` Jan Kiszka
2011-09-23 9:35 ` Jan Kiszka
2011-09-25 14:07 ` Avi Kivity
2011-09-25 14:07 ` [Qemu-devel] " Avi Kivity
2011-09-25 17:22 ` Jan Kiszka
2011-09-25 17:22 ` [Qemu-devel] " Jan Kiszka
2011-09-26 8:21 ` Avi Kivity
2011-09-26 8:21 ` [Qemu-devel] " Avi Kivity
2011-10-10 6:06 ` Lai Jiangshan
2011-10-10 6:06 ` [Qemu-devel] " Lai Jiangshan
2011-10-10 6:06 ` [PATCH] kernel/kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10 6:06 ` [Qemu-devel] [PATCH] kernel/kvm: fix improper nmi emulation (was: " Lai Jiangshan
2011-10-10 6:40 ` [PATCH] kernel/kvm: fix improper nmi emulation Jan Kiszka
2011-10-10 6:40 ` [Qemu-devel] " Jan Kiszka
2011-10-10 10:26 ` Avi Kivity
2011-10-10 10:26 ` [Qemu-devel] " Avi Kivity
2011-10-11 17:00 ` [PATCH 1/1 V2] " Lai Jiangshan
2011-10-11 17:00 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 18:06 ` Jan Kiszka
2011-10-11 18:06 ` [Qemu-devel] " Jan Kiszka
2011-10-14 0:54 ` [PATCH 1/1 V3] " Lai Jiangshan
2011-10-14 0:54 ` [Qemu-devel] " Lai Jiangshan
2011-10-16 8:54 ` Avi Kivity
2011-10-16 8:54 ` [Qemu-devel] " Avi Kivity
2011-10-16 9:05 ` Jan Kiszka
2011-10-16 9:05 ` [Qemu-devel] " Jan Kiszka
2011-10-16 9:28 ` Avi Kivity
2011-10-16 9:28 ` [Qemu-devel] " Avi Kivity
2011-10-12 7:02 ` [PATCH 1/1 V2] " Kenji Kaneshige
2011-10-12 7:02 ` [Qemu-devel] " Kenji Kaneshige
2011-10-12 7:01 ` [PATCH] " Kenji Kaneshige
2011-10-12 7:01 ` [Qemu-devel] " Kenji Kaneshige
2011-10-10 6:06 ` [PATCH] qemu-kvm: fix improper nmi emulation (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10 6:06 ` [Qemu-devel] [PATCH] qemu-kvm: fix improper nmi emulation (was: " Lai Jiangshan
2011-10-10 6:49 ` [PATCH] qemu-kvm: fix improper nmi emulation Jan Kiszka
2011-10-10 6:49 ` [Qemu-devel] " Jan Kiszka
2011-10-10 9:47 ` Andreas Färber
2011-10-10 9:47 ` [Qemu-devel] " Andreas Färber
2011-10-11 17:03 ` [PATCH 1/2 V2] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-11 17:03 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 17:03 ` [PATCH 2/2 V2] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-11 17:03 ` [Qemu-devel] " Lai Jiangshan
2011-10-11 18:17 ` Jan Kiszka
2011-10-11 18:17 ` [Qemu-devel] " Jan Kiszka
2011-10-14 0:53 ` Lai Jiangshan
2011-10-14 0:53 ` Lai Jiangshan
2011-10-14 5:53 ` Jan Kiszka
2011-10-14 5:53 ` Jan Kiszka
2011-10-14 6:36 ` [PATCH 1/1 V4] " Lai Jiangshan
2011-10-14 6:36 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 6:49 ` Jan Kiszka
2011-10-14 6:49 ` [Qemu-devel] " Jan Kiszka
2011-10-14 7:43 ` Lai Jiangshan
2011-10-14 7:43 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 8:31 ` Jan Kiszka
2011-10-14 8:31 ` [Qemu-devel] " Jan Kiszka
2011-10-14 9:03 ` [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14 9:03 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 9:07 ` Jan Kiszka
2011-10-14 9:07 ` [Qemu-devel] " Jan Kiszka
2011-10-14 9:27 ` Lai Jiangshan
2011-10-14 9:27 ` Lai Jiangshan
2011-10-14 9:32 ` Jan Kiszka
2011-10-14 9:32 ` Jan Kiszka
2011-10-16 9:39 ` Avi Kivity
2011-10-16 9:39 ` [Qemu-devel] " Avi Kivity
2011-10-17 9:17 ` Lai Jiangshan
2011-10-17 9:17 ` [Qemu-devel] " Lai Jiangshan
2011-10-17 9:54 ` Avi Kivity
2011-10-17 9:54 ` [Qemu-devel] " Avi Kivity
2011-10-17 10:21 ` Jan Kiszka
2011-10-17 10:21 ` [Qemu-devel] " Jan Kiszka
2011-10-17 9:40 ` Lai Jiangshan
2011-10-17 9:40 ` [Qemu-devel] " Lai Jiangshan
2011-10-17 9:49 ` Avi Kivity
2011-10-17 9:49 ` [Qemu-devel] " Avi Kivity
2011-10-17 16:00 ` [PATCH 1/1 V6] qemu-kvm: " Lai Jiangshan
2011-10-17 16:00 ` [Qemu-devel] " Lai Jiangshan
2011-10-18 19:41 ` Jan Kiszka
2011-10-18 19:41 ` [Qemu-devel] " Jan Kiszka
2011-10-19 6:33 ` Lai Jiangshan
2011-10-19 6:33 ` [Qemu-devel] " Lai Jiangshan
2011-10-19 10:57 ` Jan Kiszka
2011-10-19 10:57 ` [Qemu-devel] " Jan Kiszka
2011-10-19 15:21 ` [PATCH 1/1 V6] qemu: " Lai Jiangshan
2011-10-19 15:21 ` [Qemu-devel] " Lai Jiangshan
2011-10-19 9:29 ` [PATCH 1/1 V6] qemu-kvm: " Avi Kivity
2011-10-19 9:29 ` [Qemu-devel] " Avi Kivity
2011-10-19 15:32 ` Lai Jiangshan
2011-10-19 15:32 ` [Qemu-devel] " Lai Jiangshan
2011-12-07 10:29 ` Avi Kivity
2011-12-07 10:29 ` [Qemu-devel] " Avi Kivity
2011-12-08 9:42 ` Jan Kiszka
2011-12-08 9:42 ` [Qemu-devel] " Jan Kiszka
2011-12-08 10:20 ` Jan Kiszka
2011-12-08 10:20 ` [Qemu-devel] " Jan Kiszka
2011-10-14 9:03 ` [PATCH 1/2 V5] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14 9:03 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 9:03 ` [PATCH 2/2 V5] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-14 9:03 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 9:22 ` Jan Kiszka
2011-10-14 9:22 ` [Qemu-devel] " Jan Kiszka
2011-10-14 9:51 ` [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14 9:51 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 11:59 ` Sasha Levin
2011-10-14 11:59 ` [Qemu-devel] " Sasha Levin
2011-10-14 12:07 ` Jan Kiszka
2011-10-14 12:07 ` Jan Kiszka
2011-10-16 15:01 ` Lai Jiangshan
2011-10-16 15:01 ` Lai Jiangshan
2011-10-14 9:51 ` [PATCH 1/2 V5 tuning] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14 9:51 ` [Qemu-devel] " Lai Jiangshan
2011-10-14 0:54 ` [PATCH 1/1 V3] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-14 0:54 ` [Qemu-devel] " Lai Jiangshan
2011-10-10 6:06 ` [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10 6:06 ` [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: " Lai Jiangshan
2011-10-28 12:08 ` [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT Kenji Kaneshige
2011-10-28 12:08 ` [Qemu-devel] " Kenji Kaneshige
2011-10-28 12:19 ` Gleb Natapov
2011-10-28 12:19 ` [Qemu-devel] " Gleb Natapov
2011-10-28 12:48 ` Jun Koi
2011-10-28 12:48 ` Jun Koi
2011-10-31 8:00 ` Kenji Kaneshige [this message]
2011-10-31 8:00 ` Kenji Kaneshige
2011-10-30 14:44 ` Avi Kivity
2011-10-30 14:44 ` [Qemu-devel] " Avi Kivity
2011-10-30 14:44 ` Avi Kivity
2011-10-30 14:44 ` [Qemu-devel] " Avi Kivity
2011-10-10 6:06 ` [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10 6:06 ` [Qemu-devel] [PATCH 2/2] seabios: fix mptable nmi entry (was: " Lai Jiangshan
2011-10-30 17:52 ` [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [Qemu-devel] " Kevin O'Connor
2011-10-30 17:52 ` [Qemu-devel] [PATCH 2/2] seabios: fix mptable nmi entry (was: " Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAE55B4.30604@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=junkoi2004@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.