From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, alan@linux.intel.com,
linux-serial@vger.kernel.org, plagnioj@jcrosoft.com,
linux-kernel@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function
Date: Mon, 03 Oct 2011 11:49:11 +0200 [thread overview]
Message-ID: <4E898517.6020104@atmel.com> (raw)
In-Reply-To: <4355360.0xR5ZY7sEk@wuerfel>
On 10/03/2011 11:36 AM, Arnd Bergmann :
> On Monday 03 October 2011 12:11:19 Nicolas Ferre wrote:
>> }
>>
>> static struct platform_driver atmel_serial_driver = {
>> - .probe = atmel_serial_probe,
>> + .probe = __devinit_p(atmel_serial_probe),
>> .remove = __devexit_p(atmel_serial_remove),
>> .suspend = atmel_serial_suspend,
>> .resume = atmel_serial_resume,
>
> Still wrong: __devinit_p does not exist and is not needed.
OMG, the not-enouth-coffee syndrome... twice!
So we forget all this and I try to increase my signal/noise ratio ;-)
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function
Date: Mon, 03 Oct 2011 11:49:11 +0200 [thread overview]
Message-ID: <4E898517.6020104@atmel.com> (raw)
In-Reply-To: <4355360.0xR5ZY7sEk@wuerfel>
On 10/03/2011 11:36 AM, Arnd Bergmann :
> On Monday 03 October 2011 12:11:19 Nicolas Ferre wrote:
>> }
>>
>> static struct platform_driver atmel_serial_driver = {
>> - .probe = atmel_serial_probe,
>> + .probe = __devinit_p(atmel_serial_probe),
>> .remove = __devexit_p(atmel_serial_remove),
>> .suspend = atmel_serial_suspend,
>> .resume = atmel_serial_resume,
>
> Still wrong: __devinit_p does not exist and is not needed.
OMG, the not-enouth-coffee syndrome... twice!
So we forget all this and I try to increase my signal/noise ratio ;-)
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2011-10-03 9:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 9:46 [PATCH 1/3] tty/serial: atmel_serial: change platform_data variable name Nicolas Ferre
2011-10-03 9:46 ` Nicolas Ferre
2011-10-03 9:46 ` [PATCH 2/3] tty/serial: atmel_serial: whitespace and braces modifications Nicolas Ferre
2011-10-03 9:46 ` Nicolas Ferre
2011-10-03 9:46 ` Nicolas Ferre
2011-10-03 9:46 ` [PATCH 3/3] tty/serial: atmel_serial: __devinit_p for probe function Nicolas Ferre
2011-10-03 9:46 ` Nicolas Ferre
2011-10-03 8:50 ` Russell King - ARM Linux
2011-10-03 8:50 ` Russell King - ARM Linux
2011-10-03 8:50 ` Russell King - ARM Linux
2011-10-03 8:56 ` Nicolas Ferre
2011-10-03 8:56 ` Nicolas Ferre
[not found] ` <b371e80a96a36d962fb8806c2bd7aa20bb688b88.1317636473.git.nicolas.ferre@atmel.com>
2011-10-03 10:11 ` Nicolas Ferre
2011-10-03 10:11 ` Nicolas Ferre
2011-10-03 9:36 ` Arnd Bergmann
2011-10-03 9:36 ` Arnd Bergmann
2011-10-03 9:49 ` Nicolas Ferre [this message]
2011-10-03 9:49 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E898517.6020104@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.