All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/4] ARM: OMAP: Move set_globals initialization to happen in init_early
Date: Fri, 07 Oct 2011 12:26:36 +0530	[thread overview]
Message-ID: <4E8EA2A4.5070301@ti.com> (raw)
In-Reply-To: <20111006013656.GG6324@atomide.com>

On Thursday 06 October 2011 07:06 AM, Tony Lindgren wrote:
> * Nicolas Pitre <nico@fluxnic.net> [111004 18:17]:
>> On Tue, 4 Oct 2011, Tony Lindgren wrote:
>>
>>> Otherwise we can't do generic map_io as we currently rely on
>>> static mappings that work only because of arch_ioremap.
>>>
>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>
>> That's great.
>>
>> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> 
> Here's an updated version with all the early ioremap
> access converted to use L3/L4_IO_ADDRESS macros. Some
> of this may not be needed after generic map_io, but until
> then we can't use ioremap until in init_early after the
> SoC detection is done.
> 
> Regards,
> 
> Tony
> 
> 
> From: Tony Lindgren <tony@atomide.com>
> Date: Tue, 4 Oct 2011 18:17:41 -0700
> Subject: [PATCH] ARM: OMAP: Move set_globals initialization to happen in init_early
> 
> Otherwise we can't do generic map_io as we currently rely on
> static mappings that work only because of arch_ioremap.
> 
> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
The changes looks fine to me. Though the ugly hard-coding
is back with it, it's a step towards generic_io, so hopefully
it won't have to stay for long time.

Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>	


considering it's commin

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/4] ARM: OMAP: Move set_globals initialization to happen in init_early
Date: Fri, 07 Oct 2011 12:26:36 +0530	[thread overview]
Message-ID: <4E8EA2A4.5070301@ti.com> (raw)
In-Reply-To: <20111006013656.GG6324@atomide.com>

On Thursday 06 October 2011 07:06 AM, Tony Lindgren wrote:
> * Nicolas Pitre <nico@fluxnic.net> [111004 18:17]:
>> On Tue, 4 Oct 2011, Tony Lindgren wrote:
>>
>>> Otherwise we can't do generic map_io as we currently rely on
>>> static mappings that work only because of arch_ioremap.
>>>
>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>
>> That's great.
>>
>> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> 
> Here's an updated version with all the early ioremap
> access converted to use L3/L4_IO_ADDRESS macros. Some
> of this may not be needed after generic map_io, but until
> then we can't use ioremap until in init_early after the
> SoC detection is done.
> 
> Regards,
> 
> Tony
> 
> 
> From: Tony Lindgren <tony@atomide.com>
> Date: Tue, 4 Oct 2011 18:17:41 -0700
> Subject: [PATCH] ARM: OMAP: Move set_globals initialization to happen in init_early
> 
> Otherwise we can't do generic map_io as we currently rely on
> static mappings that work only because of arch_ioremap.
> 
> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
The changes looks fine to me. Though the ugly hard-coding
is back with it, it's a step towards generic_io, so hopefully
it won't have to stay for long time.

Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com>	


considering it's commin

  reply	other threads:[~2011-10-07  6:56 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  0:45 [PATCH 0/4] initialize omap SRAM later on with __arm_ioremap_exec() Tony Lindgren
2011-10-05  0:45 ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  1:00   ` Nicolas Pitre
2011-10-05  1:00     ` Nicolas Pitre
2011-10-05 22:06     ` Tony Lindgren
2011-10-05 22:06       ` Tony Lindgren
2011-10-05 22:08       ` [PATCH 1.5/4] ARM: OMAP1: Use generic map_io, init_early and init_irq Tony Lindgren
2011-10-05 22:08         ` Tony Lindgren
2011-10-07  6:40       ` [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY Santosh Shilimkar
2011-10-07  6:40         ` Santosh Shilimkar
2011-10-07 14:43         ` Tony Lindgren
2011-10-07 14:43           ` Tony Lindgren
2011-10-07 15:03           ` Santosh Shilimkar
2011-10-07 15:03             ` Santosh Shilimkar
2011-10-07 15:11             ` Tony Lindgren
2011-10-07 15:11               ` Tony Lindgren
2011-10-07 17:39               ` Santosh Shilimkar
2011-10-07 17:39                 ` Santosh Shilimkar
2011-10-07 18:16                 ` Tony Lindgren
2011-10-07 18:16                   ` Tony Lindgren
2011-10-07 18:20                   ` Santosh Shilimkar
2011-10-07 18:20                     ` Santosh Shilimkar
2011-10-07 18:27                     ` Tony Lindgren
2011-10-07 18:27                       ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 2/4] ARM: OMAP: Avoid cpu_is_omapxxxx usage until map_io is done Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-07  6:47   ` Santosh Shilimkar
2011-10-07  6:47     ` Santosh Shilimkar
2011-10-05  0:45 ` [PATCH 3/4] ARM: OMAP: Remove calls to SRAM allocations for framebuffer Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  6:45   ` Tomi Valkeinen
2011-10-05  6:45     ` Tomi Valkeinen
2011-10-05 22:41     ` Tony Lindgren
2011-10-05 22:41       ` Tony Lindgren
2011-10-06  8:38       ` Tomi Valkeinen
2011-10-06  8:38         ` Tomi Valkeinen
2011-10-06 16:22         ` Tony Lindgren
2011-10-06 16:22           ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 4/4] ARM: OMAP: Map SRAM later on with ioremap_exec() Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  1:07   ` Nicolas Pitre
2011-10-05  1:07     ` Nicolas Pitre
2011-10-05 22:13     ` Tony Lindgren
2011-10-05 22:13       ` Tony Lindgren
2011-10-05 23:01       ` Nicolas Pitre
2011-10-05 23:01         ` Nicolas Pitre
2011-10-07  6:52       ` Santosh Shilimkar
2011-10-07  6:52         ` Santosh Shilimkar
2011-10-07 14:55         ` Tony Lindgren
2011-10-07 14:55           ` Tony Lindgren
2011-10-05  1:40 ` [PATCH 5/4] ARM: OMAP: Move set_globals initialization to happen in init_early Tony Lindgren
2011-10-05  1:40   ` Tony Lindgren
2011-10-05  1:51   ` Nicolas Pitre
2011-10-05  1:51     ` Nicolas Pitre
2011-10-06  1:36     ` Tony Lindgren
2011-10-06  1:36       ` Tony Lindgren
2011-10-07  6:56       ` Santosh Shilimkar [this message]
2011-10-07  6:56         ` Santosh Shilimkar
2011-10-07 14:54         ` Tony Lindgren
2011-10-07 14:54           ` Tony Lindgren
2011-10-07 23:26           ` Nicolas Pitre
2011-10-07 23:26             ` Nicolas Pitre
2011-10-05  7:03 ` [PATCH 0/4] initialize omap SRAM later on with __arm_ioremap_exec() Santosh Shilimkar
2011-10-05  7:03   ` Santosh Shilimkar
2011-10-06  1:42   ` Tony Lindgren
2011-10-06  1:42     ` Tony Lindgren
2011-10-07  6:59     ` Santosh Shilimkar
2011-10-07  6:59       ` Santosh Shilimkar
2011-10-07 14:45       ` Tony Lindgren
2011-10-07 14:45         ` Tony Lindgren
2011-10-07 20:23       ` Nicolas Pitre
2011-10-07 20:23         ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8EA2A4.5070301@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.