All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY
Date: Fri, 07 Oct 2011 23:50:04 +0530	[thread overview]
Message-ID: <4E8F42D4.7030502@ti.com> (raw)
In-Reply-To: <20111007181621.GJ6324@atomide.com>

On Friday 07 October 2011 11:46 PM, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [111007 10:05]:
>>
>> I initially tried some thing similar but the issue was GP and
>> HS devices. SRAM_PA isn't same on GP and EMU device and hence
>> did that dynamically. One way is I can make GP and HS
>> device SRAM_PA same for OMAP4 (Will loose 16 KB of
>> SRAM on OMAP4 GP). It's ok to loose that 16 KB SRAM
>> for OMAP4 with errata enabled.
> 
> Oh yeah, the beginning is different too, I forgot that.
>  
>> Below change works on both GP and HS device
>> If you are OK with it, I can update errata patch accordingly.
> 
> OK to me to loose 16KB when the errata is enabled. That can
> be fixed later on for example by passing the SRAM area from
> device tree.
>
Yep.

> I assume now you can add the mapping to io.c instead? If so,
> then it's easier to apply the patches whatever way makes more
> sense.
> 
io.c change I took as you suggested. The below change on top
of it. I just updated PM branch with this change.

Thanks for the tip. The errata code looks bit more clean
now. :)

Regards
Santosh

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY
Date: Fri, 07 Oct 2011 23:50:04 +0530	[thread overview]
Message-ID: <4E8F42D4.7030502@ti.com> (raw)
In-Reply-To: <20111007181621.GJ6324@atomide.com>

On Friday 07 October 2011 11:46 PM, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [111007 10:05]:
>>
>> I initially tried some thing similar but the issue was GP and
>> HS devices. SRAM_PA isn't same on GP and EMU device and hence
>> did that dynamically. One way is I can make GP and HS
>> device SRAM_PA same for OMAP4 (Will loose 16 KB of
>> SRAM on OMAP4 GP). It's ok to loose that 16 KB SRAM
>> for OMAP4 with errata enabled.
> 
> Oh yeah, the beginning is different too, I forgot that.
>  
>> Below change works on both GP and HS device
>> If you are OK with it, I can update errata patch accordingly.
> 
> OK to me to loose 16KB when the errata is enabled. That can
> be fixed later on for example by passing the SRAM area from
> device tree.
>
Yep.

> I assume now you can add the mapping to io.c instead? If so,
> then it's easier to apply the patches whatever way makes more
> sense.
> 
io.c change I took as you suggested. The below change on top
of it. I just updated PM branch with this change.

Thanks for the tip. The errata code looks bit more clean
now. :)

Regards
Santosh

  reply	other threads:[~2011-10-07 18:20 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  0:45 [PATCH 0/4] initialize omap SRAM later on with __arm_ioremap_exec() Tony Lindgren
2011-10-05  0:45 ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  1:00   ` Nicolas Pitre
2011-10-05  1:00     ` Nicolas Pitre
2011-10-05 22:06     ` Tony Lindgren
2011-10-05 22:06       ` Tony Lindgren
2011-10-05 22:08       ` [PATCH 1.5/4] ARM: OMAP1: Use generic map_io, init_early and init_irq Tony Lindgren
2011-10-05 22:08         ` Tony Lindgren
2011-10-07  6:40       ` [PATCH 1/4] ARM: Add __arm_ioremap_exec for mapping external memory as MT_MEMORY Santosh Shilimkar
2011-10-07  6:40         ` Santosh Shilimkar
2011-10-07 14:43         ` Tony Lindgren
2011-10-07 14:43           ` Tony Lindgren
2011-10-07 15:03           ` Santosh Shilimkar
2011-10-07 15:03             ` Santosh Shilimkar
2011-10-07 15:11             ` Tony Lindgren
2011-10-07 15:11               ` Tony Lindgren
2011-10-07 17:39               ` Santosh Shilimkar
2011-10-07 17:39                 ` Santosh Shilimkar
2011-10-07 18:16                 ` Tony Lindgren
2011-10-07 18:16                   ` Tony Lindgren
2011-10-07 18:20                   ` Santosh Shilimkar [this message]
2011-10-07 18:20                     ` Santosh Shilimkar
2011-10-07 18:27                     ` Tony Lindgren
2011-10-07 18:27                       ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 2/4] ARM: OMAP: Avoid cpu_is_omapxxxx usage until map_io is done Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-07  6:47   ` Santosh Shilimkar
2011-10-07  6:47     ` Santosh Shilimkar
2011-10-05  0:45 ` [PATCH 3/4] ARM: OMAP: Remove calls to SRAM allocations for framebuffer Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  6:45   ` Tomi Valkeinen
2011-10-05  6:45     ` Tomi Valkeinen
2011-10-05 22:41     ` Tony Lindgren
2011-10-05 22:41       ` Tony Lindgren
2011-10-06  8:38       ` Tomi Valkeinen
2011-10-06  8:38         ` Tomi Valkeinen
2011-10-06 16:22         ` Tony Lindgren
2011-10-06 16:22           ` Tony Lindgren
2011-10-05  0:45 ` [PATCH 4/4] ARM: OMAP: Map SRAM later on with ioremap_exec() Tony Lindgren
2011-10-05  0:45   ` Tony Lindgren
2011-10-05  1:07   ` Nicolas Pitre
2011-10-05  1:07     ` Nicolas Pitre
2011-10-05 22:13     ` Tony Lindgren
2011-10-05 22:13       ` Tony Lindgren
2011-10-05 23:01       ` Nicolas Pitre
2011-10-05 23:01         ` Nicolas Pitre
2011-10-07  6:52       ` Santosh Shilimkar
2011-10-07  6:52         ` Santosh Shilimkar
2011-10-07 14:55         ` Tony Lindgren
2011-10-07 14:55           ` Tony Lindgren
2011-10-05  1:40 ` [PATCH 5/4] ARM: OMAP: Move set_globals initialization to happen in init_early Tony Lindgren
2011-10-05  1:40   ` Tony Lindgren
2011-10-05  1:51   ` Nicolas Pitre
2011-10-05  1:51     ` Nicolas Pitre
2011-10-06  1:36     ` Tony Lindgren
2011-10-06  1:36       ` Tony Lindgren
2011-10-07  6:56       ` Santosh Shilimkar
2011-10-07  6:56         ` Santosh Shilimkar
2011-10-07 14:54         ` Tony Lindgren
2011-10-07 14:54           ` Tony Lindgren
2011-10-07 23:26           ` Nicolas Pitre
2011-10-07 23:26             ` Nicolas Pitre
2011-10-05  7:03 ` [PATCH 0/4] initialize omap SRAM later on with __arm_ioremap_exec() Santosh Shilimkar
2011-10-05  7:03   ` Santosh Shilimkar
2011-10-06  1:42   ` Tony Lindgren
2011-10-06  1:42     ` Tony Lindgren
2011-10-07  6:59     ` Santosh Shilimkar
2011-10-07  6:59       ` Santosh Shilimkar
2011-10-07 14:45       ` Tony Lindgren
2011-10-07 14:45         ` Tony Lindgren
2011-10-07 20:23       ` Nicolas Pitre
2011-10-07 20:23         ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8F42D4.7030502@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.