* enabling FIMC from default config
@ 2011-10-10 6:50 Subash Patel
2011-10-10 7:05 ` Subash Patel
0 siblings, 1 reply; 3+ messages in thread
From: Subash Patel @ 2011-10-10 6:50 UTC (permalink / raw)
To: Sylwester Nawrocki, linux-samsung-soc
Hi Sylwester,
In the file arch/arm/plat-s5p/Kconfig, why dont we change the below
config S5P_DEV_FIMC0/1/2/3
bool
help
Compile in platform device definitions for FIMC controller
0/1/2/3
as
config S5P_DEV_FIMC0/1/2/3
bool
depends on VIDEO_SAMSUNG_S5P_FIMC
default y
help
Compile in platform device definitions for FIMC controller
0/1/2/3
I find that every time I need to use FIMC, I need to make some
un-necessary hacks into Kconfig, even though I choose the menu item
"Samsung S5P and EXYNOS4 camera host interface driver"
Regards,
Subash
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: enabling FIMC from default config
2011-10-10 6:50 enabling FIMC from default config Subash Patel
@ 2011-10-10 7:05 ` Subash Patel
2011-10-10 10:16 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: Subash Patel @ 2011-10-10 7:05 UTC (permalink / raw)
To: Sylwester Nawrocki, linux-samsung-soc
I forgot to add:
instead of choosing them through config MACH_**** in
arch/arm/mach-exynos4/Kconfig
Regards,
Subash
On 10/10/2011 12:20 PM, Subash Patel wrote:
> Hi Sylwester,
>
> In the file arch/arm/plat-s5p/Kconfig, why dont we change the below
>
> config S5P_DEV_FIMC0/1/2/3
> bool
> help
> Compile in platform device definitions for FIMC controller 0/1/2/3
>
> as
>
> config S5P_DEV_FIMC0/1/2/3
> bool
> depends on VIDEO_SAMSUNG_S5P_FIMC
> default y
> help
> Compile in platform device definitions for FIMC controller 0/1/2/3
>
> I find that every time I need to use FIMC, I need to make some
> un-necessary hacks into Kconfig, even though I choose the menu item
> "Samsung S5P and EXYNOS4 camera host interface driver"
>
> Regards,
> Subash
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: enabling FIMC from default config
2011-10-10 7:05 ` Subash Patel
@ 2011-10-10 10:16 ` Sylwester Nawrocki
0 siblings, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2011-10-10 10:16 UTC (permalink / raw)
To: Subash Patel; +Cc: linux-samsung-soc
Hi Subash,
On 10/10/2011 09:05 AM, Subash Patel wrote:
> I forgot to add:
>
> instead of choosing them through config MACH_**** in arch/arm/mach-exynos4/Kconfig
>
> Regards,
> Subash
>
> On 10/10/2011 12:20 PM, Subash Patel wrote:
>> Hi Sylwester,
>>
>> In the file arch/arm/plat-s5p/Kconfig, why dont we change the below
>>
>> config S5P_DEV_FIMC0/1/2/3
>> bool
>> help
>> Compile in platform device definitions for FIMC controller 0/1/2/3
>>
>> as
>>
>> config S5P_DEV_FIMC0/1/2/3
>> bool
>> depends on VIDEO_SAMSUNG_S5P_FIMC
>> default y
>> help
>> Compile in platform device definitions for FIMC controller 0/1/2/3
>>
>> I find that every time I need to use FIMC, I need to make some
>> un-necessary hacks into Kconfig, even though I choose the menu item
>> "Samsung S5P and EXYNOS4 camera host interface driver"
I'm all for automating these things, although please note plat-s5p/Kconfig
is for all relevant mach-* and the number of available FIMC instances
is specific to each mach-*. E.g. s5pv210 has only 3 instances, while
on exynos4 there are 4. So each mach-* currently selects S5P_DEV_FIMC?.
I agree the current scheme might not be the most optimal.
I'm open to any suggestions on this.
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-10 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 6:50 enabling FIMC from default config Subash Patel
2011-10-10 7:05 ` Subash Patel
2011-10-10 10:16 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.