All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Dunn <mikedunn@newsguy.com>
To: Ivan Djelic <ivan.djelic@parrot.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
	"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] Add driver for M-sys / Sandisk diskonchip G4 nand flash
Date: Tue, 11 Oct 2011 12:17:22 -0700	[thread overview]
Message-ID: <4E949642.9020209@newsguy.com> (raw)
In-Reply-To: <20111011115034.GA28920@parrot.com>

Hi Ivan.

Thanks!  I really appreciate your time and help.

On 10/11/2011 04:50 AM, Ivan Djelic wrote:
>
> After a more careful examination, I believe your hardware gives you
> recv_ecc^calc_ecc

It might be a little more complicated.

>
> Note that you must provide ecc_flash bytes (read from oob) to this function.

What I think I've found is that the hw-generated ecc that is written to oob when
a page is written is not the ecc generated by your algorithm.  I compiled bch.c
in userspace and patched it to print the calculated ecc when decode_bch() is
called with the 520 data bytes and (bogus) received ecc.  It's not bit-reversed,
either.

> If you provide ecc_flash[] = {0xff,0xff,0xff,0xff,0xff,0xff,0xff,}, (this
> happens when you read a blank page) then the output is cf72fc1ba9c7b9, which is
> consistent with your blank_read_hwecc[] array.

Hey! Well, you're on to something!

> If the above code does not work, I may still find the right permutation
> performed by your hw generator on input data. For this I just need a few
> samples of hw generated bytes. For instance, hw generated ecc bytes for:

Data below...

> - a page (520 bytes) filled with 0x00, except the first byte set to 0x01

d4 78 99 c2 7e 7c 7f

> - a page (520 bytes) filled with 0xff, except the first byte set to 0x55

70 f3 63 ce 4b 96 9a

Thanks again!
Mike

  reply	other threads:[~2011-10-11 19:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 14:48 [PATCH] Add driver for M-sys / Sandisk diskonchip G4 nand flash Mike Dunn
2011-10-10 15:51 ` Marek Vasut
2011-10-10 18:12   ` Ivan Djelic
2011-10-10 21:02     ` Mike Dunn
2011-10-11 11:50       ` Ivan Djelic
2011-10-11 19:17         ` Mike Dunn [this message]
2011-10-12 18:49           ` Ivan Djelic
2011-10-13  1:18             ` Mike Dunn
2011-10-13  6:58             ` Robert Jarzmik
2011-10-13  8:37               ` Ivan Djelic
2011-10-13 15:52                 ` Mike Dunn
2011-10-10 20:20   ` Mike Dunn
2011-10-12 21:28 ` Robert Jarzmik
2011-10-13  0:26   ` Marek Vasut
2011-10-13  2:25     ` Mike Dunn
2011-10-13  1:53   ` Mike Dunn
2011-10-17 21:45   ` Mike Dunn
2011-10-20 16:31     ` Artem Bityutskiy
2011-10-20 19:57       ` Mike Dunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E949642.9020209@newsguy.com \
    --to=mikedunn@newsguy.com \
    --cc=ivan.djelic@parrot.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.