Re: [PATCH] Add driver for M-sys / Sandisk diskonchip G4 nand flash

[Mike Dunn <mikedunn@newsguy.com>]

On 10/12/2011 02:28 PM, Robert Jarzmik wrote:
>
> Hi Mike,
>
> I had a look at your driver, to see how close it was to the docg3 I submitted
> before and if we could share some code.

Sent you an email earlier off the ML  I made many of the sme poiints.  We're in
agreement.  The devices are too dissimilar in operation.  Just some shared
registers.


> And I think the BCH algorithm is the same

Of this I'm sure.

> and I'm really
> interested in the outcome of your work with Ivan.

He just showed me how to avoid the need for any bch calculations altogether,
relying entirely on his in-kernel algorithm.  It's been tested.

> Therefore, I'll help review your driver as much as I can, so that you can merge
> it in mainline.

I appreciate that!

I'll parse your review in its entirety once I'm done with the cleanup of the ecc
handling.  Thanks for taking the time to go through the code.  I also want to go
through your G3 driver code in more detal.  I think we may have a lot of notes
to compare.  And I'm anxious to resume looking through my P3 test code and notes
from 18 months ago.  I should have some good info for you.  The G3 might just be
a P3 with double the capacity.  I already see that the addressing is the same.

Thanks,
Mike