From: Thomas Hellstrom <thellstrom@vmware.com>
To: j.glisse@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: ttm: merge ttm_backend & ttm_tt, introduce ttm dma allocator
Date: Wed, 09 Nov 2011 21:25:20 +0100 [thread overview]
Message-ID: <4EBAE1B0.9090305@vmware.com> (raw)
In-Reply-To: <1320870150-23151-1-git-send-email-j.glisse@gmail.com>
On 11/09/2011 09:22 PM, j.glisse@gmail.com wrote:
> So i did an overhaul of ttm_memory, i believe the simplification i did
> make sense. See patch 5 for a longer explanation.
>
>
> Thomas with the ttm_memory change the allocation of pages won't happen
> if the accounting report that we are going over the limit and bo shrinker
> failed to free any memory to make room.
>
> The handling of dma32 zone is done as post pass of ttm memory accounting.
>
OK. I'll take a deeper look into this.
> Regarding the pagefault comment i removed, it doesn't make sense anymore
> because now we populate the whole page table in one shot. So there is
> no more prefaulting few pages but a full prefaulting. Thought i can
> add a comment stating that if you like.
>
It's important that we distinguish between populating, which populates
pages,
and faulting, which add ptes pointing to those pages.
Previously populating happened as a side effect of faulting, but now
that populating is done
in a single step, faulting (adding ptes) is still not. Usually a fault()
handler adds a single pte,
but TTM is different and tries to prefault more, but it is important
that we only error on the first
pte, so that's why the comment should stay.
> For the ttm_tt_dma struct to hold page allocator specific informations
> i think it can be done as an followup patch but if you prefer to have
> that in this patchset let me know i will respin with such changes.
>
>
I'm fine with having it as a separate patchset as long as it gets done :).
> I am in the process of retesting this whole serie and especialy the
> while memory accounting.
>
> Cheers,
> Jerome
>
/Thomas
next prev parent reply other threads:[~2011-11-09 20:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 20:22 ttm: merge ttm_backend & ttm_tt, introduce ttm dma allocator j.glisse
2011-11-09 20:22 ` [PATCH 01/13] drm/ttm: remove userspace backed ttm object support j.glisse
2011-11-09 20:22 ` [PATCH 02/13] drm/ttm: remove split btw highmen and lowmem page j.glisse
2011-11-09 20:22 ` [PATCH 03/13] drm/ttm: remove unused backend flags field j.glisse
2011-11-09 20:22 ` [PATCH 04/13] drm/ttm: use ttm put pages function to properly restore cache attribute j.glisse
2011-11-09 20:22 ` [PATCH 05/13] drm/ttm: overhaul memory accounting j.glisse
2011-11-10 10:27 ` Thomas Hellstrom
2011-11-10 18:05 ` Jerome Glisse
2011-11-10 20:05 ` Thomas Hellstrom
2011-11-10 23:33 ` Jerome Glisse
2011-11-11 7:49 ` Thomas Hellstrom
2011-11-11 8:47 ` Dave Airlie
2011-11-11 9:08 ` Thomas Hellstrom
2011-11-11 15:47 ` Jerome Glisse
2011-11-11 16:22 ` Thomas Hellstrom
2011-11-11 17:15 ` Jerome Glisse
2011-11-09 20:22 ` [PATCH 06/13] drm/ttm: convert page allocation to use page ptr array instead of list V4 j.glisse
2011-11-09 20:22 ` [PATCH 07/13] drm/ttm: test for dma_address array allocation failure j.glisse
2011-11-09 20:22 ` [PATCH 08/13] drm/ttm: merge ttm_backend and ttm_tt V2 j.glisse
2011-11-09 20:22 ` [PATCH 09/13] drm/ttm: introduce callback for ttm_tt populate & unpopulate V2 j.glisse
2011-11-09 20:22 ` [PATCH 10/13] ttm: Provide DMA aware TTM page pool code. V5 j.glisse
2011-11-09 20:22 ` [PATCH 11/13] swiotlb: Expose swiotlb_nr_tlb function to modules j.glisse
2011-11-09 20:22 ` [PATCH 12/13] drm/radeon/kms: Enable the TTM DMA pool if swiotlb is on V2 j.glisse
2011-11-09 20:22 ` [PATCH 13/13] drm/nouveau: enable the TTM DMA pool on 32-bit DMA only device V2 j.glisse
2011-11-09 20:25 ` Thomas Hellstrom [this message]
2011-11-09 21:03 ` ttm: merge ttm_backend & ttm_tt, introduce ttm dma allocator Jerome Glisse
-- strict thread matches above, loose matches on Subject: below --
2011-11-03 23:39 j.glisse
2011-11-07 17:50 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBAE1B0.9090305@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.glisse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.