From: Thomas Hellstrom <thellstrom@vmware.com>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/13] drm/ttm: overhaul memory accounting
Date: Fri, 11 Nov 2011 10:08:00 +0100 [thread overview]
Message-ID: <4EBCE5F0.9070302@vmware.com> (raw)
In-Reply-To: <CAPM=9txgPmw7Z5+Xcj3AZ5ZjEz10pd2NM2MQEvRRKOppkbByqQ@mail.gmail.com>
On 11/11/2011 09:47 AM, Dave Airlie wrote:
>> What are the symptoms of the failure you're seeing with Radeon? Any
>> suggestions on why it happens?
>>
> I suspect radeon swapping might have some issues, I really think we
> should put the effort into a test suite like the intel-gpu-tools,
> instead of moving code around with no idea what is better or worse.
> (Jerome you can take this as a strong hint to work on some tests :-)
>
> Dave.
>
I think many tests like this can be written using OpenGL (using some
assumptions about where drivers store things like texture images etc.
That could be useful for all drivers).
But for the specific radeon bo case, I had a quick look at the code:
1) Gem stuff is not accounted anywhere AFAICT. Gem idr memory? flink memory?
2) Radeon fences doesn't seem to be accounted anywhere.
3) Radeon bo accounting is completely incorrect. The accounting size
given to ttm_bo_init() should be the size of the kmalloc'ed object,
including size of page arrays and dma_addr arrays and gem stuff, but not
the pages themselves. kmalloced memory sizes should also be rounded up
to the nearest power of two to account for allocator granularity.
Before this is fixed, we shouldn't IMHO really blame TTM and try to
rewrite it.
/Thomas
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
next prev parent reply other threads:[~2011-11-11 9:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 20:22 ttm: merge ttm_backend & ttm_tt, introduce ttm dma allocator j.glisse
2011-11-09 20:22 ` [PATCH 01/13] drm/ttm: remove userspace backed ttm object support j.glisse
2011-11-09 20:22 ` [PATCH 02/13] drm/ttm: remove split btw highmen and lowmem page j.glisse
2011-11-09 20:22 ` [PATCH 03/13] drm/ttm: remove unused backend flags field j.glisse
2011-11-09 20:22 ` [PATCH 04/13] drm/ttm: use ttm put pages function to properly restore cache attribute j.glisse
2011-11-09 20:22 ` [PATCH 05/13] drm/ttm: overhaul memory accounting j.glisse
2011-11-10 10:27 ` Thomas Hellstrom
2011-11-10 18:05 ` Jerome Glisse
2011-11-10 20:05 ` Thomas Hellstrom
2011-11-10 23:33 ` Jerome Glisse
2011-11-11 7:49 ` Thomas Hellstrom
2011-11-11 8:47 ` Dave Airlie
2011-11-11 9:08 ` Thomas Hellstrom [this message]
2011-11-11 15:47 ` Jerome Glisse
2011-11-11 16:22 ` Thomas Hellstrom
2011-11-11 17:15 ` Jerome Glisse
2011-11-09 20:22 ` [PATCH 06/13] drm/ttm: convert page allocation to use page ptr array instead of list V4 j.glisse
2011-11-09 20:22 ` [PATCH 07/13] drm/ttm: test for dma_address array allocation failure j.glisse
2011-11-09 20:22 ` [PATCH 08/13] drm/ttm: merge ttm_backend and ttm_tt V2 j.glisse
2011-11-09 20:22 ` [PATCH 09/13] drm/ttm: introduce callback for ttm_tt populate & unpopulate V2 j.glisse
2011-11-09 20:22 ` [PATCH 10/13] ttm: Provide DMA aware TTM page pool code. V5 j.glisse
2011-11-09 20:22 ` [PATCH 11/13] swiotlb: Expose swiotlb_nr_tlb function to modules j.glisse
2011-11-09 20:22 ` [PATCH 12/13] drm/radeon/kms: Enable the TTM DMA pool if swiotlb is on V2 j.glisse
2011-11-09 20:22 ` [PATCH 13/13] drm/nouveau: enable the TTM DMA pool on 32-bit DMA only device V2 j.glisse
2011-11-09 20:25 ` ttm: merge ttm_backend & ttm_tt, introduce ttm dma allocator Thomas Hellstrom
2011-11-09 21:03 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBCE5F0.9070302@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.