From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] i.mx: i.mx5: Move some files to imx-common folder
Date: Mon, 14 Nov 2011 12:28:11 +0100 [thread overview]
Message-ID: <4EC0FB4B.2040003@denx.de> (raw)
In-Reply-To: <CAFQ4atT_M=ywqE7=iYoxdRnsKQ4uGktfwmVzKAfLGMXgf0mvmA@mail.gmail.com>
On 11/14/2011 09:57 AM, Jason Hui wrote:
>
> Yes, agree. what about cpu.c? if you dislike, could you do me a favor
> to name it. :)
Agree - let's change it into cpu.c !
>>
>> You mix here two things - you move the files and you change it adding
>> new features. Split into two patches.
>
> In fact, I did not do any function change. I just do the followings two changes:
>
> - fix the checkpatch warnings with the original timer.c file in mx5 folder.
> - change the CONFIG_SYS_MX5_CLK32 to CLK_32KHZ
>
> I can add the changes to the commit message. Do I still need split
> into two patches?
No, you have better explained what you did - it is ok for me if you
extend the commit message.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-11-14 11:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 10:36 [U-Boot] [PATCH 0/6] i.mx: add the initial i.mx6q core/board support Jason Liu
2011-11-12 10:36 ` [U-Boot] [PATCH 1/6] i.mx: i.mx5: Move some files to imx-common folder Jason Liu
2011-11-14 8:34 ` Stefano Babic
2011-11-14 8:57 ` Jason Hui
2011-11-14 11:28 ` Stefano Babic [this message]
2011-11-12 10:36 ` [U-Boot] [PATCH 2/6] i.mx: Add the initial support for freescale i.MX6Q processor Jason Liu
2011-11-13 23:11 ` Marek Vasut
2011-11-14 8:47 ` Jason Hui
2011-11-14 10:45 ` Marek Vasut
2011-11-15 10:10 ` Jason Hui
2011-11-15 11:08 ` Stefano Babic
2011-11-14 9:03 ` Stefano Babic
2011-11-14 9:42 ` Jason Hui
2011-11-14 11:49 ` Stefano Babic
2011-11-15 10:18 ` Jason Hui
2011-11-12 10:36 ` [U-Boot] [PATCH 3/6] i.mx: mxc_gpio: add the i.mx6q support Jason Liu
2011-11-14 9:04 ` Stefano Babic
2011-11-12 10:36 ` [U-Boot] [PATCH 4/6] i.mx: serial_mxc: " Jason Liu
2011-11-12 10:36 ` [U-Boot] [PATCH 5/6] i.mx: fsl_esdhc: " Jason Liu
2011-11-12 16:35 ` Marek Vasut
2011-11-14 8:37 ` Jason Hui
2011-11-14 10:42 ` Marek Vasut
2011-11-15 9:46 ` Jason Hui
2011-11-15 11:56 ` Stefano Babic
2011-11-16 1:36 ` Jason Hui
2011-11-16 2:24 ` Marek Vasut
2011-11-14 9:06 ` Stefano Babic
2011-11-12 10:36 ` [U-Boot] [PATCH 6/6] i.mx: i.mx6q: Add the initial support for i.mx6q ARM2 board Jason Liu
2011-11-12 19:42 ` Fabio Estevam
2011-11-14 8:59 ` Jason Hui
2011-11-12 20:13 ` Fabio Estevam
2011-11-14 9:10 ` Jason Hui
2011-11-13 7:04 ` Igor Grinberg
2011-11-14 9:13 ` Jason Hui
2011-11-14 9:25 ` Stefano Babic
2011-11-14 9:55 ` Jason Hui
2011-11-14 11:36 ` Stefano Babic
2011-11-16 11:34 ` Dirk Behme
2011-11-16 12:15 ` Jason Hui
2011-11-12 16:10 ` [U-Boot] [PATCH 0/6] i.mx: add the initial i.mx6q core/board support Dirk Behme
2011-11-14 8:11 ` Jason Hui
2011-11-16 11:56 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC0FB4B.2040003@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.