From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Patrice Vilchez <patrice.vilchez@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver.
Date: Tue, 15 Nov 2011 11:23:50 +0100 [thread overview]
Message-ID: <4EC23DB6.1040503@free-electrons.com> (raw)
In-Reply-To: <4EC188D2.5080706@kernel.org>
On 14/11/2011 22:32, Jonathan Cameron wrote:
> Just one more query on the IIO_CHAN_INFO_SCALE read.
> Sorry, missed this last time. Its late so I may be going
> mad but the units seem out by 1000.
Wow, you're right. Indeed, if you multiply the value returned by
read_raw and scale, you get a value in millivolts, not micro...
> Also mysterious short as return value type in read_raw.
I will resend a new patchset with these two fixes.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver.
Date: Tue, 15 Nov 2011 11:23:50 +0100 [thread overview]
Message-ID: <4EC23DB6.1040503@free-electrons.com> (raw)
In-Reply-To: <4EC188D2.5080706@kernel.org>
On 14/11/2011 22:32, Jonathan Cameron wrote:
> Just one more query on the IIO_CHAN_INFO_SCALE read.
> Sorry, missed this last time. Its late so I may be going
> mad but the units seem out by 1000.
Wow, you're right. Indeed, if you multiply the value returned by
read_raw and scale, you get a value in millivolts, not micro...
> Also mysterious short as return value type in read_raw.
I will resend a new patchset with these two fixes.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-11-15 10:23 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 17:30 [PATCH v6] AT91: Add a driver for the ADC Maxime Ripard
2011-11-14 17:30 ` Maxime Ripard
2011-11-14 17:30 ` [PATCH 1/3] ARM: AT91: Add platform data for the ADCs Maxime Ripard
2011-11-14 17:30 ` Maxime Ripard
2011-11-14 17:30 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-14 17:30 ` Maxime Ripard
2011-11-14 21:32 ` Jonathan Cameron
2011-11-14 21:32 ` Jonathan Cameron
2011-11-15 10:23 ` Maxime Ripard [this message]
2011-11-15 10:23 ` Maxime Ripard
2011-11-14 17:30 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-14 17:30 ` Maxime Ripard
2011-11-14 20:34 ` Jonathan Cameron
2011-11-14 20:34 ` Jonathan Cameron
2011-11-15 10:27 ` Maxime Ripard
2011-11-15 10:27 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2012-01-16 21:36 [PATCH RESEND v13] AT91: Add a driver for the ADC Maxime Ripard
2012-01-16 21:36 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2012-01-16 21:36 ` Maxime Ripard
2012-01-17 17:35 ` Arnd Bergmann
2012-01-17 17:35 ` Arnd Bergmann
2012-01-17 19:08 ` Maxime Ripard
2012-01-17 19:08 ` Maxime Ripard
2012-01-18 10:27 ` Nicolas Ferre
2012-01-18 10:27 ` Nicolas Ferre
2011-12-14 10:01 [PATCH v13] AT91: Add a driver for the ADC Maxime Ripard
2011-12-14 10:01 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-12-02 13:17 [PATCH v12] AT91: Add a driver for the ADC Maxime Ripard
2011-12-02 13:17 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-12-02 13:17 ` Maxime Ripard
2011-11-30 9:14 [PATCH v11] AT91: Add a driver for the ADC Maxime Ripard
2011-11-30 9:15 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-30 9:15 ` Maxime Ripard
2011-11-30 17:40 ` Arnd Bergmann
2011-11-30 17:40 ` Arnd Bergmann
2011-11-24 11:27 [PATCH v9] AT91: Add a driver for the ADC Maxime Ripard
2011-11-24 11:27 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-24 11:27 ` Maxime Ripard
2011-11-24 14:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 14:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-18 10:12 [PATCH v8] AT91: Add a driver for the ADC Maxime Ripard
2011-11-18 10:12 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-18 10:12 ` Maxime Ripard
2011-11-15 10:54 [PATCH v7] AT91: Add a driver for the ADC Maxime Ripard
2011-11-15 10:54 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-15 10:54 ` Maxime Ripard
2011-11-16 15:39 ` Maxime Ripard
2011-11-16 15:39 ` Maxime Ripard
2011-11-14 10:06 [PATCHv5] AT91: Add a driver for the ADC Maxime Ripard
2011-11-14 10:06 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-14 10:06 ` Maxime Ripard
2011-11-14 11:30 ` Nicolas Ferre
2011-11-14 11:30 ` Nicolas Ferre
2011-11-14 11:37 ` Marek Vasut
2011-11-14 11:37 ` Marek Vasut
2011-11-14 14:23 ` Maxime Ripard
2011-11-14 14:23 ` Maxime Ripard
2011-10-19 16:18 [PATCH] AT91: Add a driver for the ADC Maxime Ripard
2011-10-19 16:18 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-10-19 16:18 ` Maxime Ripard
2011-10-19 16:42 ` Jonathan Cameron
2011-10-19 16:42 ` Jonathan Cameron
2011-10-19 18:23 ` Maxime Ripard
2011-10-19 18:23 ` Maxime Ripard
2011-10-20 7:05 ` Thomas Petazzoni
2011-10-20 7:05 ` Thomas Petazzoni
2011-10-20 8:33 ` Jonathan Cameron
2011-10-20 8:33 ` Jonathan Cameron
2011-10-20 8:49 ` Thomas Petazzoni
2011-10-20 8:49 ` Thomas Petazzoni
2011-10-20 9:19 ` Jonathan Cameron
2011-10-20 9:19 ` Jonathan Cameron
2011-10-20 9:52 ` Mark Brown
2011-10-20 9:52 ` Mark Brown
2011-10-20 7:09 ` Lars-Peter Clausen
2011-10-20 7:09 ` Lars-Peter Clausen
2011-10-21 17:54 ` Maxime Ripard
2011-10-21 17:54 ` Maxime Ripard
2011-10-21 17:55 ` Lars-Peter Clausen
2011-10-21 17:55 ` Lars-Peter Clausen
2011-10-23 9:08 ` Jean-Christophe PLAGNIOL-VILLARD
2011-10-23 9:08 ` Jean-Christophe PLAGNIOL-VILLARD
2011-10-24 8:21 ` Maxime Ripard
2011-10-24 8:21 ` Maxime Ripard
2011-11-03 10:11 ` [PATCHv2] AT91: Add a driver for the ADC Maxime Ripard
2011-11-03 10:11 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-03 10:11 ` Maxime Ripard
2011-11-04 10:27 ` Jonathan Cameron
2011-11-04 10:27 ` Jonathan Cameron
2011-11-04 16:29 ` Maxime Ripard
2011-11-04 16:40 ` Jonathan Cameron
2011-11-07 16:08 ` [PATCHv3] AT91: Add a driver for the ADC Maxime Ripard
2011-11-07 16:08 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-07 16:08 ` Maxime Ripard
2011-11-08 13:30 ` Thomas Petazzoni
2011-11-08 13:30 ` Thomas Petazzoni
2011-11-09 10:19 ` [PATCHv4] AT91: Add a driver for the ADC Maxime Ripard
2011-11-09 10:19 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-09 10:19 ` Maxime Ripard
2011-11-10 17:35 ` Jonathan Cameron
2011-11-10 17:35 ` Jonathan Cameron
2011-11-11 12:34 ` Jonathan Cameron
2011-11-11 12:34 ` Jonathan Cameron
2011-11-14 9:59 ` Maxime Ripard
2011-11-14 9:59 ` Maxime Ripard
2011-11-14 9:06 ` Maxime Ripard
2011-11-14 9:06 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC23DB6.1040503@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.