All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259
Date: Mon, 05 Dec 2011 14:29:09 +0100	[thread overview]
Message-ID: <4EDCC725.7090808@siemens.com> (raw)
In-Reply-To: <4EDCC3B8.9020203@redhat.com>

On 2011-12-05 14:14, Avi Kivity wrote:
> On 12/05/2011 02:47 PM, Jan Kiszka wrote:
>>>
>>> (the memory API added unstable names, hopefully the QOM can take over
>>> the stable ones and we'll have a good way to denote the unstable ones).
>>>
>>
>> OK, maybe - or likely - we should make those device models have the same
>> names in QOM once instantiated. But I'm still convinced they should
>> remain separated models in contrast to a single model with a property.
> 
> What do you mean by separate models?  You share all the code you can,
> and don't share the code you can't.  To me, single model == single name.

But different configuration.

> 
>> The kvm ioapic, e.g., requires an additional property (gsi_base) that is
>> meaningless for user space devices. And its interrupts have to be
>> wired&configured differently at board model level. So, from the QEMU
>> POV, it is a very different device. Just the guest does not notice.
> 
> It's like qcow2 and raw/native IO are wire differently, or virtio-net
> and vhost-net.  But it's the same IDE device or virtio NIC.

That would mean introducing a backend/frontend concept for irqchips.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259
Date: Mon, 05 Dec 2011 14:29:09 +0100	[thread overview]
Message-ID: <4EDCC725.7090808@siemens.com> (raw)
In-Reply-To: <4EDCC3B8.9020203@redhat.com>

On 2011-12-05 14:14, Avi Kivity wrote:
> On 12/05/2011 02:47 PM, Jan Kiszka wrote:
>>>
>>> (the memory API added unstable names, hopefully the QOM can take over
>>> the stable ones and we'll have a good way to denote the unstable ones).
>>>
>>
>> OK, maybe - or likely - we should make those device models have the same
>> names in QOM once instantiated. But I'm still convinced they should
>> remain separated models in contrast to a single model with a property.
> 
> What do you mean by separate models?  You share all the code you can,
> and don't share the code you can't.  To me, single model == single name.

But different configuration.

> 
>> The kvm ioapic, e.g., requires an additional property (gsi_base) that is
>> meaningless for user space devices. And its interrupts have to be
>> wired&configured differently at board model level. So, from the QEMU
>> POV, it is a very different device. Just the guest does not notice.
> 
> It's like qcow2 and raw/native IO are wire differently, or virtio-net
> and vhost-net.  But it's the same IDE device or virtio NIC.

That would mean introducing a backend/frontend concept for irqchips.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-12-05 13:29 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03 11:17 [RFC][PATCH 00/16] uq/master: Introduce basic irqchip support Jan Kiszka
2011-12-03 11:17 ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 10:42   ` Michael S. Tsirkin
2011-12-04 10:42     ` [Qemu-devel] " Michael S. Tsirkin
2011-12-04 10:42     ` Jan Kiszka
2011-12-04 10:42       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:12   ` Avi Kivity
2011-12-04 13:12     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:16     ` Jan Kiszka
2011-12-04 13:16       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:26       ` Avi Kivity
2011-12-04 13:26         ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 19:00   ` Andreas Färber
2011-12-03 19:00     ` Andreas Färber
2011-12-03 22:33     ` Jan Kiszka
2011-12-03 22:33       ` [Qemu-devel] " Jan Kiszka
2011-12-04 10:43       ` Avi Kivity
2011-12-04 10:43         ` Avi Kivity
2011-12-04 10:46         ` Jan Kiszka
2011-12-04 10:46           ` Jan Kiszka
2011-12-05 10:43       ` Andreas Färber
2011-12-03 11:17 ` [RFC][PATCH 03/16] apic: Stop timer on reset Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 04/16] apic: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 05/16] apic: Open-code timer save/restore Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 06/16] i8259: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 07/16] ioapic: Convert to memory API Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 08/16] ioapic: Reject non-dword accesses to IOWIN register Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 09/16] ioapic: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:20   ` Avi Kivity
2011-12-04 13:20     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:24     ` Jan Kiszka
2011-12-04 13:24       ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 11/16] kvm: Introduce core services for in-kernel irqchip support Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:23   ` Avi Kivity
2011-12-04 13:23     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:27     ` Jan Kiszka
2011-12-04 13:27       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:28       ` Avi Kivity
2011-12-04 13:28         ` [Qemu-devel] " Avi Kivity
2011-12-04 13:30         ` Jan Kiszka
2011-12-04 13:30           ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:32           ` Avi Kivity
2011-12-04 13:32             ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 12/16] kvm: x86: Establish IRQ0 override control Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 13/16] kvm: x86: Add user space part for in-kernel APIC Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:24   ` Avi Kivity
2011-12-04 13:24     ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:31   ` Avi Kivity
2011-12-04 13:31     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:42     ` Jan Kiszka
2011-12-04 13:42       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:49       ` Avi Kivity
2011-12-04 13:49         ` [Qemu-devel] " Avi Kivity
2011-12-04 13:51         ` Jan Kiszka
2011-12-04 13:51           ` [Qemu-devel] " Jan Kiszka
2011-12-04 14:04           ` Avi Kivity
2011-12-04 14:04             ` [Qemu-devel] " Avi Kivity
2011-12-04 14:06             ` Jan Kiszka
2011-12-04 14:06               ` [Qemu-devel] " Jan Kiszka
2011-12-04 15:12               ` Avi Kivity
2011-12-04 15:12                 ` [Qemu-devel] " Avi Kivity
2011-12-04 15:19                 ` Jan Kiszka
2011-12-04 15:19                   ` [Qemu-devel] " Jan Kiszka
2011-12-04 16:35                   ` Avi Kivity
2011-12-04 16:35                     ` [Qemu-devel] " Avi Kivity
2011-12-04 21:31                     ` Blue Swirl
2011-12-04 21:31                       ` [Qemu-devel] " Blue Swirl
2011-12-04 21:38                       ` Jan Kiszka
2011-12-04 21:38                         ` [Qemu-devel] " Jan Kiszka
2011-12-05 10:01                         ` Avi Kivity
2011-12-05 10:01                           ` [Qemu-devel] " Avi Kivity
2011-12-05 11:37                           ` Jan Kiszka
2011-12-05 11:37                             ` [Qemu-devel] " Jan Kiszka
2011-12-05 12:36                             ` Avi Kivity
2011-12-05 12:36                               ` [Qemu-devel] " Avi Kivity
2011-12-05 12:47                               ` Jan Kiszka
2011-12-05 12:47                                 ` [Qemu-devel] " Jan Kiszka
2011-12-05 13:14                                 ` Avi Kivity
2011-12-05 13:14                                   ` [Qemu-devel] " Avi Kivity
2011-12-05 13:29                                   ` Jan Kiszka [this message]
2011-12-05 13:29                                     ` Jan Kiszka
2011-12-05 13:36                                     ` Avi Kivity
2011-12-05 13:36                                       ` [Qemu-devel] " Avi Kivity
2011-12-05 13:55                                       ` Jan Kiszka
2011-12-05 13:55                                         ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 15/16] kvm: x86: Add user space part for in-kernel IOAPIC Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 16/16] kvm: Arm in-kernel irqchip support Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCC725.7090808@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.