All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Blue Swirl" <blauwirbel@gmail.com>,
	"Anthony Liguori" <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder
Date: Sun, 04 Dec 2011 11:46:14 +0100	[thread overview]
Message-ID: <4EDB4F76.30604@web.de> (raw)
In-Reply-To: <4EDB4ED6.8030707@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

On 2011-12-04 11:43, Avi Kivity wrote:
> On 12/04/2011 12:33 AM, Jan Kiszka wrote:
>> Do we have a convention that every include in <> is considered system
>> header? Should probably be documented then (and code should be converted
>> gradually).
> 
> It's documented in "The C Programming Language", by K&R.

It's just a convention, nothing more. If you consider certain parts of
QEMU's API as system (e.g. the parts that may once make our modular
API), it makes some sense to use <> for. Right now this happens for some
parts of the hw API. But inconsistently.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Blue Swirl" <blauwirbel@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder
Date: Sun, 04 Dec 2011 11:46:14 +0100	[thread overview]
Message-ID: <4EDB4F76.30604@web.de> (raw)
In-Reply-To: <4EDB4ED6.8030707@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

On 2011-12-04 11:43, Avi Kivity wrote:
> On 12/04/2011 12:33 AM, Jan Kiszka wrote:
>> Do we have a convention that every include in <> is considered system
>> header? Should probably be documented then (and code should be converted
>> gradually).
> 
> It's documented in "The C Programming Language", by K&R.

It's just a convention, nothing more. If you consider certain parts of
QEMU's API as system (e.g. the parts that may once make our modular
API), it makes some sense to use <> for. Right now this happens for some
parts of the hw API. But inconsistently.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2011-12-04 10:46 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03 11:17 [RFC][PATCH 00/16] uq/master: Introduce basic irqchip support Jan Kiszka
2011-12-03 11:17 ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 01/16] msi: Generalize msix_supported to msi_supported Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 10:42   ` Michael S. Tsirkin
2011-12-04 10:42     ` [Qemu-devel] " Michael S. Tsirkin
2011-12-04 10:42     ` Jan Kiszka
2011-12-04 10:42       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:12   ` Avi Kivity
2011-12-04 13:12     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:16     ` Jan Kiszka
2011-12-04 13:16       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:26       ` Avi Kivity
2011-12-04 13:26         ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 19:00   ` Andreas Färber
2011-12-03 19:00     ` Andreas Färber
2011-12-03 22:33     ` Jan Kiszka
2011-12-03 22:33       ` [Qemu-devel] " Jan Kiszka
2011-12-04 10:43       ` Avi Kivity
2011-12-04 10:43         ` Avi Kivity
2011-12-04 10:46         ` Jan Kiszka [this message]
2011-12-04 10:46           ` Jan Kiszka
2011-12-05 10:43       ` Andreas Färber
2011-12-03 11:17 ` [RFC][PATCH 03/16] apic: Stop timer on reset Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 04/16] apic: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 05/16] apic: Open-code timer save/restore Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 06/16] i8259: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 07/16] ioapic: Convert to memory API Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 08/16] ioapic: Reject non-dword accesses to IOWIN register Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 09/16] ioapic: Factor out core for KVM reuse Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 10/16] memory: Introduce memory_region_init_reservation Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:20   ` Avi Kivity
2011-12-04 13:20     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:24     ` Jan Kiszka
2011-12-04 13:24       ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 11/16] kvm: Introduce core services for in-kernel irqchip support Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:23   ` Avi Kivity
2011-12-04 13:23     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:27     ` Jan Kiszka
2011-12-04 13:27       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:28       ` Avi Kivity
2011-12-04 13:28         ` [Qemu-devel] " Avi Kivity
2011-12-04 13:30         ` Jan Kiszka
2011-12-04 13:30           ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:32           ` Avi Kivity
2011-12-04 13:32             ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 12/16] kvm: x86: Establish IRQ0 override control Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 13/16] kvm: x86: Add user space part for in-kernel APIC Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:24   ` Avi Kivity
2011-12-04 13:24     ` [Qemu-devel] " Avi Kivity
2011-12-03 11:17 ` [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:31   ` Avi Kivity
2011-12-04 13:31     ` [Qemu-devel] " Avi Kivity
2011-12-04 13:42     ` Jan Kiszka
2011-12-04 13:42       ` [Qemu-devel] " Jan Kiszka
2011-12-04 13:49       ` Avi Kivity
2011-12-04 13:49         ` [Qemu-devel] " Avi Kivity
2011-12-04 13:51         ` Jan Kiszka
2011-12-04 13:51           ` [Qemu-devel] " Jan Kiszka
2011-12-04 14:04           ` Avi Kivity
2011-12-04 14:04             ` [Qemu-devel] " Avi Kivity
2011-12-04 14:06             ` Jan Kiszka
2011-12-04 14:06               ` [Qemu-devel] " Jan Kiszka
2011-12-04 15:12               ` Avi Kivity
2011-12-04 15:12                 ` [Qemu-devel] " Avi Kivity
2011-12-04 15:19                 ` Jan Kiszka
2011-12-04 15:19                   ` [Qemu-devel] " Jan Kiszka
2011-12-04 16:35                   ` Avi Kivity
2011-12-04 16:35                     ` [Qemu-devel] " Avi Kivity
2011-12-04 21:31                     ` Blue Swirl
2011-12-04 21:31                       ` [Qemu-devel] " Blue Swirl
2011-12-04 21:38                       ` Jan Kiszka
2011-12-04 21:38                         ` [Qemu-devel] " Jan Kiszka
2011-12-05 10:01                         ` Avi Kivity
2011-12-05 10:01                           ` [Qemu-devel] " Avi Kivity
2011-12-05 11:37                           ` Jan Kiszka
2011-12-05 11:37                             ` [Qemu-devel] " Jan Kiszka
2011-12-05 12:36                             ` Avi Kivity
2011-12-05 12:36                               ` [Qemu-devel] " Avi Kivity
2011-12-05 12:47                               ` Jan Kiszka
2011-12-05 12:47                                 ` [Qemu-devel] " Jan Kiszka
2011-12-05 13:14                                 ` Avi Kivity
2011-12-05 13:14                                   ` [Qemu-devel] " Avi Kivity
2011-12-05 13:29                                   ` Jan Kiszka
2011-12-05 13:29                                     ` [Qemu-devel] " Jan Kiszka
2011-12-05 13:36                                     ` Avi Kivity
2011-12-05 13:36                                       ` [Qemu-devel] " Avi Kivity
2011-12-05 13:55                                       ` Jan Kiszka
2011-12-05 13:55                                         ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 15/16] kvm: x86: Add user space part for in-kernel IOAPIC Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka
2011-12-03 11:17 ` [RFC][PATCH 16/16] kvm: Arm in-kernel irqchip support Jan Kiszka
2011-12-03 11:17   ` [Qemu-devel] " Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDB4F76.30604@web.de \
    --to=jan.kiszka@web.de \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.