All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: len.brown@intel.com, linux-doc@vger.kernel.org,
	linux-pm@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, rjw@sisk.pl, rdunlap@xenotime.net,
	ebiederm@xmission.com, pavel@ucw.cz
Subject: Re: [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic
Date: Mon, 05 Dec 2011 22:55:51 +0530	[thread overview]
Message-ID: <4EDCFE9F.9050605@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111205171443.GB627@google.com>

On 12/05/2011 10:44 PM, Tejun Heo wrote:

> Hello,
> 
> On Mon, Dec 05, 2011 at 01:32:38AM +0530, Srivatsa S. Bhat wrote:
>> +static inline void lock_system_sleep(void)
>> +{
>> +	/* simplified freezer_do_not_count() */
>> +	current->flags |= PF_FREEZER_SKIP;
>> +	mutex_lock(&pm_mutex);
>> +}
>> +
>> +static inline void unlock_system_sleep(void)
>> +{
>> +	mutex_unlock(&pm_mutex);
>> +	/* simplified freezer_count() */
>> +	current->flags &= ~PF_FREEZER_SKIP;
>> +}
> 
> BTW, don't we want try_to_freeze() there?  What's the reason for not
> using freezer_count()?
> 


I wanted these APIs to be generic, not restricted to work only for userspace
processes. Both freezer_do_not_count() and freezer_count() are effective only
when current->mm is non-NULL (ie., only for userspace ones).
I think I have documented this in the patch which added these things to the
2 APIs. See commit 6a76b7a in linux-pm/linux-next.

As for try_to_freeze(), we can surely add that. I think I missed it while
open-coding the relevant part of freezer_count(). I'll send it as a separate
patch. Thank you very much.

Regards,
Srivatsa S. Bhat


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: rjw@sisk.pl, pavel@ucw.cz, len.brown@intel.com,
	ebiederm@xmission.com, rdunlap@xenotime.net,
	linux-doc@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic
Date: Mon, 05 Dec 2011 22:55:51 +0530	[thread overview]
Message-ID: <4EDCFE9F.9050605@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111205171443.GB627@google.com>

On 12/05/2011 10:44 PM, Tejun Heo wrote:

> Hello,
> 
> On Mon, Dec 05, 2011 at 01:32:38AM +0530, Srivatsa S. Bhat wrote:
>> +static inline void lock_system_sleep(void)
>> +{
>> +	/* simplified freezer_do_not_count() */
>> +	current->flags |= PF_FREEZER_SKIP;
>> +	mutex_lock(&pm_mutex);
>> +}
>> +
>> +static inline void unlock_system_sleep(void)
>> +{
>> +	mutex_unlock(&pm_mutex);
>> +	/* simplified freezer_count() */
>> +	current->flags &= ~PF_FREEZER_SKIP;
>> +}
> 
> BTW, don't we want try_to_freeze() there?  What's the reason for not
> using freezer_count()?
> 


I wanted these APIs to be generic, not restricted to work only for userspace
processes. Both freezer_do_not_count() and freezer_count() are effective only
when current->mm is non-NULL (ie., only for userspace ones).
I think I have documented this in the patch which added these things to the
2 APIs. See commit 6a76b7a in linux-pm/linux-next.

As for try_to_freeze(), we can surely add that. I think I missed it while
open-coding the relevant part of freezer_count(). I'll send it as a separate
patch. Thank you very much.

Regards,
Srivatsa S. Bhat


  reply	other threads:[~2011-12-05 17:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 20:02 [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic Srivatsa S. Bhat
2011-12-04 20:02 ` Srivatsa S. Bhat
2011-12-04 20:03 ` [PATCH 2/3] PM / Sleep: Replace mutex_[un]lock(&pm_mutex) with [un]lock_system_sleep() Srivatsa S. Bhat
2011-12-04 20:03   ` Srivatsa S. Bhat
2011-12-04 20:03 ` [PATCH 3/3] PM / Docs: Recommend the use of [un]lock_system_sleep() over mutex_[un]lock(&pm_mutex) Srivatsa S. Bhat
2011-12-04 20:03   ` Srivatsa S. Bhat
2011-12-05 17:15   ` Tejun Heo
2011-12-05 17:15     ` Tejun Heo
2011-12-05 17:38     ` Srivatsa S. Bhat
2011-12-05 17:38       ` Srivatsa S. Bhat
2011-12-05 17:43       ` Tejun Heo
2011-12-05 17:43         ` Tejun Heo
2011-12-05 17:56         ` Srivatsa S. Bhat
2011-12-05 17:56           ` Srivatsa S. Bhat
2011-12-05 17:59           ` Tejun Heo
2011-12-05 17:59             ` Tejun Heo
2011-12-05 17:14 ` [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic Tejun Heo
2011-12-05 17:14   ` Tejun Heo
2011-12-05 17:25   ` Srivatsa S. Bhat [this message]
2011-12-05 17:25     ` Srivatsa S. Bhat
2011-12-05 17:30     ` Tejun Heo
2011-12-05 17:30       ` Tejun Heo
2011-12-05 17:41       ` Srivatsa S. Bhat
2011-12-05 17:41         ` Srivatsa S. Bhat
2011-12-05 18:28         ` Srivatsa S. Bhat
2011-12-05 18:28           ` Srivatsa S. Bhat
2011-12-05 18:35           ` Oleg Nesterov
2011-12-05 18:35             ` Oleg Nesterov
2011-12-05 19:18             ` Srivatsa S. Bhat
2011-12-05 19:18               ` Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCFE9F.9050605@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@xenotime.net \
    --cc=rjw@sisk.pl \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.