All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: len.brown@intel.com, linux-doc@vger.kernel.org,
	linux-pm@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, rjw@sisk.pl, rdunlap@xenotime.net,
	ebiederm@xmission.com, pavel@ucw.cz, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic
Date: Tue, 06 Dec 2011 00:48:53 +0530	[thread overview]
Message-ID: <4EDD191D.2030409@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111205183502.GA30482@redhat.com>

Hi Oleg,

On 12/06/2011 12:05 AM, Oleg Nesterov wrote:

> On 12/05, Srivatsa S. Bhat wrote:
>>
>> I looked up in git and found that commit ba96a0c by Rafael introduced the
>> count functions, to handle the vfork case. But now, we seem to have more
>> uses than that. So I think we can remove that userspace restriction in the
>> count functions,
> 
> Agreed.
> 
>> and in kernel/fork.c, do something like:
>>
>> if (current->mm)
>> 	freezer_do_not_count();
>> ...
>> if (current->mm)
>> 	freezer_count();
> 
> see http://marc.info/?l=linux-kernel&m=132033335507261
> 
> I think this is not needed, we can just remove the ->mm check.
> CLONE_VFORK is not used by a freezable kthread.
> 


Great! Thanks for the pointer. I'll send a patch to remove that check.

Regards,
Srivatsa S. Bhat


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
	rjw@sisk.pl, pavel@ucw.cz, len.brown@intel.com,
	ebiederm@xmission.com, rdunlap@xenotime.net,
	linux-doc@vger.kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic
Date: Tue, 06 Dec 2011 00:48:53 +0530	[thread overview]
Message-ID: <4EDD191D.2030409@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111205183502.GA30482@redhat.com>

Hi Oleg,

On 12/06/2011 12:05 AM, Oleg Nesterov wrote:

> On 12/05, Srivatsa S. Bhat wrote:
>>
>> I looked up in git and found that commit ba96a0c by Rafael introduced the
>> count functions, to handle the vfork case. But now, we seem to have more
>> uses than that. So I think we can remove that userspace restriction in the
>> count functions,
> 
> Agreed.
> 
>> and in kernel/fork.c, do something like:
>>
>> if (current->mm)
>> 	freezer_do_not_count();
>> ...
>> if (current->mm)
>> 	freezer_count();
> 
> see http://marc.info/?l=linux-kernel&m=132033335507261
> 
> I think this is not needed, we can just remove the ->mm check.
> CLONE_VFORK is not used by a freezable kthread.
> 


Great! Thanks for the pointer. I'll send a patch to remove that check.

Regards,
Srivatsa S. Bhat


  reply	other threads:[~2011-12-05 19:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 20:02 [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic Srivatsa S. Bhat
2011-12-04 20:02 ` Srivatsa S. Bhat
2011-12-04 20:03 ` [PATCH 2/3] PM / Sleep: Replace mutex_[un]lock(&pm_mutex) with [un]lock_system_sleep() Srivatsa S. Bhat
2011-12-04 20:03   ` Srivatsa S. Bhat
2011-12-04 20:03 ` [PATCH 3/3] PM / Docs: Recommend the use of [un]lock_system_sleep() over mutex_[un]lock(&pm_mutex) Srivatsa S. Bhat
2011-12-04 20:03   ` Srivatsa S. Bhat
2011-12-05 17:15   ` Tejun Heo
2011-12-05 17:15     ` Tejun Heo
2011-12-05 17:38     ` Srivatsa S. Bhat
2011-12-05 17:38       ` Srivatsa S. Bhat
2011-12-05 17:43       ` Tejun Heo
2011-12-05 17:43         ` Tejun Heo
2011-12-05 17:56         ` Srivatsa S. Bhat
2011-12-05 17:56           ` Srivatsa S. Bhat
2011-12-05 17:59           ` Tejun Heo
2011-12-05 17:59             ` Tejun Heo
2011-12-05 17:14 ` [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic Tejun Heo
2011-12-05 17:14   ` Tejun Heo
2011-12-05 17:25   ` Srivatsa S. Bhat
2011-12-05 17:25     ` Srivatsa S. Bhat
2011-12-05 17:30     ` Tejun Heo
2011-12-05 17:30       ` Tejun Heo
2011-12-05 17:41       ` Srivatsa S. Bhat
2011-12-05 17:41         ` Srivatsa S. Bhat
2011-12-05 18:28         ` Srivatsa S. Bhat
2011-12-05 18:28           ` Srivatsa S. Bhat
2011-12-05 18:35           ` Oleg Nesterov
2011-12-05 18:35             ` Oleg Nesterov
2011-12-05 19:18             ` Srivatsa S. Bhat [this message]
2011-12-05 19:18               ` Srivatsa S. Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDD191D.2030409@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=len.brown@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@xenotime.net \
    --cc=rjw@sisk.pl \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.