[PATCHv2] omap: id: add chip id recognition for omap4430 es2.3

[PATCHv2] omap: id: add chip id recognition for omap4430 es2.3

[David Anders]

allow for the omap4430 es2.3 revision to be recognized in the
omap4_check_revision() function.

most aspects of all omap4430 es2.x versions are identical, however
a number of small variations such as default pullup or pulldown
resistor configurations vary between revisions.

detailed information on silicon errata for omap4430 revisions can
be found at http://focus.ti.com/pdfs/wtbu/swpz009D.pdf

Signed-off-by: David Anders <x0132446@ti.com>
---
 arch/arm/mach-omap2/id.c              |    7 +++++--
 arch/arm/plat-omap/include/plat/cpu.h |    1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index d27daf9..a0878e0 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -386,8 +386,11 @@ static void __init omap4_check_revision(void)
 			omap_revision = OMAP4430_REV_ES2_1;
 			break;
 		case 4:
-		default:
 			omap_revision = OMAP4430_REV_ES2_2;
+			break;
+		case 6:
+		default:
+			omap_revision = OMAP4430_REV_ES2_3;
 		}
 		break;
 	case 0xb94e:
@@ -400,7 +403,7 @@ static void __init omap4_check_revision(void)
 		break;
 	default:
 		/* Unknown default to latest silicon rev as default */
-		omap_revision = OMAP4430_REV_ES2_2;
+		omap_revision = OMAP4430_REV_ES2_3;
 	}
 
 	pr_info("OMAP%04x ES%d.%d\n", omap_rev() >> 16,
diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
index 649b370..a2fc6d3 100644
--- a/arch/arm/plat-omap/include/plat/cpu.h
+++ b/arch/arm/plat-omap/include/plat/cpu.h
@@ -416,6 +416,7 @@ IS_OMAP_TYPE(3517, 0x3517)
 #define OMAP4430_REV_ES2_0	(OMAP443X_CLASS | (0x20 << 8))
 #define OMAP4430_REV_ES2_1	(OMAP443X_CLASS | (0x21 << 8))
 #define OMAP4430_REV_ES2_2	(OMAP443X_CLASS | (0x22 << 8))
+#define OMAP4430_REV_ES2_3	(OMAP443X_CLASS | (0x23 << 8))
 
 #define OMAP446X_CLASS		0x44600044
 #define OMAP4460_REV_ES1_0	(OMAP446X_CLASS | (0x10 << 8))
-- 
1.7.0.4

Re: [PATCHv2] omap: id: add chip id recognition for omap4430 es2.3

[Tony Lindgren]

* David Anders <x0132446@ti.com> [111207 15:29]:
> allow for the omap4430 es2.3 revision to be recognized in the
> omap4_check_revision() function.
> 
> most aspects of all omap4430 es2.x versions are identical, however
> a number of small variations such as default pullup or pulldown
> resistor configurations vary between revisions.
> 
> detailed information on silicon errata for omap4430 revisions can
> be found at http://focus.ti.com/pdfs/wtbu/swpz009D.pdf

I have the earlier one already applied, this seems to be the
exact same patch, right?

Tony

Re: [PATCHv2] omap: id: add chip id recognition for omap4430 es2.3

[David Anders]

Tony,


On 12/07/2011 06:23 PM, Tony Lindgren wrote:
> * David Anders<x0132446@ti.com>  [111207 15:29]:
>    
>> allow for the omap4430 es2.3 revision to be recognized in the
>> omap4_check_revision() function.
>>
>> most aspects of all omap4430 es2.x versions are identical, however
>> a number of small variations such as default pullup or pulldown
>> resistor configurations vary between revisions.
>>
>> detailed information on silicon errata for omap4430 revisions can
>> be found at http://focus.ti.com/pdfs/wtbu/swpz009D.pdf
>>      
> I have the earlier one already applied, this seems to be the
> exact same patch, right?
>
>    

same core patch, with a break; added to the case 4.

if you would rather i can provide a one line fix patch

> Tony
>    

Dave

Re: [PATCHv2] omap: id: add chip id recognition for omap4430 es2.3

[Tony Lindgren]

* David Anders <x0132446@ti.com> [111207 15:54]:
> Tony,
> 
> 
> On 12/07/2011 06:23 PM, Tony Lindgren wrote:
> >* David Anders<x0132446@ti.com>  [111207 15:29]:
> >>allow for the omap4430 es2.3 revision to be recognized in the
> >>omap4_check_revision() function.
> >>
> >>most aspects of all omap4430 es2.x versions are identical, however
> >>a number of small variations such as default pullup or pulldown
> >>resistor configurations vary between revisions.
> >>
> >>detailed information on silicon errata for omap4430 revisions can
> >>be found at http://focus.ti.com/pdfs/wtbu/swpz009D.pdf
> >I have the earlier one already applied, this seems to be the
> >exact same patch, right?
> >
> 
> same core patch, with a break; added to the case 4.

Ah OK.
 
> if you would rather i can provide a one line fix patch

No need, have not pushed it out yet so I'll update it
before pushing out.

Tony