All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@parallels.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, lizf@cn.fujitsu.com,
	ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com,
	netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name,
	avagin@parallels.com, devel@openvz.org, eric.dumazet@gmail.com,
	cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@suse.cz
Subject: Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling.
Date: Fri, 9 Dec 2011 10:41:02 -0200	[thread overview]
Message-ID: <4EE201DE.9040102@parallels.com> (raw)
In-Reply-To: <20111209102438.2db705d0.kamezawa.hiroyu@jp.fujitsu.com>

On 12/08/2011 11:24 PM, KAMEZAWA Hiroyuki wrote:
> On Mon,  5 Dec 2011 19:34:56 -0200
> Glauber Costa<glommer@parallels.com>  wrote:
>
>> This patch replaces all uses of struct sock fields' memory_pressure,
>> memory_allocated, sockets_allocated, and sysctl_mem to acessor
>> macros. Those macros can either receive a socket argument, or a mem_cgroup
>> argument, depending on the context they live in.
>>
>> Since we're only doing a macro wrapping here, no performance impact at all is
>> expected in the case where we don't have cgroups disabled.
>>
>> Signed-off-by: Glauber Costa<glommer@parallels.com>
>> CC: David S. Miller<davem@davemloft.net>
>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp.fujitsu.com>
>> CC: Eric W. Biederman<ebiederm@xmission.com>
>> CC: Eric Dumazet<eric.dumazet@gmail.com>
>
> please get ack from network guys.
> from me.
> Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>
Ok.

I think that now with all the Reviewed-by:'s I will resend it as a 
Request for Inclusion for Dave (plus fixing the problem you noted in 
patch 1)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <lizf@cn.fujitsu.com>,
	<ebiederm@xmission.com>, <davem@davemloft.net>,
	<gthelen@google.com>, <netdev@vger.kernel.org>,
	<linux-mm@kvack.org>, <kirill@shutemov.name>,
	<avagin@parallels.com>, <devel@openvz.org>,
	<eric.dumazet@gmail.com>, <cgroups@vger.kernel.org>,
	<hannes@cmpxchg.org>, <mhocko@suse.cz>
Subject: Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling.
Date: Fri, 9 Dec 2011 10:41:02 -0200	[thread overview]
Message-ID: <4EE201DE.9040102@parallels.com> (raw)
In-Reply-To: <20111209102438.2db705d0.kamezawa.hiroyu@jp.fujitsu.com>

On 12/08/2011 11:24 PM, KAMEZAWA Hiroyuki wrote:
> On Mon,  5 Dec 2011 19:34:56 -0200
> Glauber Costa<glommer@parallels.com>  wrote:
>
>> This patch replaces all uses of struct sock fields' memory_pressure,
>> memory_allocated, sockets_allocated, and sysctl_mem to acessor
>> macros. Those macros can either receive a socket argument, or a mem_cgroup
>> argument, depending on the context they live in.
>>
>> Since we're only doing a macro wrapping here, no performance impact at all is
>> expected in the case where we don't have cgroups disabled.
>>
>> Signed-off-by: Glauber Costa<glommer@parallels.com>
>> CC: David S. Miller<davem@davemloft.net>
>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp.fujitsu.com>
>> CC: Eric W. Biederman<ebiederm@xmission.com>
>> CC: Eric Dumazet<eric.dumazet@gmail.com>
>
> please get ack from network guys.
> from me.
> Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>
Ok.

I think that now with all the Reviewed-by:'s I will resend it as a 
Request for Inclusion for Dave (plus fixing the problem you noted in 
patch 1)

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: <linux-kernel@vger.kernel.org>, <lizf@cn.fujitsu.com>,
	<ebiederm@xmission.com>, <davem@davemloft.net>,
	<gthelen@google.com>, <netdev@vger.kernel.org>,
	<linux-mm@kvack.org>, <kirill@shutemov.name>,
	<avagin@parallels.com>, <devel@openvz.org>,
	<eric.dumazet@gmail.com>, <cgroups@vger.kernel.org>,
	<hannes@cmpxchg.org>, <mhocko@suse.cz>
Subject: Re: [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling.
Date: Fri, 9 Dec 2011 10:41:02 -0200	[thread overview]
Message-ID: <4EE201DE.9040102@parallels.com> (raw)
In-Reply-To: <20111209102438.2db705d0.kamezawa.hiroyu@jp.fujitsu.com>

On 12/08/2011 11:24 PM, KAMEZAWA Hiroyuki wrote:
> On Mon,  5 Dec 2011 19:34:56 -0200
> Glauber Costa<glommer@parallels.com>  wrote:
>
>> This patch replaces all uses of struct sock fields' memory_pressure,
>> memory_allocated, sockets_allocated, and sysctl_mem to acessor
>> macros. Those macros can either receive a socket argument, or a mem_cgroup
>> argument, depending on the context they live in.
>>
>> Since we're only doing a macro wrapping here, no performance impact at all is
>> expected in the case where we don't have cgroups disabled.
>>
>> Signed-off-by: Glauber Costa<glommer@parallels.com>
>> CC: David S. Miller<davem@davemloft.net>
>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp.fujitsu.com>
>> CC: Eric W. Biederman<ebiederm@xmission.com>
>> CC: Eric Dumazet<eric.dumazet@gmail.com>
>
> please get ack from network guys.
> from me.
> Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>
Ok.

I think that now with all the Reviewed-by:'s I will resend it as a 
Request for Inclusion for Dave (plus fixing the problem you noted in 
patch 1)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-12-09 12:41 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 21:34 [PATCH v8 0/9] per-cgroup tcp memory pressure controls Glauber Costa
2011-12-05 21:34 ` Glauber Costa
2011-12-05 21:34 ` [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-12-05 21:34   ` Glauber Costa
2011-12-09  1:21   ` KAMEZAWA Hiroyuki
2011-12-09  1:21     ` KAMEZAWA Hiroyuki
     [not found]     ` <20111209102113.cdb85da8.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-09 12:40       ` Glauber Costa
2011-12-09 12:40         ` Glauber Costa
2011-12-09 12:40         ` Glauber Costa
2011-12-09 12:40         ` Glauber Costa
2011-12-09 14:37       ` Glauber Costa
2011-12-09 14:37         ` Glauber Costa
2011-12-09 14:37         ` Glauber Costa
2011-12-09 14:37         ` Glauber Costa
2011-12-09 14:44         ` David Laight
2011-12-09 14:44           ` David Laight
2011-12-09 14:44           ` David Laight
2011-12-09 14:48           ` Glauber Costa
2011-12-09 14:48             ` Glauber Costa
2011-12-09 14:48             ` Glauber Costa
2011-12-12  0:34         ` KAMEZAWA Hiroyuki
2011-12-12  0:34           ` KAMEZAWA Hiroyuki
2011-12-12  0:34           ` KAMEZAWA Hiroyuki
2011-12-05 21:34 ` [PATCH v8 2/9] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-12-05 21:34   ` Glauber Costa
     [not found]   ` <1323120903-2831-3-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-09  1:24     ` KAMEZAWA Hiroyuki
2011-12-09  1:24       ` KAMEZAWA Hiroyuki
2011-12-09  1:24       ` KAMEZAWA Hiroyuki
2011-12-09 12:41       ` Glauber Costa [this message]
2011-12-09 12:41         ` Glauber Costa
2011-12-09 12:41         ` Glauber Costa
2011-12-05 21:34 ` [PATCH v8 3/9] socket: initial cgroup code Glauber Costa
2011-12-05 21:34   ` Glauber Costa
     [not found]   ` <1323120903-2831-4-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-09  1:49     ` KAMEZAWA Hiroyuki
2011-12-09  1:49       ` KAMEZAWA Hiroyuki
2011-12-09  1:49       ` KAMEZAWA Hiroyuki
2011-12-09  2:05     ` KAMEZAWA Hiroyuki
2011-12-09  2:05       ` KAMEZAWA Hiroyuki
2011-12-09  2:05       ` KAMEZAWA Hiroyuki
2011-12-09 12:43       ` Glauber Costa
2011-12-09 12:43         ` Glauber Costa
2011-12-09 12:43         ` Glauber Costa
     [not found]         ` <4EE20254.6000308-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-12  0:33           ` KAMEZAWA Hiroyuki
2011-12-12  0:33             ` KAMEZAWA Hiroyuki
2011-12-12  0:33             ` KAMEZAWA Hiroyuki
2011-12-12  0:33             ` KAMEZAWA Hiroyuki
2011-12-05 21:34 ` [PATCH v8 4/9] tcp memory pressure controls Glauber Costa
2011-12-05 21:34   ` Glauber Costa
2011-12-09  1:51   ` KAMEZAWA Hiroyuki
2011-12-09  1:51     ` KAMEZAWA Hiroyuki
2011-12-05 21:34 ` [PATCH v8 5/9] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-12-05 21:34   ` Glauber Costa
     [not found]   ` <1323120903-2831-6-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-09  1:54     ` KAMEZAWA Hiroyuki
2011-12-09  1:54       ` KAMEZAWA Hiroyuki
2011-12-09  1:54       ` KAMEZAWA Hiroyuki
2011-12-05 21:35 ` [PATCH v8 6/9] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-12-05 21:35   ` Glauber Costa
2011-12-09  1:55   ` KAMEZAWA Hiroyuki
2011-12-09  1:55     ` KAMEZAWA Hiroyuki
2011-12-05 21:35 ` [PATCH v8 7/9] Display current tcp memory allocation in kmem cgroup Glauber Costa
2011-12-05 21:35   ` Glauber Costa
2011-12-09  1:56   ` KAMEZAWA Hiroyuki
2011-12-09  1:56     ` KAMEZAWA Hiroyuki
2011-12-05 21:35 ` [PATCH v8 8/9] Display current tcp failcnt " Glauber Costa
2011-12-05 21:35   ` Glauber Costa
2011-12-05 21:35 ` [PATCH v8 9/9] Display maximum tcp memory allocation " Glauber Costa
2011-12-05 21:35   ` Glauber Costa
     [not found]   ` <1323120903-2831-10-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-09  1:57     ` KAMEZAWA Hiroyuki
2011-12-09  1:57       ` KAMEZAWA Hiroyuki
2011-12-09  1:57       ` KAMEZAWA Hiroyuki
     [not found] ` <1323120903-2831-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2011-12-07 11:06   ` [PATCH v8 0/9] per-cgroup tcp memory pressure controls Glauber Costa
2011-12-07 11:06     ` Glauber Costa
2011-12-07 11:06     ` Glauber Costa
2011-12-07 11:06     ` Glauber Costa
2011-12-09  1:04     ` KAMEZAWA Hiroyuki
2011-12-09  1:04       ` KAMEZAWA Hiroyuki
2011-12-09  1:04       ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE201DE.9040102@parallels.com \
    --to=glommer@parallels.com \
    --cc=avagin@parallels.com \
    --cc=cgroups@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mhocko@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.