From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: netdev@vger.kernel.org, linux-can@vger.kernel.org,
"Reuben Dowle" <Reuben.Dowle@navico.com>,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCH] can: flexcan: fix irq flooding by clearing all interrupt sources
Date: Tue, 13 Dec 2011 13:59:22 +0100 [thread overview]
Message-ID: <4EE74C2A.9040908@pengutronix.de> (raw)
In-Reply-To: <4EE74AC5.9050404@grandegger.com>
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
On 12/13/2011 01:53 PM, Wolfgang Grandegger wrote:
>> I got my MX35PDK board working and can confirm, that the patch works on
>> a i.mx35 as well. My testing also confirms, that the ESR TWRN_INT,
>> RWRN_INT, FLEXCAN_ESR_BOFF_INT do not function as documented. These
>> flags do show up once, together with ERR_INT, and then, after clearing,
>> never again. Obviously a bug in the Flexcan logic. From the feedback we
>> can say, that only the i.MX28 does behave differently (==correctly). All
>> other seem to work with the current code:
>>
>> Flexcan on
>> - i.mx25
>> - i.mx35
>> - i.mx53
>> - P1010/P1020
>
> But unfortunately, state change reporting looks different with this patch :)
Hmm - so not schedule for stable. What about your buf-off-handling, will
this change the reporting again?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-12-13 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 15:09 [PATCH] can: flexcan: fix irq flooding by clearing all interrupt sources Wolfgang Grandegger
2011-12-12 15:31 ` Marc Kleine-Budde
2011-12-12 15:44 ` Wolfgang Grandegger
2011-12-13 12:13 ` Wolfgang Grandegger
2011-12-13 12:53 ` Marc Kleine-Budde
2011-12-13 12:53 ` Wolfgang Grandegger
2011-12-13 12:59 ` Marc Kleine-Budde [this message]
2011-12-13 16:22 ` Wolfgang Grandegger
2011-12-14 13:21 ` Wolfgang Grandegger
2012-01-31 21:59 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE74C2A.9040908@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=LW@KARO-electronics.de \
--cc=Reuben.Dowle@navico.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.