From: Anthony Liguori <anthony@codemonkey.ws>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH V2 3/5] Introduce premigrate RunState.
Date: Thu, 15 Dec 2011 09:14:00 -0600 [thread overview]
Message-ID: <4EEA0EB8.4020203@codemonkey.ws> (raw)
In-Reply-To: <1323467645-24271-4-git-send-email-anthony.perard@citrix.com>
On 12/09/2011 03:54 PM, Anthony PERARD wrote:
> This new state will be used by Xen functions to know QEMU will wait for a
> migration. This is important to know for memory related function because the
> memory is already allocated and reallocated them will not works.
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
Luiz, please Ack. In the future, when you make QMP changes, please CC the
appropriate maintainer.
Regards,
Anthony Liguori
> ---
> qapi-schema.json | 2 +-
> vl.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index cb1ba77..bd77444 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -121,7 +121,7 @@
> { 'enum': 'RunState',
> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> - 'running', 'save-vm', 'shutdown', 'watchdog' ] }
> + 'running', 'save-vm', 'shutdown', 'watchdog', 'premigrate' ] }
>
> ##
> # @StatusInfo:
> diff --git a/vl.c b/vl.c
> index e7dced2..a291416 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -351,8 +351,11 @@ static const RunStateTransition runstate_transitions_def[] = {
>
> { RUN_STATE_PRELAUNCH, RUN_STATE_RUNNING },
> { RUN_STATE_PRELAUNCH, RUN_STATE_FINISH_MIGRATE },
> + { RUN_STATE_PRELAUNCH, RUN_STATE_PREMIGRATE },
> { RUN_STATE_PRELAUNCH, RUN_STATE_INMIGRATE },
>
> + { RUN_STATE_PREMIGRATE, RUN_STATE_INMIGRATE },
> +
> { RUN_STATE_FINISH_MIGRATE, RUN_STATE_RUNNING },
> { RUN_STATE_FINISH_MIGRATE, RUN_STATE_POSTMIGRATE },
>
> @@ -2975,6 +2978,7 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_incoming:
> incoming = optarg;
> + runstate_set(RUN_STATE_PREMIGRATE);
> break;
> case QEMU_OPTION_nodefaults:
> default_serial = 0;
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Xen Devel <xen-devel@lists.xensource.com>,
QEMU-devel <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH V2 3/5] Introduce premigrate RunState.
Date: Thu, 15 Dec 2011 09:14:00 -0600 [thread overview]
Message-ID: <4EEA0EB8.4020203@codemonkey.ws> (raw)
In-Reply-To: <1323467645-24271-4-git-send-email-anthony.perard@citrix.com>
On 12/09/2011 03:54 PM, Anthony PERARD wrote:
> This new state will be used by Xen functions to know QEMU will wait for a
> migration. This is important to know for memory related function because the
> memory is already allocated and reallocated them will not works.
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
Luiz, please Ack. In the future, when you make QMP changes, please CC the
appropriate maintainer.
Regards,
Anthony Liguori
> ---
> qapi-schema.json | 2 +-
> vl.c | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index cb1ba77..bd77444 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -121,7 +121,7 @@
> { 'enum': 'RunState',
> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> - 'running', 'save-vm', 'shutdown', 'watchdog' ] }
> + 'running', 'save-vm', 'shutdown', 'watchdog', 'premigrate' ] }
>
> ##
> # @StatusInfo:
> diff --git a/vl.c b/vl.c
> index e7dced2..a291416 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -351,8 +351,11 @@ static const RunStateTransition runstate_transitions_def[] = {
>
> { RUN_STATE_PRELAUNCH, RUN_STATE_RUNNING },
> { RUN_STATE_PRELAUNCH, RUN_STATE_FINISH_MIGRATE },
> + { RUN_STATE_PRELAUNCH, RUN_STATE_PREMIGRATE },
> { RUN_STATE_PRELAUNCH, RUN_STATE_INMIGRATE },
>
> + { RUN_STATE_PREMIGRATE, RUN_STATE_INMIGRATE },
> +
> { RUN_STATE_FINISH_MIGRATE, RUN_STATE_RUNNING },
> { RUN_STATE_FINISH_MIGRATE, RUN_STATE_POSTMIGRATE },
>
> @@ -2975,6 +2978,7 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_incoming:
> incoming = optarg;
> + runstate_set(RUN_STATE_PREMIGRATE);
> break;
> case QEMU_OPTION_nodefaults:
> default_serial = 0;
next prev parent reply other threads:[~2011-12-15 15:14 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 21:54 [Qemu-devel] [PATCH V2 0/5] Have a working migration with Xen Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-09 21:54 ` [Qemu-devel] [PATCH V2 1/5] vl.c: Do not save RAM state when Xen is used Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-15 15:12 ` [Qemu-devel] " Anthony Liguori
2011-12-15 15:12 ` Anthony Liguori
2011-12-18 17:44 ` [Qemu-devel] " Avi Kivity
2011-12-18 17:44 ` Avi Kivity
2011-12-20 16:46 ` [Qemu-devel] " Anthony PERARD
2011-12-20 16:46 ` Anthony PERARD
2011-12-09 21:54 ` [Qemu-devel] [PATCH V2 2/5] xen mapcache: Check if a memory space has moved Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-12 12:53 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 12:53 ` Stefano Stabellini
2011-12-09 21:54 ` [Qemu-devel] [PATCH V2 3/5] Introduce premigrate RunState Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-15 15:14 ` Anthony Liguori [this message]
2011-12-15 15:14 ` Anthony Liguori
2011-12-15 16:31 ` [Qemu-devel] " Luiz Capitulino
2011-12-15 16:31 ` Luiz Capitulino
2011-12-19 17:27 ` [Qemu-devel] " Anthony PERARD
2011-12-19 17:27 ` Anthony PERARD
2012-01-03 19:05 ` [Qemu-devel] " Luiz Capitulino
2012-01-03 19:05 ` Luiz Capitulino
2012-01-05 12:26 ` [Qemu-devel] " Anthony PERARD
2012-01-05 12:26 ` Anthony PERARD
2011-12-09 21:54 ` [Qemu-devel] [PATCH V2 4/5] xen: Change memory access behavior during migration Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-12 12:55 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 12:55 ` Stefano Stabellini
2011-12-09 21:54 ` [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen Anthony PERARD
2011-12-09 21:54 ` Anthony PERARD
2011-12-10 10:45 ` [Qemu-devel] " Jan Kiszka
2011-12-10 10:45 ` Jan Kiszka
2011-12-12 13:18 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 13:18 ` Stefano Stabellini
2011-12-12 14:03 ` [Qemu-devel] " Jan Kiszka
2011-12-12 14:03 ` Jan Kiszka
2011-12-12 14:41 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 14:41 ` Stefano Stabellini
2011-12-12 15:03 ` [Qemu-devel] " Jan Kiszka
2011-12-12 15:03 ` Jan Kiszka
2011-12-12 15:32 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 15:32 ` Stefano Stabellini
2011-12-13 11:55 ` [Qemu-devel] early_savevm (was: [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.) Stefano Stabellini
2011-12-13 11:55 ` Stefano Stabellini
2011-12-13 12:35 ` [Qemu-devel] early_savevm Jan Kiszka
2011-12-13 12:35 ` early_savevm Jan Kiszka
2011-12-13 13:59 ` [Qemu-devel] early_savevm Stefano Stabellini
2011-12-13 13:59 ` early_savevm Stefano Stabellini
2011-12-18 17:43 ` [Qemu-devel] early_savevm Avi Kivity
2011-12-18 17:43 ` early_savevm Avi Kivity
2012-01-11 17:55 ` [Qemu-devel] early_savevm Anthony Liguori
2011-12-18 17:41 ` [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen Avi Kivity
2011-12-18 17:41 ` Avi Kivity
2012-01-04 16:38 ` [Qemu-devel] " Stefano Stabellini
2012-01-04 16:38 ` Stefano Stabellini
2012-01-04 17:23 ` [Qemu-devel] " Avi Kivity
2012-01-04 17:23 ` Avi Kivity
2012-01-05 12:30 ` [Qemu-devel] " Stefano Stabellini
2012-01-05 12:30 ` Stefano Stabellini
2012-01-05 12:50 ` [Qemu-devel] " Avi Kivity
2012-01-05 12:50 ` Avi Kivity
2012-01-05 13:17 ` [Qemu-devel] " Stefano Stabellini
2012-01-05 13:17 ` Stefano Stabellini
2012-01-05 13:32 ` [Qemu-devel] " Avi Kivity
2012-01-05 13:32 ` Avi Kivity
2012-01-05 14:34 ` [Qemu-devel] " Stefano Stabellini
2012-01-05 14:34 ` Stefano Stabellini
2012-01-05 15:19 ` [Qemu-devel] " Avi Kivity
2012-01-05 15:19 ` Avi Kivity
2012-01-05 15:53 ` [Qemu-devel] " Stefano Stabellini
2012-01-05 15:53 ` Stefano Stabellini
2012-01-05 16:33 ` [Qemu-devel] " Avi Kivity
2012-01-05 16:33 ` Avi Kivity
2012-01-05 17:21 ` [Qemu-devel] " Stefano Stabellini
2012-01-05 17:21 ` Stefano Stabellini
2012-01-05 17:50 ` [Qemu-devel] " Avi Kivity
2012-01-05 17:50 ` Avi Kivity
2012-01-05 18:49 ` [Qemu-devel] " Jan Kiszka
2012-01-05 18:49 ` Jan Kiszka
2012-01-06 10:50 ` [Qemu-devel] " Stefano Stabellini
2012-01-06 10:50 ` Stefano Stabellini
2012-01-06 13:30 ` [Qemu-devel] " Jan Kiszka
2012-01-06 13:30 ` Jan Kiszka
2012-01-06 14:40 ` [Qemu-devel] " Stefano Stabellini
2012-01-06 14:40 ` Stefano Stabellini
2012-01-08 10:39 ` [Qemu-devel] " Avi Kivity
2012-01-08 10:39 ` Avi Kivity
2012-01-09 15:25 ` [Qemu-devel] " Stefano Stabellini
2012-01-09 15:25 ` Stefano Stabellini
2012-01-09 15:28 ` [Qemu-devel] " Jan Kiszka
2012-01-09 15:28 ` Jan Kiszka
2012-01-09 15:36 ` [Qemu-devel] " Avi Kivity
2012-01-09 15:36 ` Avi Kivity
2012-01-06 15:58 ` [Qemu-devel] " Peter Maydell
2012-01-06 15:58 ` Peter Maydell
2012-01-06 16:50 ` [Qemu-devel] " Jan Kiszka
2012-01-06 16:50 ` Jan Kiszka
2012-01-06 12:19 ` [Qemu-devel] " Avi Kivity
2012-01-06 12:19 ` Avi Kivity
2012-01-06 12:22 ` [Qemu-devel] " Jan Kiszka
2012-01-06 12:22 ` Jan Kiszka
2012-01-06 12:47 ` [Qemu-devel] " Avi Kivity
2012-01-06 12:47 ` Avi Kivity
2011-12-12 12:58 ` [Qemu-devel] " Stefano Stabellini
2011-12-12 12:58 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEA0EB8.4020203@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=anthony.perard@citrix.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.