Re: [Qemu-devel] [PATCH V2 1/5] vl.c: Do not save RAM state when Xen is used.

[Avi Kivity <avi@redhat.com>]

On 12/15/2011 05:12 PM, Anthony Liguori wrote:
> On 12/09/2011 03:54 PM, Anthony PERARD wrote:
>> In Xen case, the guest RAM is not handle by QEMU, and it is saved by
>> Xen tools.
>> So, we just avoid to register the RAM save state handler.
>>
>> -    register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL,
>> -                         ram_load, NULL);
>> +    if (!xen_enabled()) {
>> +        register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live,
>> NULL,
>> +                             ram_load, NULL);
>> +    }
>
> Why don't you just unregister the section in the xen initialization
> code?  That way we don't have xen_enabled()'s sprinkled all over the
> place.

It's better to see them up front, having the magical string "ram"
connect the two is hard to follow.

-- 
error compiling committee.c: too many arguments to function