From: Rajendra Nayak <rnayak@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Cousson, Benoit" <b-cousson@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported
Date: Fri, 16 Dec 2011 17:51:20 +0530 [thread overview]
Message-ID: <4EEB37C0.1070307@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112160422150.12660@utopia.booyaka.com>
On Friday 16 December 2011 04:53 PM, Paul Walmsley wrote:
> Hi
>
> On Fri, 16 Dec 2011, Paul Walmsley wrote:
>
>> + * XXX Will not work correctly if the RM_*_CONTEXT register
>> + * offset is 0 -- probably a flag should be used to avoid this
>> + * situation, rather than testing @oh->prcm.omap4.context_offs. No
>> + * return value.
>
> By the way, I'm also worried about this case. Am wondering if we should
> add a flag here just to be sure, rather than testing the offset.
> Thoughts?
I am not sure if we even have any modules on OMAP4 which *do not*
support module level context loss status and for which we need to fall
back on pwrdm level status. So maybe we could even get rid of the check
for a valid context_offset altogether and expect it to be populated for
all modules as we do with the clkctrl offset.
>
>
> - Paul
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported
Date: Fri, 16 Dec 2011 17:51:20 +0530 [thread overview]
Message-ID: <4EEB37C0.1070307@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112160422150.12660@utopia.booyaka.com>
On Friday 16 December 2011 04:53 PM, Paul Walmsley wrote:
> Hi
>
> On Fri, 16 Dec 2011, Paul Walmsley wrote:
>
>> + * XXX Will not work correctly if the RM_*_CONTEXT register
>> + * offset is 0 -- probably a flag should be used to avoid this
>> + * situation, rather than testing @oh->prcm.omap4.context_offs. No
>> + * return value.
>
> By the way, I'm also worried about this case. Am wondering if we should
> add a flag here just to be sure, rather than testing the offset.
> Thoughts?
I am not sure if we even have any modules on OMAP4 which *do not*
support module level context loss status and for which we need to fall
back on pwrdm level status. So maybe we could even get rid of the check
for a valid context_offset altogether and expect it to be populated for
all modules as we do with the clkctrl offset.
>
>
> - Paul
next prev parent reply other threads:[~2011-12-16 12:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 10:54 [PATCH 0/3] Support omap_pm_get_dev_context_loss_count() for OMAP4 Rajendra Nayak
2011-11-03 10:54 ` Rajendra Nayak
2011-11-03 10:54 ` [PATCH 1/3] ARM: OMAP: hmwod: Add support for per hwmod/module context lost count Rajendra Nayak
2011-11-03 10:54 ` Rajendra Nayak
2011-11-03 10:54 ` [PATCH 2/3] ARM: OMAP: hwmod: Update/Clear module specific context lost counters Rajendra Nayak
2011-11-03 10:54 ` Rajendra Nayak
2011-11-03 10:54 ` [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported Rajendra Nayak
2011-11-03 10:54 ` Rajendra Nayak
2011-11-29 18:10 ` Cousson, Benoit
2011-11-29 18:10 ` Cousson, Benoit
2011-12-02 4:46 ` Rajendra Nayak
2011-12-02 4:46 ` Rajendra Nayak
2011-12-16 11:16 ` Paul Walmsley
2011-12-16 11:16 ` Paul Walmsley
2011-12-16 11:23 ` Paul Walmsley
2011-12-16 11:23 ` Paul Walmsley
2011-12-16 12:21 ` Rajendra Nayak [this message]
2011-12-16 12:21 ` Rajendra Nayak
2011-12-16 12:38 ` Paul Walmsley
2011-12-16 12:38 ` Paul Walmsley
2011-12-16 12:17 ` Rajendra Nayak
2011-12-16 12:17 ` Rajendra Nayak
2011-12-16 12:38 ` Paul Walmsley
2011-12-16 12:38 ` Paul Walmsley
2011-12-16 12:41 ` Rajendra Nayak
2011-12-16 12:41 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEB37C0.1070307@ti.com \
--to=rnayak@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.