From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Frederic Weisbecker
<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
Subject: Re: [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once
Date: Wed, 21 Dec 2011 09:29:25 +0800 [thread overview]
Message-ID: <4EF13675.9030000@cn.fujitsu.com> (raw)
In-Reply-To: <1324422873-31001-4-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Mandeep Singh Baines wrote:
> In cgroup_attach_proc it is now sufficient to only check that
> oldcgrp==newcgrp once. Now that we are using threadgroup_lock()
> during the migrations, oldcgrp will not change.
>
> Signed-off-by: Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Reviewed-by: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> Cc: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
> Cc: Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
> ---
> kernel/cgroup.c | 17 ++++++-----------
> 1 files changed, 6 insertions(+), 11 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Tejun Heo <tj@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once
Date: Wed, 21 Dec 2011 09:29:25 +0800 [thread overview]
Message-ID: <4EF13675.9030000@cn.fujitsu.com> (raw)
In-Reply-To: <1324422873-31001-4-git-send-email-msb@chromium.org>
Mandeep Singh Baines wrote:
> In cgroup_attach_proc it is now sufficient to only check that
> oldcgrp==newcgrp once. Now that we are using threadgroup_lock()
> during the migrations, oldcgrp will not change.
>
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: containers@lists.linux-foundation.org
> Cc: cgroups@vger.kernel.org
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Paul Menage <paul@paulmenage.org>
> ---
> kernel/cgroup.c | 17 ++++++-----------
> 1 files changed, 6 insertions(+), 11 deletions(-)
next prev parent reply other threads:[~2011-12-21 1:29 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 23:14 [PATCH 0/5] cgroup: some cleanups of cgroup_attach_proc Mandeep Singh Baines
[not found] ` <1324422873-31001-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:14 ` [PATCH 1/5 V3] cgroup: remove redundate get/put of old css_set from migrate Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
[not found] ` <1324422873-31001-2-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:18 ` Tejun Heo
2011-12-20 23:18 ` Tejun Heo
2011-12-20 23:18 ` Tejun Heo
[not found] ` <20111220231823.GK10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:41 ` Mandeep Singh Baines
2011-12-20 23:41 ` Mandeep Singh Baines
[not found] ` <20111220234131.GV13529-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:42 ` Tejun Heo
2011-12-20 23:42 ` Tejun Heo
[not found] ` <20111220234259.GO10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:46 ` Tejun Heo
2011-12-20 23:46 ` Tejun Heo
2011-12-20 23:46 ` Tejun Heo
2011-12-21 1:10 ` Li Zefan
2011-12-21 1:10 ` Li Zefan
2011-12-21 1:10 ` Li Zefan
2011-12-20 23:14 ` [PATCH 2/5] cgroup: remove redundant get/put of task struct Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
[not found] ` <1324422873-31001-3-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:23 ` Tejun Heo
2011-12-20 23:23 ` Tejun Heo
[not found] ` <20111220232326.GL10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:04 ` Mandeep Singh Baines
2011-12-21 0:04 ` Mandeep Singh Baines
2011-12-21 0:04 ` Mandeep Singh Baines
2011-12-20 23:14 ` [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
[not found] ` <1324422873-31001-4-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-21 1:29 ` Li Zefan [this message]
2011-12-21 1:29 ` Li Zefan
2011-12-20 23:14 ` [PATCH 4/5] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
[not found] ` <1324422873-31001-5-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:30 ` Tejun Heo
2011-12-20 23:30 ` Tejun Heo
[not found] ` <20111220233050.GM10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:47 ` Mandeep Singh Baines
2011-12-20 23:47 ` Mandeep Singh Baines
2011-12-20 23:47 ` Mandeep Singh Baines
2011-12-20 23:30 ` Tejun Heo
2011-12-20 23:14 ` [PATCH 5/5] cgroup: separate out cgroup_attach_proc error handling code Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
2011-12-20 23:14 ` Mandeep Singh Baines
[not found] ` <1324422873-31001-6-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:35 ` Tejun Heo
2011-12-20 23:35 ` Tejun Heo
[not found] ` <20111220233502.GN10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:02 ` Mandeep Singh Baines
2011-12-21 0:02 ` Mandeep Singh Baines
2011-12-21 0:02 ` Mandeep Singh Baines
[not found] ` <20111221000231.GX13529-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:13 ` Tejun Heo
2011-12-21 0:13 ` Tejun Heo
2011-12-21 0:13 ` Tejun Heo
2011-12-20 23:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF13675.9030000@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.