From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Move gfn_to_memslot() to kvm_host.h
Date: Mon, 02 Jan 2012 16:13:56 +0000 [thread overview]
Message-ID: <4F01D7C4.1020408@redhat.com> (raw)
In-Reply-To: <6918CBBE-19AF-4323-BFE7-0F8739E32008@suse.de>
On 01/02/2012 05:23 PM, Alexander Graf wrote:
> > Or we could move the implementation into a header file, with an extra __
> > prefix, and have the C stubs call those inlines, so we have exactly on
> > instantiation. Your real mode code can then call the inlines.
>
> I like this version. That way everyone should be happy :)
Pretty much how everything is solved. Pile up another layer of
indirection (compile-time here), everyone's happy, and the code bloats.
(I'm not against this, just grumpy)
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] KVM: Move gfn_to_memslot() to kvm_host.h
Date: Mon, 02 Jan 2012 18:13:56 +0200 [thread overview]
Message-ID: <4F01D7C4.1020408@redhat.com> (raw)
In-Reply-To: <6918CBBE-19AF-4323-BFE7-0F8739E32008@suse.de>
On 01/02/2012 05:23 PM, Alexander Graf wrote:
> > Or we could move the implementation into a header file, with an extra __
> > prefix, and have the C stubs call those inlines, so we have exactly on
> > instantiation. Your real mode code can then call the inlines.
>
> I like this version. That way everyone should be happy :)
Pretty much how everything is solved. Pile up another layer of
indirection (compile-time here), everyone's happy, and the code bloats.
(I'm not against this, just grumpy)
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Move gfn_to_memslot() to kvm_host.h
Date: Mon, 02 Jan 2012 18:13:56 +0200 [thread overview]
Message-ID: <4F01D7C4.1020408@redhat.com> (raw)
In-Reply-To: <6918CBBE-19AF-4323-BFE7-0F8739E32008@suse.de>
On 01/02/2012 05:23 PM, Alexander Graf wrote:
> > Or we could move the implementation into a header file, with an extra __
> > prefix, and have the C stubs call those inlines, so we have exactly on
> > instantiation. Your real mode code can then call the inlines.
>
> I like this version. That way everyone should be happy :)
Pretty much how everything is solved. Pile up another layer of
indirection (compile-time here), everyone's happy, and the code bloats.
(I'm not against this, just grumpy)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-01-02 16:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 9:21 [PATCH] KVM: Move gfn_to_memslot() to kvm_host.h Paul Mackerras
2011-12-20 9:21 ` Paul Mackerras
2011-12-23 13:33 ` Alexander Graf
2011-12-23 13:33 ` Alexander Graf
2011-12-23 13:33 ` Alexander Graf
2011-12-26 13:22 ` Avi Kivity
2011-12-26 13:22 ` Avi Kivity
2011-12-26 13:22 ` Avi Kivity
2012-01-02 15:23 ` Alexander Graf
2012-01-02 15:23 ` Alexander Graf
2012-01-02 15:23 ` Alexander Graf
2012-01-02 16:13 ` Avi Kivity [this message]
2012-01-02 16:13 ` Avi Kivity
2012-01-02 16:13 ` Avi Kivity
2012-01-12 10:41 ` Paul Mackerras
2012-01-12 10:41 ` Paul Mackerras
2012-01-12 10:41 ` Paul Mackerras
2012-01-12 14:57 ` Alexander Graf
2012-01-12 14:57 ` Alexander Graf
2012-01-12 14:57 ` Alexander Graf
2012-01-12 15:47 ` Avi Kivity
2012-01-12 15:47 ` Avi Kivity
2012-01-12 15:47 ` Avi Kivity
2012-01-13 6:09 ` [PATCH v3] " Paul Mackerras
2012-01-13 6:09 ` Paul Mackerras
2012-01-13 6:09 ` Paul Mackerras
2012-01-16 13:18 ` Alexander Graf
2012-01-16 13:18 ` Alexander Graf
2012-01-16 13:18 ` Alexander Graf
2012-01-16 13:21 ` Avi Kivity
2012-01-16 13:21 ` Avi Kivity
2012-01-16 13:30 ` Alexander Graf
2012-01-16 13:30 ` Alexander Graf
2012-01-16 13:30 ` Alexander Graf
2012-01-17 5:02 ` Paul Mackerras
2012-01-17 5:02 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F01D7C4.1020408@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.