All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu-devel <qemu-devel@nongnu.org>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Dave Anderson <anderson@redhat.com>,
	HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Subject: [Qemu-devel] [RFC][PATCH 13/14 v4] support to query dumping status
Date: Wed, 04 Jan 2012 14:16:12 +0800	[thread overview]
Message-ID: <4F03EEAC.4050400@cn.fujitsu.com> (raw)
In-Reply-To: <4F03E735.2050804@cn.fujitsu.com>

Add API to allow the user to query dumping status.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 dump.c           |   30 ++++++++++++++++++++++++++++++
 hmp-commands.hx  |    2 ++
 hmp.c            |   13 +++++++++++++
 hmp.h            |    1 +
 monitor.c        |    7 +++++++
 qapi-schema.json |   26 ++++++++++++++++++++++++++
 qmp-commands.hx  |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 126 insertions(+), 0 deletions(-)

diff --git a/dump.c b/dump.c
index 2131e22..4276cb8 100644
--- a/dump.c
+++ b/dump.c
@@ -746,3 +746,33 @@ void qmp_dump_set_speed(int64_t value, Error **errp)
     s->bandwidth = value;
     return;
 }
+
+DumpInfo *qmp_query_dump(Error **errp)
+{
+    DumpInfo *info = g_malloc0(sizeof(*info));
+    DumpState *s = dump_get_current();
+
+    switch (s->state) {
+    case DUMP_STATE_SETUP:
+        /* no migration has happened ever */
+        break;
+    case DUMP_STATE_ACTIVE:
+        info->has_status = true;
+        info->status = g_strdup("active");
+        break;
+    case DUMP_STATE_COMPLETED:
+        info->has_status = true;
+        info->status = g_strdup("completed");
+        break;
+    case DUMP_STATE_ERROR:
+        info->has_status = true;
+        info->status = g_strdup("failed");
+        break;
+    case DUMP_STATE_CANCELLED:
+        info->has_status = true;
+        info->status = g_strdup("cancelled");
+        break;
+    }
+
+    return info;
+}
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 20543dd..1eaaf18 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1397,6 +1397,8 @@ show device tree
 show qdev device model list
 @item info roms
 show roms
+@item info dump
+show dumping status
 @end table
 ETEXI
 
diff --git a/hmp.c b/hmp.c
index be64075..04ed86a 100644
--- a/hmp.c
+++ b/hmp.c
@@ -690,3 +690,16 @@ void hmp_dump_set_speed(Monitor *mon, const QDict *qdict)
     int64_t value = qdict_get_int(qdict, "value");
     qmp_dump_set_speed(value, NULL);
 }
+
+void hmp_info_dump(Monitor *mon)
+{
+    DumpInfo *info;
+
+    info = qmp_query_dump(NULL);
+
+    if (info->has_status) {
+        monitor_printf(mon, "Dumping status: %s\n", info->status);
+    }
+
+    qapi_free_DumpInfo(info);
+}
diff --git a/hmp.h b/hmp.h
index 3aa947c..5f58b9e 100644
--- a/hmp.h
+++ b/hmp.h
@@ -51,5 +51,6 @@ void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict);
 void hmp_migrate_set_speed(Monitor *mon, const QDict *qdict);
 void hmp_dump_cancel(Monitor *mon, const QDict *qdict);
 void hmp_dump_set_speed(Monitor *mon, const QDict *qdict);
+void hmp_info_dump(Monitor *mon);
 
 #endif
diff --git a/monitor.c b/monitor.c
index edd6aa7..b1d09cc 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2739,6 +2739,13 @@ static mon_cmd_t info_cmds[] = {
         .mhandler.info = do_trace_print_events,
     },
     {
+        .name       = "dump",
+        .args_type  = "",
+        .params     = "",
+        .help       = "show dumping status",
+        .mhandler.info = hmp_info_dump,
+    },
+    {
         .name       = NULL,
     },
 };
diff --git a/qapi-schema.json b/qapi-schema.json
index ca324d6..087027a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1303,3 +1303,29 @@
 # Since: 1.1
 ##
 { 'command': 'dump_set_speed', 'data': {'value': 'int'} }
+
+##
+# @DumpInfo
+#
+# Information about current migration process.
+#
+# @status: #optional string describing the current dumping status.
+#          As of 1,1 this can be 'active', 'completed', 'failed' or
+#          'cancelled'. If this field is not returned, no migration process
+#          has been initiated
+#
+# Since: 1.1
+##
+{ 'type': 'DumpInfo',
+  'data': {'*status': 'str'} }
+
+##
+# @query-dump
+#
+# Returns information about current dumping process.
+#
+# Returns: @DumpInfo
+#
+# Since: 1.1
+##
+{ 'command': 'query-dump', 'returns': 'DumpInfo' }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 6f84cdc..bccc3a4 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2040,6 +2040,53 @@ EQMP
     },
 
 SQMP
+query-dump
+-------------
+
+Dumping status.
+
+Return a json-object.
+
+The main json-object contains the following:
+
+- "status": migration status (json-string)
+     - Possible values: "active", "completed", "failed", "cancelled"
+
+Examples:
+
+1. Before the first migration
+
+-> { "execute": "query-dump" }
+<- { "return": {} }
+
+2. Migration is done and has succeeded
+
+-> { "execute": "query-dump" }
+<- { "return": { "status": "completed" } }
+
+3. Migration is done and has failed
+
+-> { "execute": "query-dump" }
+<- { "return": { "status": "failed" } }
+
+4. Migration is being performed:
+
+-> { "execute": "query-dump" }
+<- {
+      "return":{
+         "status":"active",
+      }
+   }
+
+EQMP
+
+    {
+        .name       = "query-dump",
+        .args_type  = "",
+        .mhandler.cmd_new = qmp_marshal_input_query_dump,
+    },
+
+SQMP
 query-balloon
 -------------
 
-- 
1.7.1

  parent reply	other threads:[~2012-01-04  6:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  5:44 [Qemu-devel] [RFC][PATCT 0/14 v4] dump memory when host pci device is used by guest Wen Congyang
2012-01-04  6:04 ` [Qemu-devel] [RFC][PATCH 01/14 v4] Add API to create memory mapping list Wen Congyang
2012-01-04  6:05 ` [Qemu-devel] [RFC][PATCH 02/14 v4] Add API to check whether a physical address is I/O address Wen Congyang
2012-01-04  6:06 ` [Qemu-devel] [RFC][PATCH 03/14 v4] target-i386: implement cpu_get_memory_mapping() Wen Congyang
2012-01-04  6:07 ` [Qemu-devel] [RFC][PATCH 04/14 v4] Add API to get memory mapping Wen Congyang
2012-01-04  6:08 ` [Qemu-devel] [RFC][PATCH 05/14 v4] target-i386: Add API to write elf notes to core file Wen Congyang
2012-01-04  6:09 ` [Qemu-devel] [RFC][PATCH 06/14 v4] target-i386: Add API to add extra memory mapping Wen Congyang
2012-01-04  6:10 ` [Qemu-devel] [RFC][PATCH 07/14 v4] target-i386: add API to get dump info Wen Congyang
2012-01-04  6:11 ` [Qemu-devel] [RFC][PATCH 08/14 v4] introduce a new monitor command 'dump' to dump guest's memory Wen Congyang
2012-01-10 13:30   ` Luiz Capitulino
2012-01-11  0:59     ` Wen Congyang
2012-01-12 13:49       ` Luiz Capitulino
2012-01-13  8:35         ` Wen Congyang
2012-01-04  6:12 ` [Qemu-devel] [RFC][PATCH 09/14 v4] run dump at the background Wen Congyang
2012-01-04  6:13 ` [Qemu-devel] [RFC][PATCH 10/14 v4] support detached dump Wen Congyang
2012-01-04  6:14 ` [Qemu-devel] [RFC][PATCH 11/14 v4] support to cancel the current dumping Wen Congyang
2012-01-04  6:15 ` [Qemu-devel] [RFC][PATCH 12/14 v4] support to set dumping speed Wen Congyang
2012-01-04  6:16 ` Wen Congyang [this message]
2012-01-04  6:17 ` [Qemu-devel] [RFC][PATCH 14/14 v4] auto cancel dumping after vm state is changed to run Wen Congyang
2012-01-10  7:44 ` [Qemu-devel] [RFC][PATCT 0/14 v4] dump memory when host pci device is used by guest Wen Congyang
2012-01-10  9:41   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F03EEAC.4050400@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=anderson@redhat.com \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.