From: "Arend van Spriel" <arend@broadcom.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Alwin Beukers" <alwin@broadcom.com>,
"Roland Vossen" <rvossen@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
"Network Development" <netdev@vger.kernel.org>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: brcm80211 breakage..
Date: Thu, 12 Jan 2012 11:03:53 +0100 [thread overview]
Message-ID: <4F0EB009.208@broadcom.com> (raw)
In-Reply-To: <CA+55aFzkCXnHfF_TO5M+gaN4RMvj_WNuW_QeBezuYBdWnwPDpg@mail.gmail.com>
On 01/12/2012 08:13 AM, Linus Torvalds wrote:
> On Wed, Jan 11, 2012 at 9:30 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> The code in v3.2 also used to support srom rev < 4, the new code
>> doesn't seem to do that.
>
> I ended up trying to bisect this, and seem to have been successful.
> The problem came in not with the BCMA use, but with commit
> 888153b3db3f ("brcm80211: smac: avoid sprom endianess conversions for
> crc8 check")
Thanks for doing that while I had put my head on a pillow.
> I haven't yet tried to revert this on top of the current tree, but I'm
> pretty sure about the bisection. That commit changes things to be read
> a byte at a time, but it *also* removes the old code that only read
> SROM_WORDS from the SROM.
>
> Might the apple parts have different SROM contents? I assume "SROM" is
> just a serial rom, which may be external and contain things like the ?
Mostly configuration parameters for RF/PHY.
> All the BCMA changes make the revert somewhat non-trivial, could
> somebody who knows the code better please try to do it for me? It
> doesn't look complicated, and I can try to do it myself tomorrow if
> nobody else steps up, but I'd *really* prefer the guilty parties
> themselves to do it, ok?
>
> Arend - it's your commit...
Ok. I know a hint when I see one ;-)
> Linus
>
Gr. AvS
next prev parent reply other threads:[~2012-01-12 10:04 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 20:15 brcm80211 breakage Linus Torvalds
2012-01-11 10:44 ` Arend van Spriel
2012-01-11 15:05 ` Linus Torvalds
2012-01-11 16:04 ` Linus Torvalds
2012-01-11 17:00 ` Larry Finger
2012-01-12 1:06 ` Linus Torvalds
2012-01-12 1:46 ` Larry Finger
2012-01-12 1:58 ` Linus Torvalds
2012-01-12 2:11 ` Linus Torvalds
2012-01-12 4:15 ` Larry Finger
2012-01-12 5:20 ` Linus Torvalds
2012-01-12 5:30 ` Linus Torvalds
2012-01-12 7:08 ` Rafał Miłecki
2012-01-12 7:10 ` Rafał Miłecki
2012-01-12 7:18 ` Linus Torvalds
2012-01-12 15:39 ` Larry Finger
2012-01-12 15:46 ` Rafał Miłecki
2012-01-12 7:13 ` Linus Torvalds
2012-01-12 7:18 ` Rafał Miłecki
2012-01-12 7:22 ` Linus Torvalds
2012-01-12 10:03 ` Arend van Spriel [this message]
2012-01-12 15:51 ` Linus Torvalds
2012-01-12 19:00 ` Linus Torvalds
2012-01-12 19:08 ` Linus Torvalds
2012-01-12 20:09 ` Arend van Spriel
2012-01-12 20:27 ` Linus Torvalds
2012-01-12 20:36 ` Arend van Spriel
2012-01-12 22:38 ` Linus Torvalds
2012-01-12 22:42 ` Rafał Miłecki
2012-01-12 22:45 ` Linus Torvalds
2012-01-12 23:04 ` Rafał Miłecki
2012-01-13 0:13 ` Linus Torvalds
2012-01-13 2:30 ` Linus Torvalds
2012-01-13 5:34 ` Linus Torvalds
2012-01-13 6:50 ` Rafał Miłecki
2012-01-13 6:57 ` Rafał Miłecki
2012-01-13 7:17 ` Linus Torvalds
2012-01-13 7:41 ` [PATCH] bcma: s&r: NULL mapped core Rafał Miłecki
2012-01-13 7:53 ` Linus Torvalds
2012-01-13 7:59 ` [0/5] bcma/brcmsmac suspend/resume cleanups and fixes Linus Torvalds
2012-01-13 8:00 ` [PATCH 1/5] bcma: convert suspend/resume to pm_ops Linus Torvalds
2012-01-13 9:58 ` Arend van Spriel
2012-01-13 10:01 ` Rafał Miłecki
2012-01-13 8:00 ` [PATCH 2/5] bcma: add stub for bcma_bus suspend() Linus Torvalds
2012-01-13 8:01 ` [PATCH 3/5] bcma: connect the bcma bus suspend/resume to the bcma driver suspend/resume Linus Torvalds
2012-01-13 8:01 ` [PATCH 4/5] brcmsmac: remove PCI suspend/resume from bcma driver Linus Torvalds
2012-01-13 9:59 ` Arend van Spriel
2012-01-13 8:02 ` [PATCH 5/5] bcma: invalidate the mapped window over suspend/resume Linus Torvalds
2012-01-13 10:03 ` [0/5] bcma/brcmsmac suspend/resume cleanups and fixes Rafał Miłecki
2012-01-13 16:15 ` Linus Torvalds
2012-01-13 11:06 ` Arend van Spriel
2012-01-13 16:23 ` Linus Torvalds
2012-01-14 3:50 ` Linus Torvalds
2012-01-14 12:22 ` Dominique Martinet
2012-01-14 14:34 ` Rafał Miłecki
2012-01-14 15:07 ` Dominique Martinet
2012-01-14 19:15 ` Linus Torvalds
2012-01-14 23:08 ` Dominique Martinet
2012-01-14 23:28 ` Linus Torvalds
2012-01-14 17:36 ` Arend van Spriel
2012-01-16 14:00 ` Arend van Spriel
2012-01-16 17:33 ` Arend van Spriel
2012-01-17 1:12 ` Linus Torvalds
2012-01-17 10:37 ` Arend van Spriel
2012-01-19 9:42 ` Arend van Spriel
2012-01-19 12:12 ` Arend van Spriel
2012-01-19 16:15 ` Linus Torvalds
2012-01-13 7:13 ` brcm80211 breakage Linus Torvalds
2012-01-12 19:46 ` Arend van Spriel
2012-01-13 1:53 ` Larry Finger
2012-01-31 12:08 ` Henrik Rydberg
2012-01-31 17:02 ` Linus Torvalds
2012-01-31 19:08 ` Arend van Spriel
2012-01-31 19:25 ` John W. Linville
2012-01-31 19:35 ` Arend van Spriel
2012-01-31 19:58 ` Henrik Rydberg
2012-01-31 20:21 ` Arend van Spriel
2012-01-31 22:23 ` Henrik Rydberg
2012-01-31 19:36 ` Henrik Rydberg
2012-01-31 19:49 ` Arend van Spriel
2012-01-12 13:13 ` Arend van Spriel
2012-01-12 16:22 ` Larry Finger
2012-01-12 17:18 ` Larry Finger
2012-01-12 17:31 ` Linus Torvalds
2012-01-12 17:44 ` Larry Finger
2012-01-11 21:01 ` Arend van Spriel
2012-01-12 0:07 ` Linus Torvalds
2012-01-11 17:15 ` Ben Hutchings
2012-01-12 0:10 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0EB009.208@broadcom.com \
--to=arend@broadcom.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alwin@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rvossen@broadcom.com \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.