All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aneesh V <aneesh@ti.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	Joe Woodward <jw@terrafix.co.uk>
Subject: Re: OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)?
Date: Tue, 17 Jan 2012 17:57:25 +0530	[thread overview]
Message-ID: <4F15692D.4070100@ti.com> (raw)
In-Reply-To: <20120117121138.GC11475@arm.com>

Hi Catalin,

On Tuesday 17 January 2012 05:41 PM, Catalin Marinas wrote:
> On Tue, Jan 17, 2012 at 08:54:44AM +0000, Joe Woodward wrote:
>> So, is the upshot of this that the kernel isn't going to be in a
>> position to enable the L2/outer cache on OMAP3 (due to the need for
>> hacky/unmaintainable code)?
>>
>> Hence the bootloader/uBoot had better leave it enabled...
>
> It could but the Linux decompressor needs to be aware and either flush
> the L2 (more difficult as it doesn't have all the device information) or

Cortex-A8 is aware of L2$ and can flush it, isn't it?

> set the page table attributes to outer non-cacheable (TEX[2:0] = 0b100).

If the above is right, this is not needed right?

> The latter may still not work if there are stale L2 cache lines left by
> U-Boot (and that's always possible unless U-Boot also uses outer
> non-cacheable memory attributes).

U-Boot flushes the caches before disabling it. On top of it, it does an
invalidate after the disabling the caches to cover some corner case.
So, it's guaranteed that there won't be any stale entries in L2 after
U-Boot.

So, we could as well leave L2$ enabled (and invalidated) and caches
disabled globally after U-Boot. But I thought enabling L2$ again in
kernel is the cleaner solution.

br,
Aneesh

WARNING: multiple messages have this Message-ID (diff)
From: aneesh@ti.com (Aneesh V)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)?
Date: Tue, 17 Jan 2012 17:57:25 +0530	[thread overview]
Message-ID: <4F15692D.4070100@ti.com> (raw)
In-Reply-To: <20120117121138.GC11475@arm.com>

Hi Catalin,

On Tuesday 17 January 2012 05:41 PM, Catalin Marinas wrote:
> On Tue, Jan 17, 2012 at 08:54:44AM +0000, Joe Woodward wrote:
>> So, is the upshot of this that the kernel isn't going to be in a
>> position to enable the L2/outer cache on OMAP3 (due to the need for
>> hacky/unmaintainable code)?
>>
>> Hence the bootloader/uBoot had better leave it enabled...
>
> It could but the Linux decompressor needs to be aware and either flush
> the L2 (more difficult as it doesn't have all the device information) or

Cortex-A8 is aware of L2$ and can flush it, isn't it?

> set the page table attributes to outer non-cacheable (TEX[2:0] = 0b100).

If the above is right, this is not needed right?

> The latter may still not work if there are stale L2 cache lines left by
> U-Boot (and that's always possible unless U-Boot also uses outer
> non-cacheable memory attributes).

U-Boot flushes the caches before disabling it. On top of it, it does an
invalidate after the disabling the caches to cover some corner case.
So, it's guaranteed that there won't be any stale entries in L2 after
U-Boot.

So, we could as well leave L2$ enabled (and invalidated) and caches
disabled globally after U-Boot. But I thought enabling L2$ again in
kernel is the cleaner solution.

br,
Aneesh

  reply	other threads:[~2012-01-17 12:27 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 10:03 OMAP3 L2/outer cache enabled in kernel (after being disabled by uBoot)? Joe Woodward
2012-01-16 10:18 ` Shilimkar, Santosh
2012-01-16 10:18   ` Shilimkar, Santosh
2012-01-16 10:59   ` Russell King - ARM Linux
2012-01-16 10:59     ` Russell King - ARM Linux
2012-01-16 12:43     ` Shilimkar, Santosh
2012-01-16 12:43       ` Shilimkar, Santosh
2012-01-16 13:13       ` Russell King - ARM Linux
2012-01-16 13:13         ` Russell King - ARM Linux
2012-01-16 13:22         ` Shilimkar, Santosh
2012-01-16 13:22           ` Shilimkar, Santosh
2012-01-17  8:54           ` Joe Woodward
2012-01-17 12:11             ` Catalin Marinas
2012-01-17 12:11               ` Catalin Marinas
2012-01-17 12:27               ` Aneesh V [this message]
2012-01-17 12:27                 ` Aneesh V
2012-01-17 12:40                 ` Shilimkar, Santosh
2012-01-17 13:39                   ` Catalin Marinas
2012-01-17 13:39                     ` Catalin Marinas
2012-01-17 13:58                     ` Shilimkar, Santosh
2012-01-17 13:58                       ` Shilimkar, Santosh
2012-01-17 16:27                       ` Catalin Marinas
2012-01-17 16:27                         ` Catalin Marinas
2012-01-17 17:27                         ` Shilimkar, Santosh
2012-01-17 17:27                           ` Shilimkar, Santosh
2012-01-17 19:39                           ` Nicolas Pitre
2012-01-17 19:39                             ` Nicolas Pitre
2012-01-17 20:27                             ` Shilimkar, Santosh
2012-01-17 20:27                               ` Shilimkar, Santosh
2012-01-17 20:45                               ` Nicolas Pitre
2012-01-17 20:45                                 ` Nicolas Pitre
2012-01-17 20:57                                 ` Nicolas Pitre
2012-01-17 20:57                                   ` Nicolas Pitre
2012-01-17 20:58                                 ` Shilimkar, Santosh
2012-01-17 20:58                                   ` Shilimkar, Santosh
2012-01-17 21:02                                   ` Nicolas Pitre
2012-01-17 21:02                                     ` Nicolas Pitre
2012-01-18  8:43                                     ` Shilimkar, Santosh
2012-01-18  8:43                                       ` Shilimkar, Santosh
2012-01-17 21:15                               ` Russell King - ARM Linux
2012-01-17 21:15                                 ` Russell King - ARM Linux
2012-01-17 19:47                         ` Russell King - ARM Linux
2012-01-17 19:47                           ` Russell King - ARM Linux
2012-01-17 20:11                           ` Shilimkar, Santosh
2012-01-17 20:11                             ` Shilimkar, Santosh
2012-01-17 20:48                             ` Russell King - ARM Linux
2012-01-17 20:48                               ` Russell King - ARM Linux
2012-01-17 19:43                       ` Russell King - ARM Linux
2012-01-17 19:43                         ` Russell King - ARM Linux
2012-01-20  8:57                       ` Joe Woodward
2012-01-27 11:45                         ` Joe Woodward
2012-01-27 17:30                         ` Catalin Marinas
2012-01-27 17:30                           ` Catalin Marinas
2012-01-31  5:21                           ` Aneesh V
2012-01-31  5:21                             ` Aneesh V
2012-01-31  7:31                             ` Catalin Marinas
2012-01-31  7:31                               ` Catalin Marinas
2012-01-31  7:38                               ` Shilimkar, Santosh
2012-01-31  7:38                                 ` Shilimkar, Santosh
2012-01-31  8:54                                 ` Catalin Marinas
2012-01-31  8:54                                   ` Catalin Marinas
2012-01-31  9:05                                   ` Shilimkar, Santosh
2012-01-31  9:05                                     ` Shilimkar, Santosh
2012-01-31  9:53                                     ` Catalin Marinas
2012-01-31  9:53                                       ` Catalin Marinas
2012-01-31 10:10                                       ` Russell King - ARM Linux
2012-01-31 10:10                                         ` Russell King - ARM Linux
2012-01-31 12:10                                         ` Catalin Marinas
2012-01-31 12:10                                           ` Catalin Marinas
2012-01-31 18:09                                       ` Nicolas Pitre
2012-01-31 18:09                                         ` Nicolas Pitre
2012-02-02 14:32                                         ` Catalin Marinas
2012-02-02 14:32                                           ` Catalin Marinas
2012-02-02 14:49                                           ` Russell King - ARM Linux
2012-02-02 14:49                                             ` Russell King - ARM Linux
2012-02-02 15:10                                             ` Catalin Marinas
2012-02-02 15:10                                               ` Catalin Marinas
2012-01-31  9:56                                     ` Russell King - ARM Linux
2012-01-31  9:56                                       ` Russell King - ARM Linux
2012-01-31 10:51                                       ` Shilimkar, Santosh
2012-01-31 10:51                                         ` Shilimkar, Santosh
2012-01-31 18:27                                         ` Nicolas Pitre
2012-01-31 18:27                                           ` Nicolas Pitre
2012-02-01  7:12                                           ` Shilimkar, Santosh
2012-02-01  7:12                                             ` Shilimkar, Santosh
2012-01-17 14:18                     ` Grazvydas Ignotas
2012-01-17 14:18                       ` Grazvydas Ignotas
2012-01-17 13:41                 ` Catalin Marinas
2012-01-17 13:41                   ` Catalin Marinas
2012-01-17 13:54                   ` Aneesh V
2012-01-17 13:54                     ` Aneesh V
2012-01-17 14:23                   ` Måns Rullgård
2012-01-17 14:23                     ` Måns Rullgård
2012-01-17 12:01           ` Aneesh V
2012-01-17 12:01             ` Aneesh V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F15692D.4070100@ti.com \
    --to=aneesh@ti.com \
    --cc=catalin.marinas@arm.com \
    --cc=jw@terrafix.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.