* [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page
@ 2012-01-09 12:24 Prabhakar Kushwaha
2012-01-10 1:10 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Prabhakar Kushwaha @ 2012-01-09 12:24 UTC (permalink / raw)
To: linuxppc-dev, linux-mtd; +Cc: scottwood, Poonam Aggrwal, Prabhakar Kushwaha
1) OOB area should be updated irrespective of NAND page size. Earlier it was
updated only for 512byte NAND page.
2) During OOB update fbcr should be equal to OOB size.
Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
This patch is created on top of IFC driver patch (already floated in mailing
list). Please find their link:
http://patchwork.ozlabs.org/patch/133315/
http://patchwork.ozlabs.org/patch/133316/
Tested on P1010RDB
Changes for v2: Incorporated Scott's comments
- Added missed NAND_CMD_READOOB
- Updated function as per Scott's advice
drivers/mtd/nand/fsl_ifc_nand.c | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index c0529ea..52bd706d 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -440,22 +440,19 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
out_be32(&ifc->ifc_nand.nand_fir1,
(IFC_FIR_OP_CW1 << IFC_NAND_FIR1_OP5_SHIFT));
- if (column >= mtd->writesize) {
- /* OOB area --> READOOB */
- column -= mtd->writesize;
- nand_fcr0 |= NAND_CMD_READOOB <<
- IFC_NAND_FCR0_CMD0_SHIFT;
- ifc_nand_ctrl->oob = 1;
- } else if (column < 256)
- /* First 256 bytes --> READ0 */
+ if (column >= mtd->writesize)
nand_fcr0 |=
- NAND_CMD_READ0 << IFC_NAND_FCR0_CMD0_SHIFT;
+ NAND_CMD_READOOB << IFC_NAND_FCR0_CMD0_SHIFT;
else
- /* Second 256 bytes --> READ1 */
nand_fcr0 |=
- NAND_CMD_READ1 << IFC_NAND_FCR0_CMD0_SHIFT;
+ NAND_CMD_READ0 << IFC_NAND_FCR0_CMD0_SHIFT;
}
+ if (column >= mtd->writesize) {
+ /* OOB area --> READOOB */
+ column -= mtd->writesize;
+ ifc_nand_ctrl->oob = 1;
+ }
out_be32(&ifc->ifc_nand.nand_fcr0, nand_fcr0);
set_addr(mtd, column, page_addr, ifc_nand_ctrl->oob);
return;
@@ -466,7 +463,7 @@ static void fsl_ifc_cmdfunc(struct mtd_info *mtd, unsigned int command,
int full_page;
if (ifc_nand_ctrl->oob) {
out_be32(&ifc->ifc_nand.nand_fbcr,
- ifc_nand_ctrl->index);
+ ifc_nand_ctrl->index - ifc_nand_ctrl->column);
full_page = 0;
} else {
out_be32(&ifc->ifc_nand.nand_fbcr, 0);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page
2012-01-09 12:24 [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page Prabhakar Kushwaha
@ 2012-01-10 1:10 ` Scott Wood
2012-01-17 18:57 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2012-01-10 1:10 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: linux-mtd, linuxppc-dev, Poonam Aggrwal
On 01/09/2012 06:24 AM, Prabhakar Kushwaha wrote:
> 1) OOB area should be updated irrespective of NAND page size. Earlier it was
> updated only for 512byte NAND page.
>
> 2) During OOB update fbcr should be equal to OOB size.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
>
> This patch is created on top of IFC driver patch (already floated in mailing
> list). Please find their link:
> http://patchwork.ozlabs.org/patch/133315/
> http://patchwork.ozlabs.org/patch/133316/
Looks good.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page
2012-01-10 1:10 ` Scott Wood
@ 2012-01-17 18:57 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2012-01-17 18:57 UTC (permalink / raw)
To: Scott Wood; +Cc: Poonam Aggrwal, linuxppc-dev, linux-mtd, Prabhakar Kushwaha
On Jan 9, 2012, at 7:10 PM, Scott Wood wrote:
> On 01/09/2012 06:24 AM, Prabhakar Kushwaha wrote:
>> 1) OOB area should be updated irrespective of NAND page size. Earlier it was
>> updated only for 512byte NAND page.
>>
>> 2) During OOB update fbcr should be equal to OOB size.
>>
>> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
>>
>> This patch is created on top of IFC driver patch (already floated in mailing
>> list). Please find their link:
>> http://patchwork.ozlabs.org/patch/133315/
>> http://patchwork.ozlabs.org/patch/133316/
>
> Looks good.
>
> -Scott
Can we not merge all these into one updated IFC NAND patch?
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page
@ 2012-01-17 18:57 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2012-01-17 18:57 UTC (permalink / raw)
To: Scott Wood; +Cc: Poonam Aggrwal, linuxppc-dev, linux-mtd, Prabhakar Kushwaha
On Jan 9, 2012, at 7:10 PM, Scott Wood wrote:
> On 01/09/2012 06:24 AM, Prabhakar Kushwaha wrote:
>> 1) OOB area should be updated irrespective of NAND page size. Earlier =
it was
>> updated only for 512byte NAND page.
>>=20
>> 2) During OOB update fbcr should be equal to OOB size.
>>=20
>> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git =
(branch next)
>>=20
>> This patch is created on top of IFC driver patch (already floated in =
mailing
>> list). Please find their link:
>> http://patchwork.ozlabs.org/patch/133315/
>> http://patchwork.ozlabs.org/patch/133316/
>=20
> Looks good.
>=20
> -Scott
Can we not merge all these into one updated IFC NAND patch?
- k=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page
2012-01-17 18:57 ` Kumar Gala
(?)
@ 2012-01-17 19:10 ` Scott Wood
-1 siblings, 0 replies; 5+ messages in thread
From: Scott Wood @ 2012-01-17 19:10 UTC (permalink / raw)
To: Kumar Gala; +Cc: Poonam Aggrwal, linuxppc-dev, linux-mtd, Prabhakar Kushwaha
On 01/17/2012 12:57 PM, Kumar Gala wrote:
>
> On Jan 9, 2012, at 7:10 PM, Scott Wood wrote:
>
>> On 01/09/2012 06:24 AM, Prabhakar Kushwaha wrote:
>>> 1) OOB area should be updated irrespective of NAND page size. Earlier it was
>>> updated only for 512byte NAND page.
>>>
>>> 2) During OOB update fbcr should be equal to OOB size.
>>>
>>> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
>>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>>> ---
>>> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next)
>>>
>>> This patch is created on top of IFC driver patch (already floated in mailing
>>> list). Please find their link:
>>> http://patchwork.ozlabs.org/patch/133315/
>>> http://patchwork.ozlabs.org/patch/133316/
>>
>> Looks good.
>>
>> -Scott
>
> Can we not merge all these into one updated IFC NAND patch?
Sure, once we've agreed on what the right fix is for the is_blank issue
(and I think we're pretty close). It's been useful to see these fixes
as separate patches during the review/iteration phase, though.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-17 19:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 12:24 [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page Prabhakar Kushwaha
2012-01-10 1:10 ` Scott Wood
2012-01-17 18:57 ` Kumar Gala
2012-01-17 18:57 ` Kumar Gala
2012-01-17 19:10 ` Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.