* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-24 9:06 ` Russell King - ARM Linux
0 siblings, 0 replies; 41+ messages in thread
From: Russell King - ARM Linux @ 2012-01-24 9:06 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 24, 2012 at 12:09:04AM -0800, Brian Norris wrote:
> Hi,
>
> On Mon, Jan 23, 2012 at 12:12 AM, Shubhrajyoti D <shubhrajyoti@ti.com> wrote:
> ...
> > ?include/linux/mtd/mtd.h | ? ?6 +++---
> > ?1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 1a81fde..c717bb6 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -427,9 +427,9 @@ static inline int mtd_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> >
> > ?static inline int mtd_suspend(struct mtd_info *mtd)
> > ?{
> > - ? ? ? if (!mtd->suspend)
> > - ? ? ? ? ? ? ? return -EOPNOTSUPP;
> > - ? ? ? return mtd->suspend(mtd);
> > + ? ? ? if (mtd->suspend)
> > + ? ? ? ? ? ? ? return mtd->suspend(mtd);
> > + ? ? ? return 0;
> > ?}
> >
> > ?static inline void mtd_resume(struct mtd_info *mtd)
>
> I believe this fix is already accounted for in Artem Bityutskiy's
> l2-mtd-2.6 repository as:
>
> commit 091a7fe219ee8d3e76be9e02221433af10c6f574
> mtd: fix MTD suspend
> (http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/091a7fe219ee8d3e76be9e02221433af10c6f574)
>
> However, the bug made it into the 3.3 merge window, so shouldn't this
> bugfix be sent upstream immediately?
David is the MTD maintainer, and Artem just helps out. I believe Artem
is waiting for David to finish travelling before asking David (last seen
at Hong Kong airport) to pull these fixes. David in turn will pass them
onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
little early to expect this to be fixed.
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-24 9:06 ` Russell King - ARM Linux
0 siblings, 0 replies; 41+ messages in thread
From: Russell King - ARM Linux @ 2012-01-24 9:06 UTC (permalink / raw)
To: Brian Norris
Cc: Shubhrajyoti D, David Woodhouse, linux-omap, linux-mtd,
linux-arm-kernel, Artem Bityutskiy
On Tue, Jan 24, 2012 at 12:09:04AM -0800, Brian Norris wrote:
> Hi,
>
> On Mon, Jan 23, 2012 at 12:12 AM, Shubhrajyoti D <shubhrajyoti@ti.com> wrote:
> ...
> > include/linux/mtd/mtd.h | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 1a81fde..c717bb6 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -427,9 +427,9 @@ static inline int mtd_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> >
> > static inline int mtd_suspend(struct mtd_info *mtd)
> > {
> > - if (!mtd->suspend)
> > - return -EOPNOTSUPP;
> > - return mtd->suspend(mtd);
> > + if (mtd->suspend)
> > + return mtd->suspend(mtd);
> > + return 0;
> > }
> >
> > static inline void mtd_resume(struct mtd_info *mtd)
>
> I believe this fix is already accounted for in Artem Bityutskiy's
> l2-mtd-2.6 repository as:
>
> commit 091a7fe219ee8d3e76be9e02221433af10c6f574
> mtd: fix MTD suspend
> (http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/091a7fe219ee8d3e76be9e02221433af10c6f574)
>
> However, the bug made it into the 3.3 merge window, so shouldn't this
> bugfix be sent upstream immediately?
David is the MTD maintainer, and Artem just helps out. I believe Artem
is waiting for David to finish travelling before asking David (last seen
at Hong Kong airport) to pull these fixes. David in turn will pass them
onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
little early to expect this to be fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-01-24 9:06 ` Russell King - ARM Linux
(?)
@ 2012-01-25 5:16 ` Brian Norris
-1 siblings, 0 replies; 41+ messages in thread
From: Brian Norris @ 2012-01-25 5:16 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Artem Bityutskiy, linux-mtd, linux-omap, David Woodhouse,
Shubhrajyoti D, linux-arm-kernel
On Tue, Jan 24, 2012 at 1:06 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Jan 24, 2012 at 12:09:04AM -0800, Brian Norris wrote:
>> However, the bug made it into the 3.3 merge window, so shouldn't this
>> bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. David in turn will pass them
> onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Right, thanks for the reality check. I was just ensuring that this
bugfix was on the right track. I probably should have said "in
3.3-rcX", not "immediately."
Regards,
Brian
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-25 5:16 ` Brian Norris
0 siblings, 0 replies; 41+ messages in thread
From: Brian Norris @ 2012-01-25 5:16 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 24, 2012 at 1:06 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Jan 24, 2012 at 12:09:04AM -0800, Brian Norris wrote:
>> However, the bug made it into the 3.3 merge window, so shouldn't this
>> bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. ?I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. ?David in turn will pass them
> onto Linus. ?Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Right, thanks for the reality check. I was just ensuring that this
bugfix was on the right track. I probably should have said "in
3.3-rcX", not "immediately."
Regards,
Brian
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-25 5:16 ` Brian Norris
0 siblings, 0 replies; 41+ messages in thread
From: Brian Norris @ 2012-01-25 5:16 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Shubhrajyoti D, David Woodhouse, linux-omap, linux-mtd,
linux-arm-kernel, Artem Bityutskiy
On Tue, Jan 24, 2012 at 1:06 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Jan 24, 2012 at 12:09:04AM -0800, Brian Norris wrote:
>> However, the bug made it into the 3.3 merge window, so shouldn't this
>> bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. David in turn will pass them
> onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Right, thanks for the reality check. I was just ensuring that this
bugfix was on the right track. I probably should have said "in
3.3-rcX", not "immediately."
Regards,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-01-24 9:06 ` Russell King - ARM Linux
(?)
@ 2012-01-30 11:45 ` Artem Bityutskiy
-1 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-01-30 11:45 UTC (permalink / raw)
To: Russell King - ARM Linux, Rafael J. Wysocki, David Woodhouse
Cc: linux-omap, Brian Norris, linux-mtd, Shubhrajyoti D,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2847 bytes --]
On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > However, the bug made it into the 3.3 merge window, so shouldn't this
> > bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. David in turn will pass them
> onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Hi,
here is the latest version of the fix.
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
Also attached.
From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Mon, 16 Jan 2012 11:07:16 +0200
Subject: [PATCH] mtd: fix MTD suspend
Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
but
the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly
removed
in 'mtd_cls_suspend()'.
This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki <rjw@sisk.pl>.
Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/mtd/mtdcore.c | 2 +-
include/linux/mtd/mtd.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b265188..de96865 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
pm_message_t state)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
- return mtd_suspend(mtd);
+ return mtd ? mtd_suspend(mtd) : 0;
}
static int mtd_cls_resume(struct device *dev)
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 1a81fde..d8c7aad 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
*mtd, loff_t ofs, uint64_t len)
static inline int mtd_suspend(struct mtd_info *mtd)
{
- if (!mtd->suspend)
- return -EOPNOTSUPP;
- return mtd->suspend(mtd);
+ return mtd->suspend ? mtd->suspend(mtd) : 0;
}
static inline void mtd_resume(struct mtd_info *mtd)
--
1.7.7.6
--
Best Regards,
Artem Bityutskiy
[-- Attachment #1.2: 0001-mtd-fix-MTD-suspend.patch --]
[-- Type: text/x-patch, Size: 2094 bytes --]
From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Mon, 16 Jan 2012 11:07:16 +0200
Subject: [PATCH] mtd: fix MTD suspend
Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
1. When the '->suspend' method is not present, we return -EOPNOTSUPP, but
the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly removed
in 'mtd_cls_suspend()'.
This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki <rjw@sisk.pl>.
Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/mtd/mtdcore.c | 2 +-
include/linux/mtd/mtd.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b265188..de96865 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev, pm_message_t state)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
- return mtd_suspend(mtd);
+ return mtd ? mtd_suspend(mtd) : 0;
}
static int mtd_cls_resume(struct device *dev)
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 1a81fde..d8c7aad 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
static inline int mtd_suspend(struct mtd_info *mtd)
{
- if (!mtd->suspend)
- return -EOPNOTSUPP;
- return mtd->suspend(mtd);
+ return mtd->suspend ? mtd->suspend(mtd) : 0;
}
static inline void mtd_resume(struct mtd_info *mtd)
--
1.7.7.6
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 41+ messages in thread* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-30 11:45 ` Artem Bityutskiy
0 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-01-30 11:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > However, the bug made it into the 3.3 merge window, so shouldn't this
> > bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. David in turn will pass them
> onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Hi,
here is the latest version of the fix.
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
Also attached.
>From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Mon, 16 Jan 2012 11:07:16 +0200
Subject: [PATCH] mtd: fix MTD suspend
Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
but
the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly
removed
in 'mtd_cls_suspend()'.
This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki <rjw@sisk.pl>.
Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/mtd/mtdcore.c | 2 +-
include/linux/mtd/mtd.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b265188..de96865 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
pm_message_t state)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
- return mtd_suspend(mtd);
+ return mtd ? mtd_suspend(mtd) : 0;
}
static int mtd_cls_resume(struct device *dev)
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 1a81fde..d8c7aad 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
*mtd, loff_t ofs, uint64_t len)
static inline int mtd_suspend(struct mtd_info *mtd)
{
- if (!mtd->suspend)
- return -EOPNOTSUPP;
- return mtd->suspend(mtd);
+ return mtd->suspend ? mtd->suspend(mtd) : 0;
}
static inline void mtd_resume(struct mtd_info *mtd)
--
1.7.7.6
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mtd-fix-MTD-suspend.patch
Type: text/x-patch
Size: 2094 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120130/70d913c5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120130/70d913c5/attachment.sig>
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-30 11:45 ` Artem Bityutskiy
0 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-01-30 11:45 UTC (permalink / raw)
To: Russell King - ARM Linux, Rafael J. Wysocki, David Woodhouse
Cc: Brian Norris, Shubhrajyoti D, linux-omap, linux-mtd,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2847 bytes --]
On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > However, the bug made it into the 3.3 merge window, so shouldn't this
> > bugfix be sent upstream immediately?
>
> David is the MTD maintainer, and Artem just helps out. I believe Artem
> is waiting for David to finish travelling before asking David (last seen
> at Hong Kong airport) to pull these fixes. David in turn will pass them
> onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> little early to expect this to be fixed.
Hi,
here is the latest version of the fix.
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
Also attached.
From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Mon, 16 Jan 2012 11:07:16 +0200
Subject: [PATCH] mtd: fix MTD suspend
Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
but
the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly
removed
in 'mtd_cls_suspend()'.
This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki <rjw@sisk.pl>.
Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/mtd/mtdcore.c | 2 +-
include/linux/mtd/mtd.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b265188..de96865 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
pm_message_t state)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
- return mtd_suspend(mtd);
+ return mtd ? mtd_suspend(mtd) : 0;
}
static int mtd_cls_resume(struct device *dev)
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 1a81fde..d8c7aad 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
*mtd, loff_t ofs, uint64_t len)
static inline int mtd_suspend(struct mtd_info *mtd)
{
- if (!mtd->suspend)
- return -EOPNOTSUPP;
- return mtd->suspend(mtd);
+ return mtd->suspend ? mtd->suspend(mtd) : 0;
}
static inline void mtd_resume(struct mtd_info *mtd)
--
1.7.7.6
--
Best Regards,
Artem Bityutskiy
[-- Attachment #1.2: 0001-mtd-fix-MTD-suspend.patch --]
[-- Type: text/x-patch, Size: 2094 bytes --]
From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Date: Mon, 16 Jan 2012 11:07:16 +0200
Subject: [PATCH] mtd: fix MTD suspend
Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
1. When the '->suspend' method is not present, we return -EOPNOTSUPP, but
the callers of 'mtd_suspend()' expects 0 instead.
2. Checking of the 'mtd' parameter against NULL has been incorrectly removed
in 'mtd_cls_suspend()'.
This patch fixes the breakages. This has been found, analyzed, reported
and tested by Rafael J. Wysocki <rjw@sisk.pl>.
Note, this patch is not needed in the stable tree because it causes a
regression introduced during the v3.3 merge window.
Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/mtd/mtdcore.c | 2 +-
include/linux/mtd/mtd.h | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index b265188..de96865 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev, pm_message_t state)
{
struct mtd_info *mtd = dev_get_drvdata(dev);
- return mtd_suspend(mtd);
+ return mtd ? mtd_suspend(mtd) : 0;
}
static int mtd_cls_resume(struct device *dev)
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 1a81fde..d8c7aad 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
static inline int mtd_suspend(struct mtd_info *mtd)
{
- if (!mtd->suspend)
- return -EOPNOTSUPP;
- return mtd->suspend(mtd);
+ return mtd->suspend ? mtd->suspend(mtd) : 0;
}
static inline void mtd_resume(struct mtd_info *mtd)
--
1.7.7.6
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-01-30 11:45 ` Artem Bityutskiy
(?)
@ 2012-01-30 22:58 ` Rafael J. Wysocki
-1 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-01-30 22:58 UTC (permalink / raw)
To: dedekind1
Cc: Brian Norris, Russell King - ARM Linux, linux-mtd, linux-omap,
David Woodhouse, Shubhrajyoti D, linux-arm-kernel
On Monday, January 30, 2012, Artem Bityutskiy wrote:
> On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > > However, the bug made it into the 3.3 merge window, so shouldn't this
> > > bugfix be sent upstream immediately?
> >
> > David is the MTD maintainer, and Artem just helps out. I believe Artem
> > is waiting for David to finish travelling before asking David (last seen
> > at Hong Kong airport) to pull these fixes. David in turn will pass them
> > onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> > little early to expect this to be fixed.
>
> Hi,
>
> here is the latest version of the fix.
>
> http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
>
> Also attached.
>
> From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Date: Mon, 16 Jan 2012 11:07:16 +0200
> Subject: [PATCH] mtd: fix MTD suspend
>
> Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
> 079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
>
> 1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
> but
> the callers of 'mtd_suspend()' expects 0 instead.
> 2. Checking of the 'mtd' parameter against NULL has been incorrectly
> removed
> in 'mtd_cls_suspend()'.
>
> This patch fixes the breakages. This has been found, analyzed, reported
> and tested by Rafael J. Wysocki <rjw@sisk.pl>.
>
> Note, this patch is not needed in the stable tree because it causes a
> regression introduced during the v3.3 merge window.
>
> Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thanks, but is anyone actually going to push it to Linus any time soon?
If not, then I can do that through the linux-pm tree. I'll be sending
at least one more pull request with fixes for v3.3.
Thanks,
Rafael
> ---
> drivers/mtd/mtdcore.c | 2 +-
> include/linux/mtd/mtd.h | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index b265188..de96865 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
> pm_message_t state)
> {
> struct mtd_info *mtd = dev_get_drvdata(dev);
>
> - return mtd_suspend(mtd);
> + return mtd ? mtd_suspend(mtd) : 0;
> }
>
> static int mtd_cls_resume(struct device *dev)
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 1a81fde..d8c7aad 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
> *mtd, loff_t ofs, uint64_t len)
>
> static inline int mtd_suspend(struct mtd_info *mtd)
> {
> - if (!mtd->suspend)
> - return -EOPNOTSUPP;
> - return mtd->suspend(mtd);
> + return mtd->suspend ? mtd->suspend(mtd) : 0;
> }
>
> static inline void mtd_resume(struct mtd_info *mtd)
>
^ permalink raw reply [flat|nested] 41+ messages in thread* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-30 22:58 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-01-30 22:58 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, January 30, 2012, Artem Bityutskiy wrote:
> On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > > However, the bug made it into the 3.3 merge window, so shouldn't this
> > > bugfix be sent upstream immediately?
> >
> > David is the MTD maintainer, and Artem just helps out. I believe Artem
> > is waiting for David to finish travelling before asking David (last seen
> > at Hong Kong airport) to pull these fixes. David in turn will pass them
> > onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> > little early to expect this to be fixed.
>
> Hi,
>
> here is the latest version of the fix.
>
> http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
>
> Also attached.
>
> From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Date: Mon, 16 Jan 2012 11:07:16 +0200
> Subject: [PATCH] mtd: fix MTD suspend
>
> Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
> 079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
>
> 1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
> but
> the callers of 'mtd_suspend()' expects 0 instead.
> 2. Checking of the 'mtd' parameter against NULL has been incorrectly
> removed
> in 'mtd_cls_suspend()'.
>
> This patch fixes the breakages. This has been found, analyzed, reported
> and tested by Rafael J. Wysocki <rjw@sisk.pl>.
>
> Note, this patch is not needed in the stable tree because it causes a
> regression introduced during the v3.3 merge window.
>
> Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thanks, but is anyone actually going to push it to Linus any time soon?
If not, then I can do that through the linux-pm tree. I'll be sending
at least one more pull request with fixes for v3.3.
Thanks,
Rafael
> ---
> drivers/mtd/mtdcore.c | 2 +-
> include/linux/mtd/mtd.h | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index b265188..de96865 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
> pm_message_t state)
> {
> struct mtd_info *mtd = dev_get_drvdata(dev);
>
> - return mtd_suspend(mtd);
> + return mtd ? mtd_suspend(mtd) : 0;
> }
>
> static int mtd_cls_resume(struct device *dev)
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 1a81fde..d8c7aad 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
> *mtd, loff_t ofs, uint64_t len)
>
> static inline int mtd_suspend(struct mtd_info *mtd)
> {
> - if (!mtd->suspend)
> - return -EOPNOTSUPP;
> - return mtd->suspend(mtd);
> + return mtd->suspend ? mtd->suspend(mtd) : 0;
> }
>
> static inline void mtd_resume(struct mtd_info *mtd)
>
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-01-30 22:58 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-01-30 22:58 UTC (permalink / raw)
To: dedekind1
Cc: Russell King - ARM Linux, David Woodhouse, Brian Norris,
Shubhrajyoti D, linux-omap, linux-mtd, linux-arm-kernel
On Monday, January 30, 2012, Artem Bityutskiy wrote:
> On Tue, 2012-01-24 at 09:06 +0000, Russell King - ARM Linux wrote:
> > > However, the bug made it into the 3.3 merge window, so shouldn't this
> > > bugfix be sent upstream immediately?
> >
> > David is the MTD maintainer, and Artem just helps out. I believe Artem
> > is waiting for David to finish travelling before asking David (last seen
> > at Hong Kong airport) to pull these fixes. David in turn will pass them
> > onto Linus. Plus, Linus only started adding to -rc1 yesterday, so its a
> > little early to expect this to be fixed.
>
> Hi,
>
> here is the latest version of the fix.
>
> http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/283d43b9ce2952535aa89c0195085e2a1b7e5fce
>
> Also attached.
>
> From 283d43b9ce2952535aa89c0195085e2a1b7e5fce Mon Sep 17 00:00:00 2001
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Date: Mon, 16 Jan 2012 11:07:16 +0200
> Subject: [PATCH] mtd: fix MTD suspend
>
> Commits 3fe4bae88460869a8e553397cd9057a4ee7ca341 and
> 079c985e7a6f4ce60f931cebfdd5ee3c3 broke MTD suspend in 2 ways:
>
> 1. When the '->suspend' method is not present, we return -EOPNOTSUPP,
> but
> the callers of 'mtd_suspend()' expects 0 instead.
> 2. Checking of the 'mtd' parameter against NULL has been incorrectly
> removed
> in 'mtd_cls_suspend()'.
>
> This patch fixes the breakages. This has been found, analyzed, reported
> and tested by Rafael J. Wysocki <rjw@sisk.pl>.
>
> Note, this patch is not needed in the stable tree because it causes a
> regression introduced during the v3.3 merge window.
>
> Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Rafael J. Wysocki <rjw@sisk.pl>
> Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thanks, but is anyone actually going to push it to Linus any time soon?
If not, then I can do that through the linux-pm tree. I'll be sending
at least one more pull request with fixes for v3.3.
Thanks,
Rafael
> ---
> drivers/mtd/mtdcore.c | 2 +-
> include/linux/mtd/mtd.h | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index b265188..de96865 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -119,7 +119,7 @@ static int mtd_cls_suspend(struct device *dev,
> pm_message_t state)
> {
> struct mtd_info *mtd = dev_get_drvdata(dev);
>
> - return mtd_suspend(mtd);
> + return mtd ? mtd_suspend(mtd) : 0;
> }
>
> static int mtd_cls_resume(struct device *dev)
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 1a81fde..d8c7aad 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -427,9 +427,7 @@ static inline int mtd_is_locked(struct mtd_info
> *mtd, loff_t ofs, uint64_t len)
>
> static inline int mtd_suspend(struct mtd_info *mtd)
> {
> - if (!mtd->suspend)
> - return -EOPNOTSUPP;
> - return mtd->suspend(mtd);
> + return mtd->suspend ? mtd->suspend(mtd) : 0;
> }
>
> static inline void mtd_resume(struct mtd_info *mtd)
>
^ permalink raw reply [flat|nested] 41+ messages in thread* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-01-30 22:58 ` Rafael J. Wysocki
(?)
@ 2012-02-02 11:43 ` Artem Bityutskiy
-1 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-02-02 11:43 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Brian Norris, Russell King - ARM Linux, linux-mtd, linux-omap,
David Woodhouse, Shubhrajyoti D, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> Thanks, but is anyone actually going to push it to Linus any time soon?
I agree, but I am not the maintainer so cannot answer. David Woodhouse
is aware of this, but I do not know when he gonna send the pull request.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 11:43 ` Artem Bityutskiy
0 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-02-02 11:43 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> Thanks, but is anyone actually going to push it to Linus any time soon?
I agree, but I am not the maintainer so cannot answer. David Woodhouse
is aware of this, but I do not know when he gonna send the pull request.
--
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120202/ffee2351/attachment.sig>
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 11:43 ` Artem Bityutskiy
0 siblings, 0 replies; 41+ messages in thread
From: Artem Bityutskiy @ 2012-02-02 11:43 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Russell King - ARM Linux, David Woodhouse, Brian Norris,
Shubhrajyoti D, linux-omap, linux-mtd, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> Thanks, but is anyone actually going to push it to Linus any time soon?
I agree, but I am not the maintainer so cannot answer. David Woodhouse
is aware of this, but I do not know when he gonna send the pull request.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-02-02 11:43 ` Artem Bityutskiy
(?)
@ 2012-02-02 18:40 ` Rafael J. Wysocki
-1 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 18:40 UTC (permalink / raw)
To: dedekind1, David Woodhouse
Cc: Brian Norris, Russell King - ARM Linux, linux-mtd, linux-omap,
Shubhrajyoti D, linux-arm-kernel
On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > Thanks, but is anyone actually going to push it to Linus any time soon?
>
> I agree, but I am not the maintainer so cannot answer. David Woodhouse
> is aware of this, but I do not know when he gonna send the pull request.
Well, the problem is being reported by more and more people, so I'd
like to push the fix quickly.
David, please let me know if you don't want me to include the $subject patch
into the next PM fixes pull request. If I don't hear from you, I'll push it
next week for -rc4.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 18:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 18:40 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > Thanks, but is anyone actually going to push it to Linus any time soon?
>
> I agree, but I am not the maintainer so cannot answer. David Woodhouse
> is aware of this, but I do not know when he gonna send the pull request.
Well, the problem is being reported by more and more people, so I'd
like to push the fix quickly.
David, please let me know if you don't want me to include the $subject patch
into the next PM fixes pull request. If I don't hear from you, I'll push it
next week for -rc4.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 18:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 18:40 UTC (permalink / raw)
To: dedekind1, David Woodhouse
Cc: Russell King - ARM Linux, Brian Norris, Shubhrajyoti D,
linux-omap, linux-mtd, linux-arm-kernel
On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > Thanks, but is anyone actually going to push it to Linus any time soon?
>
> I agree, but I am not the maintainer so cannot answer. David Woodhouse
> is aware of this, but I do not know when he gonna send the pull request.
Well, the problem is being reported by more and more people, so I'd
like to push the fix quickly.
David, please let me know if you don't want me to include the $subject patch
into the next PM fixes pull request. If I don't hear from you, I'll push it
next week for -rc4.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-02-02 18:40 ` Rafael J. Wysocki
(?)
@ 2012-02-02 20:21 ` Russell King - ARM Linux
-1 siblings, 0 replies; 41+ messages in thread
From: Russell King - ARM Linux @ 2012-02-02 20:21 UTC (permalink / raw)
To: Rafael J. Wysocki, David Woodhouse
Cc: Brian Norris, dedekind1, linux-mtd, linux-omap, Shubhrajyoti D,
linux-arm-kernel
On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > Thanks, but is anyone actually going to push it to Linus any time soon?
> >
> > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > is aware of this, but I do not know when he gonna send the pull request.
>
> Well, the problem is being reported by more and more people, so I'd
> like to push the fix quickly.
>
> David, please let me know if you don't want me to include the $subject patch
> into the next PM fixes pull request. If I don't hear from you, I'll push it
> next week for -rc4.
I too have it in my tree as a patch which Artem sent me, as it's rather
fundamental to not oopsing the kernel when you suspend/resume on any ARM
platform.
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 20:21 ` Russell King - ARM Linux
0 siblings, 0 replies; 41+ messages in thread
From: Russell King - ARM Linux @ 2012-02-02 20:21 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > Thanks, but is anyone actually going to push it to Linus any time soon?
> >
> > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > is aware of this, but I do not know when he gonna send the pull request.
>
> Well, the problem is being reported by more and more people, so I'd
> like to push the fix quickly.
>
> David, please let me know if you don't want me to include the $subject patch
> into the next PM fixes pull request. If I don't hear from you, I'll push it
> next week for -rc4.
I too have it in my tree as a patch which Artem sent me, as it's rather
fundamental to not oopsing the kernel when you suspend/resume on any ARM
platform.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 20:21 ` Russell King - ARM Linux
0 siblings, 0 replies; 41+ messages in thread
From: Russell King - ARM Linux @ 2012-02-02 20:21 UTC (permalink / raw)
To: Rafael J. Wysocki, David Woodhouse
Cc: dedekind1, Brian Norris, Shubhrajyoti D, linux-omap, linux-mtd,
linux-arm-kernel
On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > Thanks, but is anyone actually going to push it to Linus any time soon?
> >
> > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > is aware of this, but I do not know when he gonna send the pull request.
>
> Well, the problem is being reported by more and more people, so I'd
> like to push the fix quickly.
>
> David, please let me know if you don't want me to include the $subject patch
> into the next PM fixes pull request. If I don't hear from you, I'll push it
> next week for -rc4.
I too have it in my tree as a patch which Artem sent me, as it's rather
fundamental to not oopsing the kernel when you suspend/resume on any ARM
platform.
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
2012-02-02 20:21 ` Russell King - ARM Linux
(?)
@ 2012-02-02 20:36 ` Rafael J. Wysocki
-1 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 20:36 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Brian Norris, dedekind1, linux-mtd, linux-omap, David Woodhouse,
Shubhrajyoti D, linux-arm-kernel
On Thursday, February 02, 2012, Russell King - ARM Linux wrote:
> On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > > Thanks, but is anyone actually going to push it to Linus any time soon?
> > >
> > > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > > is aware of this, but I do not know when he gonna send the pull request.
> >
> > Well, the problem is being reported by more and more people, so I'd
> > like to push the fix quickly.
> >
> > David, please let me know if you don't want me to include the $subject patch
> > into the next PM fixes pull request. If I don't hear from you, I'll push it
> > next week for -rc4.
>
> I too have it in my tree as a patch which Artem sent me, as it's rather
> fundamental to not oopsing the kernel when you suspend/resume on any ARM
> platform.
It actually affects everyone using MTD and suspend (not only ARM) and that's
why I thought I'd take it, but I'm fine with any other resolution as long as
the patch goes to Linus before 3.3-final.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread
* [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 20:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 20:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday, February 02, 2012, Russell King - ARM Linux wrote:
> On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > > Thanks, but is anyone actually going to push it to Linus any time soon?
> > >
> > > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > > is aware of this, but I do not know when he gonna send the pull request.
> >
> > Well, the problem is being reported by more and more people, so I'd
> > like to push the fix quickly.
> >
> > David, please let me know if you don't want me to include the $subject patch
> > into the next PM fixes pull request. If I don't hear from you, I'll push it
> > next week for -rc4.
>
> I too have it in my tree as a patch which Artem sent me, as it's rather
> fundamental to not oopsing the kernel when you suspend/resume on any ARM
> platform.
It actually affects everyone using MTD and suspend (not only ARM) and that's
why I thought I'd take it, but I'm fine with any other resolution as long as
the patch goes to Linus before 3.3-final.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread
* Re: [PATCH RFC 2/2] mtd : Make the mtd_suspend return 0 if the suspend is not implemented
@ 2012-02-02 20:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 41+ messages in thread
From: Rafael J. Wysocki @ 2012-02-02 20:36 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: David Woodhouse, dedekind1, Brian Norris, Shubhrajyoti D,
linux-omap, linux-mtd, linux-arm-kernel
On Thursday, February 02, 2012, Russell King - ARM Linux wrote:
> On Thu, Feb 02, 2012 at 07:40:26PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, February 02, 2012, Artem Bityutskiy wrote:
> > > On Mon, 2012-01-30 at 23:58 +0100, Rafael J. Wysocki wrote:
> > > > Thanks, but is anyone actually going to push it to Linus any time soon?
> > >
> > > I agree, but I am not the maintainer so cannot answer. David Woodhouse
> > > is aware of this, but I do not know when he gonna send the pull request.
> >
> > Well, the problem is being reported by more and more people, so I'd
> > like to push the fix quickly.
> >
> > David, please let me know if you don't want me to include the $subject patch
> > into the next PM fixes pull request. If I don't hear from you, I'll push it
> > next week for -rc4.
>
> I too have it in my tree as a patch which Artem sent me, as it's rather
> fundamental to not oopsing the kernel when you suspend/resume on any ARM
> platform.
It actually affects everyone using MTD and suspend (not only ARM) and that's
why I thought I'd take it, but I'm fine with any other resolution as long as
the patch goes to Linus before 3.3-final.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 41+ messages in thread