From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
balbi@ti.com, nm@ti.com, Kevin Hilman <khilman@ti.com>,
Paul Walmsley <paul@pwsan.com>, Jean Pihet <j-pihet@ti.com>,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq
Date: Wed, 25 Jan 2012 21:29:49 +0300 [thread overview]
Message-ID: <4F204A1D.4090005@ru.mvista.com> (raw)
In-Reply-To: <1327504583-13408-5-git-send-email-j-pihet@ti.com>
On 01/25/2012 06:16 PM, Jean Pihet wrote:
> From: Colin Cross<ccross@android.com>
> Running without smartreflex for any significant time (on the order
> of seconds) is unsafe and can cause thermal runaway. Move
> smartreflex suspend into suspend_noirq, so it happens as late as
> possible. This prevents hangs that occur in a driver suspend
> handler from running without smartreflex enabled. It will also
> reduce power used during suspend and resume, as the voltages will
> be lowered.
> May also indirectly fix imprecise external aborts seen during
> suspend, which could be caused by calls to sr_disable racing
> from calls to dvfs_scale and omap_sr_disable.
> Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da
This line has no place in the upstream commit. Please remove.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq
Date: Wed, 25 Jan 2012 21:29:49 +0300 [thread overview]
Message-ID: <4F204A1D.4090005@ru.mvista.com> (raw)
In-Reply-To: <1327504583-13408-5-git-send-email-j-pihet@ti.com>
On 01/25/2012 06:16 PM, Jean Pihet wrote:
> From: Colin Cross<ccross@android.com>
> Running without smartreflex for any significant time (on the order
> of seconds) is unsafe and can cause thermal runaway. Move
> smartreflex suspend into suspend_noirq, so it happens as late as
> possible. This prevents hangs that occur in a driver suspend
> handler from running without smartreflex enabled. It will also
> reduce power used during suspend and resume, as the voltages will
> be lowered.
> May also indirectly fix imprecise external aborts seen during
> suspend, which could be caused by calls to sr_disable racing
> from calls to dvfs_scale and omap_sr_disable.
> Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da
This line has no place in the upstream commit. Please remove.
WBR, Sergei
next prev parent reply other threads:[~2012-01-25 17:30 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 15:16 [PATCH 00/21] OMAP3+: SR: bugfixes Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 01/21] OMAP3+: SR Layer Cleanup [V4] Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 02/21] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 03/21] OMAP3+: PM: SR: add suspend/resume handlers Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 18:29 ` Sergei Shtylyov [this message]
2012-01-25 18:29 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 05/21] Revert "OMAP3+: PM: SR: add suspend/resume handlers" Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 17:53 ` Cousson, Benoit
2012-01-25 17:53 ` Cousson, Benoit
2012-01-25 18:13 ` Jean Pihet
2012-01-25 18:13 ` Jean Pihet
2012-01-25 18:25 ` Cousson, Benoit
2012-01-25 18:25 ` Cousson, Benoit
2012-01-25 18:49 ` Kevin Hilman
2012-01-25 18:49 ` Kevin Hilman
2012-01-25 21:29 ` Menon, Nishanth
2012-01-25 21:29 ` Menon, Nishanth
2012-01-26 7:31 ` Jean Pihet
2012-01-26 7:31 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 06/21] OMAP3+: Smartreflex: fix err interrupt disable sequence Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:26 ` Sergei Shtylyov
2012-01-26 11:26 ` Sergei Shtylyov
2012-01-31 10:06 ` Jean Pihet
2012-01-31 10:06 ` Jean Pihet
2012-01-31 11:37 ` Sergei Shtylyov
2012-01-31 11:37 ` Sergei Shtylyov
2012-01-31 13:39 ` Jean Pihet
2012-01-31 13:39 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 08/21] OMAP3+: Smartreflex: Add a shutdown hook Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:21 ` Sergei Shtylyov
2012-01-26 11:21 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 09/21] OMAP3+: Smartreflex: Fix status masking in ERRCONFIG register Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:28 ` Sergei Shtylyov
2012-01-26 11:28 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 10/21] OMAP3+: Smartreflex: clear ERRCONFIG_VPBOUNDINTST only on a need Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:29 ` Sergei Shtylyov
2012-01-26 11:29 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 11/21] OMAP3: hwmod: add SmartReflex IRQs Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:30 ` Sergei Shtylyov
2012-01-26 11:30 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 12/21] OMAP3+: SR: introduce class init,deinit and priv data Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:31 ` Sergei Shtylyov
2012-01-26 11:31 ` Sergei Shtylyov
2012-01-25 15:16 ` [PATCH 13/21] OMAP3+: SR: introduce notifiers flags Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 14/21] OMAP3+: SR: introduce notifier_control Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 15/21] OMAP3+: SR: disable spamming interrupts Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 16/21] OMAP3+: SR: introduce class private data per voltage domain Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 17/21] OMAP3430: SR: class3: restrict CPU to run on Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-26 11:33 ` Sergei Shtylyov
2012-01-26 11:33 ` Sergei Shtylyov
2012-01-26 12:22 ` Jean Pihet
2012-01-26 12:22 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 18/21] arm: omap: smartreflex: add missing platform_set_drvdata() Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 19/21] arm: omap: smartreflex: move late_initcall() closer to its argument Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 20/21] arm: omap: smartreflex: clean ups all over Jean Pihet
2012-01-25 15:16 ` Jean Pihet
2012-01-25 15:16 ` [PATCH 21/21] arm: omap: smartreflex: micro-optimization for sanity check Jean Pihet
2012-01-25 15:16 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F204A1D.4090005@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=balbi@ti.com \
--cc=ccross@android.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.