From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h
Date: Fri, 27 Jan 2012 15:43:42 +0100 [thread overview]
Message-ID: <4F22B81E.1030407@redhat.com> (raw)
In-Reply-To: <1327667215-5411-5-git-send-email-stefano.stabellini@eu.citrix.com>
On 01/27/2012 01:26 PM, Stefano Stabellini wrote:
> There is no reason why the minimum timeout should be 1sec, it could
> easily be 1h and we would save lots of cpu cycles.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
> qemu-timer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 648db1d..b792a32 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -844,6 +844,6 @@ fail:
>
> int qemu_calculate_timeout(void)
> {
> - return 1000;
> + return 1000*60*60;
> }
>
This might break Windows networking, but I'm going to fix it before 1.1
anyway.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, avi@redhat.com
Subject: Re: [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h
Date: Fri, 27 Jan 2012 15:43:42 +0100 [thread overview]
Message-ID: <4F22B81E.1030407@redhat.com> (raw)
In-Reply-To: <1327667215-5411-5-git-send-email-stefano.stabellini@eu.citrix.com>
On 01/27/2012 01:26 PM, Stefano Stabellini wrote:
> There is no reason why the minimum timeout should be 1sec, it could
> easily be 1h and we would save lots of cpu cycles.
>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
> qemu-timer.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 648db1d..b792a32 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -844,6 +844,6 @@ fail:
>
> int qemu_calculate_timeout(void)
> {
> - return 1000;
> + return 1000*60*60;
> }
>
This might break Windows networking, but I'm going to fix it before 1.1
anyway.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2012-01-27 14:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 12:26 [Qemu-devel] [PATCH v2 0/5] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 1/5] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:41 ` [Qemu-devel] " Paolo Bonzini
2012-01-27 14:41 ` Paolo Bonzini
2012-01-30 11:56 ` [Qemu-devel] " Stefano Stabellini
2012-01-30 11:56 ` Stefano Stabellini
2012-01-30 11:59 ` [Qemu-devel] " Paolo Bonzini
2012-01-30 11:59 ` Paolo Bonzini
2012-01-30 18:53 ` [Qemu-devel] " Stefano Stabellini
2012-01-30 18:53 ` Stefano Stabellini
2012-01-30 19:28 ` [Qemu-devel] " Anthony Liguori
2012-01-30 19:28 ` Anthony Liguori
2012-01-31 7:30 ` [Qemu-devel] " Paolo Bonzini
2012-01-31 7:30 ` Paolo Bonzini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:42 ` [Qemu-devel] " Paolo Bonzini
2012-01-27 14:42 ` Paolo Bonzini
2012-01-27 15:43 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:43 ` Stefano Stabellini
2012-01-27 15:53 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:53 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:43 ` Paolo Bonzini [this message]
2012-01-27 14:43 ` Paolo Bonzini
2012-01-27 15:44 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:44 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F22B81E.1030407@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.