From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock
Date: Mon, 30 Jan 2012 13:28:07 -0600 [thread overview]
Message-ID: <4F26EF47.9090108@codemonkey.ws> (raw)
In-Reply-To: <4F268632.8040801@redhat.com>
On 01/30/2012 05:59 AM, Paolo Bonzini wrote:
> On 01/30/2012 12:56 PM, Stefano Stabellini wrote:
>>> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true.
>>
>> Good point.
>> I should check for rtc_clock == host_clock.
>>
>>> > Why do you need to instantiate an RTC at all?
>> I don't, in fact in previous versions of this patch series I tried to do
>> that but it is difficult and makes the common code worse, so I followed
>> Anthony's suggestion of just disabling the rtc_clock.
>
> I see. It shouldn't surprise you that I completely disagree with Anthony on
> this. :)
Give me some credit at least...
The original patches didn't disable the RTC, it introduced a half-neutered Xen
specific RTC.
My original suggestion (which I still think is the best approach) is to change
the RTC emulation to not use a second timer at all.
Regards,
Anthony Liguori
> Paolo
>
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 2/5] xen: disable rtc_clock
Date: Mon, 30 Jan 2012 13:28:07 -0600 [thread overview]
Message-ID: <4F26EF47.9090108@codemonkey.ws> (raw)
In-Reply-To: <4F268632.8040801@redhat.com>
On 01/30/2012 05:59 AM, Paolo Bonzini wrote:
> On 01/30/2012 12:56 PM, Stefano Stabellini wrote:
>>> > Depending on "-rtc clock=vm" or "-rtc clock=rt", this may not be true.
>>
>> Good point.
>> I should check for rtc_clock == host_clock.
>>
>>> > Why do you need to instantiate an RTC at all?
>> I don't, in fact in previous versions of this patch series I tried to do
>> that but it is difficult and makes the common code worse, so I followed
>> Anthony's suggestion of just disabling the rtc_clock.
>
> I see. It shouldn't surprise you that I completely disagree with Anthony on
> this. :)
Give me some credit at least...
The original patches didn't disable the RTC, it introduced a half-neutered Xen
specific RTC.
My original suggestion (which I still think is the best approach) is to change
the RTC emulation to not use a second timer at all.
Regards,
Anthony Liguori
> Paolo
>
next prev parent reply other threads:[~2012-01-30 19:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 12:26 [Qemu-devel] [PATCH v2 0/5] prevent Qemu from waking up needlessly Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 1/5] xen: do not initialize the interval timer emulator Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:41 ` [Qemu-devel] " Paolo Bonzini
2012-01-27 14:41 ` Paolo Bonzini
2012-01-30 11:56 ` [Qemu-devel] " Stefano Stabellini
2012-01-30 11:56 ` Stefano Stabellini
2012-01-30 11:59 ` [Qemu-devel] " Paolo Bonzini
2012-01-30 11:59 ` Paolo Bonzini
2012-01-30 18:53 ` [Qemu-devel] " Stefano Stabellini
2012-01-30 18:53 ` Stefano Stabellini
2012-01-30 19:28 ` Anthony Liguori [this message]
2012-01-30 19:28 ` Anthony Liguori
2012-01-31 7:30 ` [Qemu-devel] " Paolo Bonzini
2012-01-31 7:30 ` Paolo Bonzini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:42 ` [Qemu-devel] " Paolo Bonzini
2012-01-27 14:42 ` Paolo Bonzini
2012-01-27 15:43 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:43 ` Stefano Stabellini
2012-01-27 15:53 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:53 ` Stefano Stabellini
2012-01-27 12:26 ` [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h Stefano Stabellini
2012-01-27 12:26 ` Stefano Stabellini
2012-01-27 14:43 ` [Qemu-devel] " Paolo Bonzini
2012-01-27 14:43 ` Paolo Bonzini
2012-01-27 15:44 ` [Qemu-devel] " Stefano Stabellini
2012-01-27 15:44 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F26EF47.9090108@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.