* [PATCH] intel: Fix bufmgr_gem->gen for gen > 4
@ 2012-01-30 17:41 Chad Versace
2012-01-30 18:01 ` Eugeni Dodonov
2012-01-30 19:14 ` Eric Anholt
0 siblings, 2 replies; 5+ messages in thread
From: Chad Versace @ 2012-01-30 17:41 UTC (permalink / raw)
To: intel-gfx
If the pci_device's actual gen was > 4, then we stupidly set
bufmgr_gem->gen = 6.
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
---
intel/intel_bufmgr_gem.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 2b4fab1..26e3a5c 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -2321,8 +2321,14 @@ drm_intel_bufmgr_gem_init(int fd, int batch_size)
bufmgr_gem->gen = 3;
else if (IS_GEN4(bufmgr_gem->pci_device))
bufmgr_gem->gen = 4;
- else
+ else if (IS_GEN5(bufmgr_gem->pci_device))
+ bufmgr_gem->gen = 5;
+ else if (IS_GEN6(bufmgr_gem->pci_device))
bufmgr_gem->gen = 6;
+ else if (IS_GEN7(bufmgr_gem->pci_device))
+ bufmgr_gem->gen = 7;
+ else
+ assert(0);
if (IS_GEN3(bufmgr_gem->pci_device) &&
bufmgr_gem->gtt_size > 256*1024*1024) {
--
1.7.7.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] intel: Fix bufmgr_gem->gen for gen > 4
2012-01-30 17:41 [PATCH] intel: Fix bufmgr_gem->gen for gen > 4 Chad Versace
@ 2012-01-30 18:01 ` Eugeni Dodonov
2012-01-30 19:14 ` Eric Anholt
1 sibling, 0 replies; 5+ messages in thread
From: Eugeni Dodonov @ 2012-01-30 18:01 UTC (permalink / raw)
To: Chad Versace; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 497 bytes --]
On Mon, Jan 30, 2012 at 15:41, Chad Versace <chad.versace@linux.intel.com>wrote:
> If the pci_device's actual gen was > 4, then we stupidly set
> bufmgr_gem->gen = 6.
>
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
I was thinking on maybe making this more future-proof to help the possible
>=7 gen devices, but I guess we can add a new check for them when the time
comes.
--
Eugeni Dodonov
<http://eugeni.dodonov.net/>
[-- Attachment #1.2: Type: text/html, Size: 932 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] intel: Fix bufmgr_gem->gen for gen > 4
2012-01-30 17:41 [PATCH] intel: Fix bufmgr_gem->gen for gen > 4 Chad Versace
2012-01-30 18:01 ` Eugeni Dodonov
@ 2012-01-30 19:14 ` Eric Anholt
2012-01-30 21:10 ` Chad Versace
2012-01-31 1:23 ` Ben Widawsky
1 sibling, 2 replies; 5+ messages in thread
From: Eric Anholt @ 2012-01-30 19:14 UTC (permalink / raw)
To: Chad Versace, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 287 bytes --]
On Mon, 30 Jan 2012 09:41:50 -0800, Chad Versace <chad.versace@linux.intel.com> wrote:
> If the pci_device's actual gen was > 4, then we stupidly set
> bufmgr_gem->gen = 6.
Might be worth a note to say that no behavior should change. Still,
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] intel: Fix bufmgr_gem->gen for gen > 4
2012-01-30 19:14 ` Eric Anholt
@ 2012-01-30 21:10 ` Chad Versace
2012-01-31 1:23 ` Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Chad Versace @ 2012-01-30 21:10 UTC (permalink / raw)
To: Eric Anholt; +Cc: intel-gfx
On 01/30/2012 11:14 AM, Eric Anholt wrote:
> On Mon, 30 Jan 2012 09:41:50 -0800, Chad Versace <chad.versace@linux.intel.com> wrote:
>> If the pci_device's actual gen was > 4, then we stupidly set
>> bufmgr_gem->gen = 6.
>
> Might be worth a note to say that no behavior should change. Still,
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
Pushed, with a note about no change in behavior.
----
Chad Versace
chad.versace@linux.intel.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] intel: Fix bufmgr_gem->gen for gen > 4
2012-01-30 19:14 ` Eric Anholt
2012-01-30 21:10 ` Chad Versace
@ 2012-01-31 1:23 ` Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Ben Widawsky @ 2012-01-31 1:23 UTC (permalink / raw)
To: Eric Anholt; +Cc: intel-gfx
On 01/30/12 11:14, Eric Anholt wrote:
> On Mon, 30 Jan 2012 09:41:50 -0800, Chad Versace<chad.versace@linux.intel.com> wrote:
>> If the pci_device's actual gen was> 4, then we stupidly set
>> bufmgr_gem->gen = 6.
>
> Might be worth a note to say that no behavior should change. Still,
>
> Reviewed-by: Eric Anholt<eric@anholt.net>
Right, I'm curious if this fixed anything.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-31 1:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 17:41 [PATCH] intel: Fix bufmgr_gem->gen for gen > 4 Chad Versace
2012-01-30 18:01 ` Eugeni Dodonov
2012-01-30 19:14 ` Eric Anholt
2012-01-30 21:10 ` Chad Versace
2012-01-31 1:23 ` Ben Widawsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.