All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Andreas Färber" <afaerber@suse.de>,
	quintela@redhat.com, "Mitsyanko Igor" <i.mitsyanko@samsung.com>,
	"Developers qemu-devel" <qemu-devel@nongnu.org>,
	"KVM devel mailing list" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31
Date: Tue, 31 Jan 2012 16:12:14 +0100	[thread overview]
Message-ID: <4F2804CE.40407@redhat.com> (raw)
In-Reply-To: <4F27F6CD.1000807@codemonkey.ws>

On 01/31/2012 03:12 PM, Anthony Liguori wrote:
>
> Don't use VMState.  Just open code a save/restore function.  VMState is
> too limited in how it handles complex data structures.
>
> I really believe the only long term solution we're going to get to here
> is something that uses a builder interface (like Visitors).

Visitors for complex data structures still require you separate get/set 
functions.  VMState was created to avoid having to write things twice 
and avoid getting the two out of sync.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Developers qemu-devel" <qemu-devel@nongnu.org>,
	"Mitsyanko Igor" <i.mitsyanko@samsung.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"KVM devel mailing list" <kvm@vger.kernel.org>,
	quintela@redhat.com
Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31
Date: Tue, 31 Jan 2012 16:12:14 +0100	[thread overview]
Message-ID: <4F2804CE.40407@redhat.com> (raw)
In-Reply-To: <4F27F6CD.1000807@codemonkey.ws>

On 01/31/2012 03:12 PM, Anthony Liguori wrote:
>
> Don't use VMState.  Just open code a save/restore function.  VMState is
> too limited in how it handles complex data structures.
>
> I really believe the only long term solution we're going to get to here
> is something that uses a builder interface (like Visitors).

Visitors for complex data structures still require you separate get/set 
functions.  VMState was created to avoid having to write things twice 
and avoid getting the two out of sync.

Paolo

  parent reply	other threads:[~2012-01-31 15:12 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 18:55 KVM call agenda for tuesday 31 Juan Quintela
2012-01-30 18:55 ` [Qemu-devel] " Juan Quintela
2012-01-30 23:41 ` Andreas Färber
2012-01-30 23:41   ` Andreas Färber
2012-01-30 23:53   ` Anthony Liguori
2012-01-30 23:53     ` [Qemu-devel] " Anthony Liguori
2012-01-31  0:37     ` Alexander Graf
2012-01-31  0:37       ` Alexander Graf
2012-01-31 10:49     ` Lluís Vilanova
2012-01-31 13:15     ` Andreas Färber
2012-01-31 13:15       ` Andreas Färber
2012-01-31 14:01       ` Mitsyanko Igor
2012-01-31 14:01         ` Mitsyanko Igor
2012-08-08 16:25         ` Andreas Färber
2012-08-08 16:25           ` Andreas Färber
2012-08-09  7:53           ` Igor Mitsyanko
2012-08-09  7:53             ` Igor Mitsyanko
2012-01-31 14:12       ` Anthony Liguori
2012-01-31 14:12         ` Anthony Liguori
2012-01-31 15:04         ` Michael S. Tsirkin
2012-01-31 15:04           ` [Qemu-devel] " Michael S. Tsirkin
2012-01-31 15:10           ` Michael S. Tsirkin
2012-01-31 15:10             ` [Qemu-devel] " Michael S. Tsirkin
2012-01-31 15:12         ` Paolo Bonzini [this message]
2012-01-31 15:12           ` Paolo Bonzini
2012-02-09 22:23       ` Peter Maydell
2012-02-09 22:23         ` [Qemu-devel] " Peter Maydell
2012-02-09 22:37         ` Anthony Liguori
2012-02-09 22:37           ` Anthony Liguori
2012-02-09 22:42           ` Peter Maydell
2012-02-09 22:42             ` [Qemu-devel] " Peter Maydell
2012-02-09 23:17           ` Andreas Färber
2012-02-09 23:17             ` Andreas Färber
2012-02-09 23:21             ` Alexander Graf
2012-02-09 23:21               ` Alexander Graf
2012-02-21 15:33         ` Peter Maydell
2012-02-21 15:33           ` Peter Maydell
2012-02-22  8:06           ` Mitsyanko Igor
2012-02-22  8:06             ` Mitsyanko Igor
2012-03-05 13:38           ` Igor Mitsyanko
2012-03-05 13:38             ` Igor Mitsyanko
2012-03-05 14:13             ` Avi Kivity
2012-03-05 14:13               ` Avi Kivity
2012-03-05 14:37               ` Igor Mitsyanko
2012-03-05 14:37                 ` Igor Mitsyanko
2012-03-05 15:10                 ` Avi Kivity
2012-03-05 15:10                   ` Avi Kivity
2012-03-05 15:15                   ` Anthony Liguori
2012-03-05 15:15                     ` Anthony Liguori
2012-03-05 15:17                     ` Avi Kivity
2012-03-05 15:17                       ` Avi Kivity
2012-03-05 18:53                       ` Blue Swirl
2012-03-05 18:53                         ` Blue Swirl
2012-03-05 20:58                         ` malc
2012-03-05 20:58                           ` [Qemu-devel] " malc
2012-03-05 15:20                   ` Peter Maydell
2012-03-05 15:20                     ` Peter Maydell
2012-03-05 15:21                     ` Avi Kivity
2012-03-05 15:21                       ` Avi Kivity
2012-03-05 15:27                       ` Peter Maydell
2012-03-05 15:27                         ` Peter Maydell
2012-03-05 15:43                   ` Andreas Färber
2012-03-05 15:43                     ` [Qemu-devel] " Andreas Färber
2012-03-05 15:47                     ` Avi Kivity
2012-03-05 15:47                       ` Avi Kivity
2012-03-05 15:50                     ` Peter Maydell
2012-03-05 15:50                       ` Peter Maydell
2012-03-05 17:27                       ` Avi Kivity
2012-03-05 17:27                         ` Avi Kivity
2012-03-12  9:43           ` Igor Mitsyanko
2012-03-12  9:43             ` Igor Mitsyanko
2012-03-14  9:30             ` Igor Mitsyanko
2012-03-14  9:30               ` Igor Mitsyanko
2012-03-14 10:16             ` Avi Kivity
2012-03-14 10:16               ` Avi Kivity
2012-01-31 13:59   ` Anthony Liguori
2012-01-31 13:59     ` Anthony Liguori
2012-01-31 14:09     ` Avi Kivity
2012-01-31 14:09       ` Avi Kivity
2012-01-31 14:17       ` Anthony Liguori
2012-01-31 14:44         ` Avi Kivity
2012-01-31 16:23     ` Andreas Färber
2012-01-31 16:23       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2804CE.40407@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=i.mitsyanko@samsung.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.