Re: [pull-sys940x 2/4] ranpwd: Add ranpwd recipe

[Darren Hart <dvhart@linux.intel.com>]

On 02/01/2012 02:40 PM, Joshua Lock wrote:
> 
> 
> On 01/02/12 14:26, Darren Hart wrote:
>> ranpwd is used to generate random strings of various types, including
>> passwords, UUIDs, and MAC addresses.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> ---
>>   meta-sys940x/recipes-extended/ranpwd/ranpwd_git.bb |   23 ++++++++++++++++++++
>>   1 files changed, 23 insertions(+), 0 deletions(-)
>>   create mode 100644 meta-sys940x/recipes-extended/ranpwd/ranpwd_git.bb
>>
>> diff --git a/meta-sys940x/recipes-extended/ranpwd/ranpwd_git.bb b/meta-sys940x/recipes-extended/ranpwd/ranpwd_git.bb
>> new file mode 100644
>> index 0000000..66fcc26
>> --- /dev/null
>> +++ b/meta-sys940x/recipes-extended/ranpwd/ranpwd_git.bb
>> @@ -0,0 +1,23 @@
>> +DESCRIPTION = "Random password generator"
>> +#SECTION = "utilities"
> 
> We may as well delete this line, no?

Oops. I didn't intend to leave it commented. I'm also no sure how to
decide which "SECTION" to put it in. Is there some definitive list from
which to select an appropriate SECTION? Uncommented in my local branch
for now.

> 
>> +LICENSE = "GPLv2+"
>> +LIC_FILES_CHKSUM = "file://ranpwd.c;beginline=1;endline=11;md5=0e8585e19117526efedfaeb50c345d7a"
>> +PR = "r0"
>> +
>> +inherit autotools
>> +
>> +SRC_URI = "git://git.zytor.com/utils/ranpwd.git"
>> +SRCREV = "b62aab579e288715b82d5575befaa2b8ff210c2b"
>> +
>> +S=${WORKDIR}/git
> 
> Variable assignments are usually quoted.
> 
> S = "${WORKDIR}/git"
> 

OK, will do.

>> +
>> +do_configure_prepend () {
>> +	if [ ! -e acinclude.m4 -a -e aclocal.m4 ]; then
>> +		cp aclocal.m4 acinclude.m4
>> +	fi
>> +}
>> +
>> +do_install() {
>> +	install -d ${D}/${bindir}
>> +	install -m 0755 ${S}/ranpwd ${D}/${bindir}/ranpwd
>> +}
> 

Thanks for the review.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel