Re: [pull-sys940x 4/4] netbase: Add interfaces with RANDOM_MAC for sys940x* machines

[Darren Hart <dvhart@linux.intel.com>]

On 02/01/2012 03:03 PM, Joshua Lock wrote:
> 
> 
> On 01/02/12 14:52, Joshua Lock wrote:
>>> +++ b/meta-sys940x/recipes-core/netbase/netbase_4.47.bbappend
>>> @@ -0,0 +1,3 @@
>>> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>>> +RDEPENDS_${PN} += "genmac"
>>
>> We can use a MACHINE specific override here, I think.
>>
>> RDEPENDS_${PN}_sys940x += "genmac"
>>
>> Ideally we don't want that interfaces file on non-sys940x machines,
>> perhaps we could name the interfaces file differently and add a
>> do_install_append_sys940x which installs the MACHINE specific interface
>> file?
> 
> In this instance, however, I don't know what would happen if we built 
> netbase with this layer enabled for a different core2 MACHINE and then 
> built for the sys940x....
> 
> I suspect the existing core2 package would be used and think for this 
> approach to work we'd need to mark this recipe MACHINE specific.
> 
> Cheers,
> Joshua

Thanks for catching this. As I understand it, Richard and Joshua have
agreed that netbase should just be MACHINE specific. Joshua has agreed
to prep a patch to this effect, rendering this recipe OK as is.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel