* [patch] usb: dwc3: make dwc3_get_device_id() return the id
@ 2012-02-04 13:37 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2012-02-04 13:37 UTC (permalink / raw)
To: Felipe Balbi
Cc: Greg Kroah-Hartman, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
We always return zero instead of the id we found.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
I don't have this hardware so it's not tested.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 7c9df63..73df745 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -86,7 +86,7 @@ again:
id = -ENOMEM;
}
- return 0;
+ return id;
}
EXPORT_SYMBOL_GPL(dwc3_get_device_id);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
2012-02-04 13:37 ` Dan Carpenter
@ 2012-02-06 6:44 ` Felipe Balbi
-1 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2012-02-06 6:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> We always return zero instead of the id we found.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks
> ---
> I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that
before, thanks ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
@ 2012-02-06 6:44 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2012-02-06 6:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> We always return zero instead of the id we found.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks
> ---
> I don't have this hardware so it's not tested.
This one is so obvious that I can't even believe we haven't seen that
before, thanks ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
2012-02-04 13:37 ` Dan Carpenter
(?)
(?)
@ 2012-02-06 8:09 ` walter harms
-1 siblings, 0 replies; 6+ messages in thread
From: walter harms @ 2012-02-06 8:09 UTC (permalink / raw)
To: kernel-janitors
Am 06.02.2012 07:44, schrieb Felipe Balbi:
> On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
>> We always return zero instead of the id we found.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Applied, thanks
>
>> ---
>> I don't have this hardware so it's not tested.
>
> This one is so obvious that I can't even believe we haven't seen that
> before, thanks ;-)
>
i was wondering why the driver worked at all, do you realy need that ?
re,
wh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
2012-02-04 13:37 ` Dan Carpenter
` (2 preceding siblings ...)
(?)
@ 2012-02-06 8:17 ` Felipe Balbi
-1 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2012-02-06 8:17 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Mon, Feb 06, 2012 at 09:09:09AM +0100, walter harms wrote:
>
>
> Am 06.02.2012 07:44, schrieb Felipe Balbi:
> > On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> >> We always return zero instead of the id we found.
> >>
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Applied, thanks
> >
> >> ---
> >> I don't have this hardware so it's not tested.
> >
> > This one is so obvious that I can't even believe we haven't seen that
> > before, thanks ;-)
> >
>
> i was wondering why the driver worked at all, do you realy need that ?
as of now we don't have usecases for that. But since it can work on
PCIe, I was thinking of building an automated testmachine with two of
those devices ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread