* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
@ 2012-02-06 10:04 Joey Lee
2012-02-06 11:04 ` Ike Panhc
0 siblings, 1 reply; 6+ messages in thread
From: Joey Lee @ 2012-02-06 10:04 UTC (permalink / raw)
To: ike.pan; +Cc: corentincj, dtor, mjg, carlos, trenn, platform-driver-x86
Hi Ike,
於 五，2012-02-03 於 16:46 +0800，Ike Panhc 提到：
> We have several reports which says acer-wmi is loaded on ideapads
> and register rfkill for wifi which can not be unblocked.
>
> Since ideapad-laptop also register rfkill for wifi and it works
> reliably, it will be fine acer-wmi is not going to register rfkill
> for wifi once VPC2004 is found.
>
> Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
> wifi rfkill capability, there are reports which says acer-wmi also
> block wireless on Thinkpad E520/E420.
>
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
Thanks for your patch, it's good to me after tested.
Tested on Acer TravelMate 4750.
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Thanks a lot!
Joey Lee
> ---
> drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
> 1 files changed, 29 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b848277..1e5290b 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
> return AE_OK;
> }
>
> +static int AMW0_set_cap_acpi_check_device_found;
> +
> +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
> + u32 level, void *context, void **retval)
> +{
> + AMW0_set_cap_acpi_check_device_found = 1;
> + return AE_OK;
> +}
> +
> +static const struct acpi_device_id norfkill_ids[] = {
> + { "VPC2004", 0},
> + { "IBM0068", 0},
> + { "LEN0068", 0},
> + { "", 0},
> +};
> +
> +static int AMW0_set_cap_acpi_check_device(void)
> +{
> + const struct acpi_device_id *id;
> +
> + for (id = norfkill_ids; id->id[0]; id++)
> + acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
> + NULL, NULL);
> + return AMW0_set_cap_acpi_check_device_found;
> +}
> +
> static acpi_status AMW0_set_capabilities(void)
> {
> struct wmab_args args;
> @@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
> * work.
> */
> if (wmi_has_guid(AMW0_GUID2)) {
> - interface->capability |= ACER_CAP_WIRELESS;
> + if ((quirks != &quirk_unknown) ||
> + !AMW0_set_cap_acpi_check_device())
> + interface->capability |= ACER_CAP_WIRELESS;
> return AE_OK;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
2012-02-06 10:04 [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines Joey Lee
@ 2012-02-06 11:04 ` Ike Panhc
0 siblings, 0 replies; 6+ messages in thread
From: Ike Panhc @ 2012-02-06 11:04 UTC (permalink / raw)
To: Joey Lee; +Cc: corentincj, dtor, mjg, carlos, trenn, platform-driver-x86
Thanks.
I work with bug reporter at
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659
and also got a report of successful test which is at
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659/comments/65
On 02/06/2012 06:04 PM, Joey Lee wrote:
> Hi Ike,
>
> 於 五，2012-02-03 於 16:46 +0800，Ike Panhc 提到：
>> We have several reports which says acer-wmi is loaded on ideapads
>> and register rfkill for wifi which can not be unblocked.
>>
>> Since ideapad-laptop also register rfkill for wifi and it works
>> reliably, it will be fine acer-wmi is not going to register rfkill
>> for wifi once VPC2004 is found.
>>
>> Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
>> wifi rfkill capability, there are reports which says acer-wmi also
>> block wireless on Thinkpad E520/E420.
>>
>> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>
> Thanks for your patch, it's good to me after tested.
>
>
> Tested on Acer TravelMate 4750.
>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
>
>
> Thanks a lot!
> Joey Lee
>
>> ---
>> drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
>> 1 files changed, 29 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index b848277..1e5290b 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
>> return AE_OK;
>> }
>>
>> +static int AMW0_set_cap_acpi_check_device_found;
>> +
>> +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
>> + u32 level, void *context, void **retval)
>> +{
>> + AMW0_set_cap_acpi_check_device_found = 1;
>> + return AE_OK;
>> +}
>> +
>> +static const struct acpi_device_id norfkill_ids[] = {
>> + { "VPC2004", 0},
>> + { "IBM0068", 0},
>> + { "LEN0068", 0},
>> + { "", 0},
>> +};
>> +
>> +static int AMW0_set_cap_acpi_check_device(void)
>> +{
>> + const struct acpi_device_id *id;
>> +
>> + for (id = norfkill_ids; id->id[0]; id++)
>> + acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
>> + NULL, NULL);
>> + return AMW0_set_cap_acpi_check_device_found;
>> +}
>> +
>> static acpi_status AMW0_set_capabilities(void)
>> {
>> struct wmab_args args;
>> @@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
>> * work.
>> */
>> if (wmi_has_guid(AMW0_GUID2)) {
>> - interface->capability |= ACER_CAP_WIRELESS;
>> + if ((quirks != &quirk_unknown) ||
>> + !AMW0_set_cap_acpi_check_device())
>> + interface->capability |= ACER_CAP_WIRELESS;
>> return AE_OK;
>> }
>>
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] acer-wmi: No wifi rfkill on Lenovo machines
@ 2012-01-26 2:53 joeyli
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
0 siblings, 1 reply; 6+ messages in thread
From: joeyli @ 2012-01-26 2:53 UTC (permalink / raw)
To: Ike Panhc
Cc: Carlos Corbacho, mjg, platform-driver-x86, Dmitry Torokhov,
Corentin Chary, Thomas Renninger
Hi Ike,
於 三，2012-01-25 於 10:14 +0800，Ike Panhc 提到：
> This patch has been tested on ideapad s205
>
> User reports the first time try wireless hard/soft all blocked
>
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659/comments/53
>
> but the second try looks good.
>
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659/comments/55
>
>
That will be better retest this patch after remove ac power and battery.
> On 01/25/2012 09:57 AM, Ike Panhc wrote:
> > We have several reports which says acer-wmi is loaded on ideapads
> > and register rfkill for wifi which can not be unblocked.
> >
> > Since ideapad-laptop also register rfkill for wifi and it works
> > reliably, it will be fine acer-wmi is not going to register rfkill
> > for wifi once VPC2004 is found.
> >
> > Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
> > wifi rfkill capability, there are reports which says acer-wmi also
> > block wireless on Thinkpad E520/E420.
> >
> > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> > ---
> > drivers/platform/x86/acer-wmi.c | 29 ++++++++++++++++++++++++++++-
> > 1 files changed, 28 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> > index b848277..aaef8f8 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
> > return AE_OK;
> > }
> >
> > +static int AMW0_set_cap_acpi_check_device_found = 0;
> > +
> > +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
> > + u32 level, void *context, void **retval)
> > +{
> > + AMW0_set_cap_acpi_check_device_found = 1;
> > + return AE_OK;
> > +}
> > +
> > +static const struct acpi_device_id norfkill_ids[] = {
> > + { "VPC2004", 0},
> > + { "IBM0068", 0},
> > + { "LEN0068", 0},
> > + { "", 0},
> > +};
> > +
> > +static int AMW0_set_cap_acpi_check_device(void)
> > +{
> > + const struct acpi_device_id *id;
> > +
> > + for (id = norfkill_ids; id->id[0]; id++)
> > + acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
> > + NULL, NULL);
> > + return AMW0_set_cap_acpi_check_device_found;
> > +}
> > +
> > static acpi_status AMW0_set_capabilities(void)
> > {
> > struct wmab_args args;
> > @@ -692,7 +718,8 @@ static acpi_status AMW0_set_capabilities(void)
> > * work.
> > */
> > if (wmi_has_guid(AMW0_GUID2)) {
> > - interface->capability |= ACER_CAP_WIRELESS;
> > + if (!AMW0_set_cap_acpi_check_device())
> > + interface->capability |= ACER_CAP_WIRELESS;
I suggest add the following logic (non-test) to pass quirks that were
already supported by acer-wmi:
if ((quirk != &quirk_unknown) || !AMW0_set_cap_acpi_check_device())
interface->capability |= ACER_CAP_WIRELESS;
That can keep acer-wmi still support Lenovo Ideapad S205 and Lenovo 3000 N200 by
quirks. Those quirks works fine before.
> > return AE_OK;
> > }
> >
>
>
Thanks a lot!
Joey Lee
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
2012-01-26 2:53 [PATCH] " joeyli
@ 2012-02-03 8:46 ` Ike Panhc
2012-02-03 8:55 ` Ike Panhc
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ike Panhc @ 2012-02-03 8:46 UTC (permalink / raw)
To: joeyli
Cc: Carlos Corbacho, mjg, platform-driver-x86, Dmitry Torokhov,
Corentin Chary, Thomas Renninger
We have several reports which says acer-wmi is loaded on ideapads
and register rfkill for wifi which can not be unblocked.
Since ideapad-laptop also register rfkill for wifi and it works
reliably, it will be fine acer-wmi is not going to register rfkill
for wifi once VPC2004 is found.
Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
wifi rfkill capability, there are reports which says acer-wmi also
block wireless on Thinkpad E520/E420.
Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
1 files changed, 29 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index b848277..1e5290b 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
return AE_OK;
}
+static int AMW0_set_cap_acpi_check_device_found;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+ u32 level, void *context, void **retval)
+{
+ AMW0_set_cap_acpi_check_device_found = 1;
+ return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+ { "VPC2004", 0},
+ { "IBM0068", 0},
+ { "LEN0068", 0},
+ { "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+ const struct acpi_device_id *id;
+
+ for (id = norfkill_ids; id->id[0]; id++)
+ acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+ NULL, NULL);
+ return AMW0_set_cap_acpi_check_device_found;
+}
+
static acpi_status AMW0_set_capabilities(void)
{
struct wmab_args args;
@@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
* work.
*/
if (wmi_has_guid(AMW0_GUID2)) {
- interface->capability |= ACER_CAP_WIRELESS;
+ if ((quirks != &quirk_unknown) ||
+ !AMW0_set_cap_acpi_check_device())
+ interface->capability |= ACER_CAP_WIRELESS;
return AE_OK;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
@ 2012-02-03 8:55 ` Ike Panhc
2012-02-06 9:55 ` joeyli
2012-02-11 19:10 ` Jonathan Nieder
2 siblings, 0 replies; 6+ messages in thread
From: Ike Panhc @ 2012-02-03 8:55 UTC (permalink / raw)
To: joeyli
Cc: Carlos Corbacho, mjg, platform-driver-x86, Dmitry Torokhov,
Corentin Chary, Thomas Renninger
Two modification.
* Check quirks also.
* for static variable, no need to set to 0 as initial value.
On 02/03/2012 04:46 PM, Ike Panhc wrote:
> We have several reports which says acer-wmi is loaded on ideapads
> and register rfkill for wifi which can not be unblocked.
>
> Since ideapad-laptop also register rfkill for wifi and it works
> reliably, it will be fine acer-wmi is not going to register rfkill
> for wifi once VPC2004 is found.
>
> Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
> wifi rfkill capability, there are reports which says acer-wmi also
> block wireless on Thinkpad E520/E420.
>
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> ---
> drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
> 1 files changed, 29 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b848277..1e5290b 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
> return AE_OK;
> }
>
> +static int AMW0_set_cap_acpi_check_device_found;
> +
> +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
> + u32 level, void *context, void **retval)
> +{
> + AMW0_set_cap_acpi_check_device_found = 1;
> + return AE_OK;
> +}
> +
> +static const struct acpi_device_id norfkill_ids[] = {
> + { "VPC2004", 0},
> + { "IBM0068", 0},
> + { "LEN0068", 0},
> + { "", 0},
> +};
> +
> +static int AMW0_set_cap_acpi_check_device(void)
> +{
> + const struct acpi_device_id *id;
> +
> + for (id = norfkill_ids; id->id[0]; id++)
> + acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
> + NULL, NULL);
> + return AMW0_set_cap_acpi_check_device_found;
> +}
> +
> static acpi_status AMW0_set_capabilities(void)
> {
> struct wmab_args args;
> @@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
> * work.
> */
> if (wmi_has_guid(AMW0_GUID2)) {
> - interface->capability |= ACER_CAP_WIRELESS;
> + if ((quirks != &quirk_unknown) ||
> + !AMW0_set_cap_acpi_check_device())
> + interface->capability |= ACER_CAP_WIRELESS;
> return AE_OK;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
2012-02-03 8:55 ` Ike Panhc
@ 2012-02-06 9:55 ` joeyli
2012-02-11 19:10 ` Jonathan Nieder
2 siblings, 0 replies; 6+ messages in thread
From: joeyli @ 2012-02-06 9:55 UTC (permalink / raw)
To: Ike Panhc
Cc: Carlos Corbacho, mjg, platform-driver-x86, Dmitry Torokhov,
Corentin Chary, Thomas Renninger
Hi Ike,
於 五，2012-02-03 於 16:46 +0800，Ike Panhc 提到：
> We have several reports which says acer-wmi is loaded on ideapads
> and register rfkill for wifi which can not be unblocked.
>
> Since ideapad-laptop also register rfkill for wifi and it works
> reliably, it will be fine acer-wmi is not going to register rfkill
> for wifi once VPC2004 is found.
>
> Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
> wifi rfkill capability, there are reports which says acer-wmi also
> block wireless on Thinkpad E520/E420.
>
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
Thanks for your patch, it's good to me after tested.
Tested on Acer TravelMate 4750.
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Thanks a lot!
Joey Lee
> ---
> drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
> 1 files changed, 29 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b848277..1e5290b 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
> return AE_OK;
> }
>
> +static int AMW0_set_cap_acpi_check_device_found;
> +
> +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
> + u32 level, void *context, void **retval)
> +{
> + AMW0_set_cap_acpi_check_device_found = 1;
> + return AE_OK;
> +}
> +
> +static const struct acpi_device_id norfkill_ids[] = {
> + { "VPC2004", 0},
> + { "IBM0068", 0},
> + { "LEN0068", 0},
> + { "", 0},
> +};
> +
> +static int AMW0_set_cap_acpi_check_device(void)
> +{
> + const struct acpi_device_id *id;
> +
> + for (id = norfkill_ids; id->id[0]; id++)
> + acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
> + NULL, NULL);
> + return AMW0_set_cap_acpi_check_device_found;
> +}
> +
> static acpi_status AMW0_set_capabilities(void)
> {
> struct wmab_args args;
> @@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
> * work.
> */
> if (wmi_has_guid(AMW0_GUID2)) {
> - interface->capability |= ACER_CAP_WIRELESS;
> + if ((quirks != &quirk_unknown) ||
> + !AMW0_set_cap_acpi_check_device())
> + interface->capability |= ACER_CAP_WIRELESS;
> return AE_OK;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
2012-02-03 8:55 ` Ike Panhc
2012-02-06 9:55 ` joeyli
@ 2012-02-11 19:10 ` Jonathan Nieder
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Nieder @ 2012-02-11 19:10 UTC (permalink / raw)
To: Ike Panhc
Cc: joeyli, Carlos Corbacho, mjg, platform-driver-x86,
Dmitry Torokhov, Corentin Chary, Thomas Renninger, Seth Forshee,
Andrey
Hi,
Ike Panhc wrote:
> We have several reports which says acer-wmi is loaded on ideapads
> and register rfkill for wifi which can not be unblocked.
>
> Since ideapad-laptop also register rfkill for wifi and it works
> reliably, it will be fine acer-wmi is not going to register rfkill
> for wifi once VPC2004 is found.
[...]
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> ---
> drivers/platform/x86/acer-wmi.c | 30 +++++++++++++++++++++++++++++-
> 1 files changed, 29 insertions(+), 1 deletions(-)
Thanks! As described at <http://bugs.debian.org/655941>, without this
patch, Andrey was not able to use wifi, getting the following message
in the kernel log instead:
iwlagn 0000:03:00.0: RF_KILL bit toggled to enable radio.
rfkill list gave
2: acer-wireless: Wireless LAN
Soft blocked: yes
Hard blocked: no
regardless of the state of the actual radio kill switch. Unloading
the acer_wmi was a workaround. With this patch, wifi works without
needing to unload acer_wmi, so:
Tested-by: Andrey <andrey.k.p@gmail.com> # Ideapad Z570
He tested against the 3.2.y tree.
When applying this, please consider cc-ing stable@ so people using
point releases can benefit from the fix, too.
Happily,
Jonathan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-11 19:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-06 10:04 [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines Joey Lee
2012-02-06 11:04 ` Ike Panhc
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 2:53 [PATCH] " joeyli
2012-02-03 8:46 ` [PATCH v2] " Ike Panhc
2012-02-03 8:55 ` Ike Panhc
2012-02-06 9:55 ` joeyli
2012-02-11 19:10 ` Jonathan Nieder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.