All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines
@ 2012-01-09  6:31 Lee, Chun-Yi
  2012-01-09  8:01 ` Carlos Corbacho
  0 siblings, 1 reply; 30+ messages in thread
From: Lee, Chun-Yi @ 2012-01-09  6:31 UTC (permalink / raw)
  To: mjg
  Cc: platform-driver-x86, Lee, Chun-Yi, Carlos Corbacho,
	Dmitry Torokhov, Corentin Chary, Thomas Renninger

From: "Lee, Chun-Yi" <jlee@suse.com>

Have many non-acer machines have AMW0_GUID2 method in DSDT, in
original acer-wmi design, driver direct set ACER_CAP_WIRELESS flag
for those machines but didn't check the functionality for set/get
wireless state.
It causes acer-wmi driver create a broken wireless rfkill and it
already set to soft blocked.

So, this patch add a wireless capability check before we set
ACER_CAP_WIRELESS flag to the machines that were included AMW0_GUID2.
It avoid acer-wmi create a broken wireless rfkill.

Thank's for Matthew Garrett give the idea.

Reference: brc#674353
        https://bugzilla.redhat.com/show_bug.cgi?id=674353

Tested on Lenovo E520.
Tested on Acer TravelMate 4750.

Tested-by: mr.kobzar <mr.kobzar@gmail.com>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |   33 ++++++++++++++++++++++++++++++++-
 1 files changed, 32 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 88dfecf..5dfa46a 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -678,6 +678,37 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static void AMW0_GUID2_set_capabilities(void)
+{
+	acpi_status status;
+	u32 original_state, new_state;
+
+	/* set wireless capability when detected has quirk */
+	if (quirks->wireless > 0) {
+		interface->capability |= ACER_CAP_WIRELESS;
+		return;
+	}
+
+	status = AMW0_get_u32(&original_state, ACER_CAP_WIRELESS);
+	if (ACPI_FAILURE(status))
+		return;
+
+	status = AMW0_set_u32(!original_state, ACER_CAP_WIRELESS);
+	if (ACPI_FAILURE(status))
+		return;
+
+	status = AMW0_get_u32(&new_state, ACER_CAP_WIRELESS);
+	if (ACPI_FAILURE(status))
+		return;
+
+	status = AMW0_set_u32(original_state, ACER_CAP_WIRELESS);
+	if (ACPI_FAILURE(status))
+		return;
+
+	if (new_state != original_state)
+		interface->capability |= ACER_CAP_WIRELESS;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {
 	struct wmab_args args;
@@ -691,7 +722,7 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		AMW0_GUID2_set_capabilities();
 		return AE_OK;
 	}
 
-- 
1.7.7

^ permalink raw reply related	[flat|nested] 30+ messages in thread
* Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines
@ 2012-02-06 10:04 Joey Lee
  2012-02-06 11:04 ` Ike Panhc
  0 siblings, 1 reply; 30+ messages in thread
From: Joey Lee @ 2012-02-06 10:04 UTC (permalink / raw)
  To: ike.pan; +Cc: corentincj, dtor, mjg, carlos, trenn, platform-driver-x86

Hi Ike, 

於 五，2012-02-03 於 16:46 +0800，Ike Panhc 提到：
> We have several reports which says acer-wmi is loaded on ideapads
> and register rfkill for wifi which can not be unblocked.
> 
> Since ideapad-laptop also register rfkill for wifi and it works
> reliably, it will be fine acer-wmi is not going to register rfkill
> for wifi once VPC2004 is found.
> 
> Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no
> wifi rfkill capability, there are reports which says acer-wmi also
> block wireless on Thinkpad E520/E420.
> 
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>

Thanks for your patch, it's good to me after tested.


Tested on Acer TravelMate 4750.

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>


Thanks a lot!
Joey Lee

> ---
>  drivers/platform/x86/acer-wmi.c |   30 +++++++++++++++++++++++++++++-
>  1 files changed, 29 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index b848277..1e5290b 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
>  	return AE_OK;
>  }
>  
> +static int AMW0_set_cap_acpi_check_device_found;
> +
> +static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
> +	u32 level, void *context, void **retval)
> +{
> +	AMW0_set_cap_acpi_check_device_found = 1;
> +	return AE_OK;
> +}
> +
> +static const struct acpi_device_id norfkill_ids[] = {
> +	{ "VPC2004", 0},
> +	{ "IBM0068", 0},
> +	{ "LEN0068", 0},
> +	{ "", 0},
> +};
> +
> +static int AMW0_set_cap_acpi_check_device(void)
> +{
> +	const struct acpi_device_id *id;
> +
> +	for (id = norfkill_ids; id->id[0]; id++)
> +		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
> +				NULL, NULL);
> +	return AMW0_set_cap_acpi_check_device_found;
> +}
> +
>  static acpi_status AMW0_set_capabilities(void)
>  {
>  	struct wmab_args args;
> @@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
>  	 * work.
>  	 */
>  	if (wmi_has_guid(AMW0_GUID2)) {
> -		interface->capability |= ACER_CAP_WIRELESS;
> +		if ((quirks != &quirk_unknown) ||
> +		    !AMW0_set_cap_acpi_check_device())
> +			interface->capability |= ACER_CAP_WIRELESS;
>  		return AE_OK;
>  	}
>  

^ permalink raw reply	[flat|nested] 30+ messages in thread
end of thread, other threads:[~2012-03-19 14:48 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09  6:31 [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines Lee, Chun-Yi
2012-01-09  8:01 ` Carlos Corbacho
2012-01-09 10:00   ` joeyli
2012-01-09 22:15     ` Carlos Corbacho
2012-01-11  4:26       ` joeyli
2012-01-11 16:54         ` Ike Panhc
2012-01-12  0:21           ` joeyli
2012-01-25  1:18             ` Ike Panhc
2012-01-20  2:44           ` joeyli
2012-01-25  1:29             ` Ike Panhc
2012-01-25  1:57             ` [PATCH] acer-wmi: No wifi rfkill on Lenovo machines Ike Panhc
2012-01-25  2:14               ` Ike Panhc
2012-01-26  2:53                 ` joeyli
2012-02-03  8:46                   ` [PATCH v2] " Ike Panhc
2012-02-03  8:55                     ` Ike Panhc
2012-02-06  9:55                     ` joeyli
2012-02-11 19:10                     ` Jonathan Nieder
2012-02-21  9:22                       ` [PATCH resend] " Jonathan Nieder
2012-03-14 21:53                     ` [PATCH 3.0.y] " Jonathan Nieder
2012-03-14 22:02                       ` Greg KH
2012-03-14 22:17                         ` Jonathan Nieder
2012-03-16  4:03                           ` Ike Panhc
2012-03-16  6:11                             ` joeyli
2012-03-16 17:20                               ` Greg KH
2012-03-19  2:08                                 ` joeyli
2012-03-19 12:40                                   ` Andrey
2012-03-19 14:48                                     ` Jonathan Nieder
2012-01-24  0:04           ` [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines joeyli
  -- strict thread matches above, loose matches on Subject: below --
2012-02-06 10:04 [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines Joey Lee
2012-02-06 11:04 ` Ike Panhc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.