All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Developers qemu-devel" <qemu-devel@nongnu.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"KVM devel mailing list" <kvm@vger.kernel.org>,
	quintela@redhat.com
Subject: Re: [Qemu-devel] KVM call agenda for Tuesday 7
Date: Tue, 07 Feb 2012 10:33:44 -0600	[thread overview]
Message-ID: <4F315268.8030608@codemonkey.ws> (raw)
In-Reply-To: <4F3150F0.8060805@redhat.com>

On 02/07/2012 10:27 AM, Paolo Bonzini wrote:
> On 02/07/2012 05:24 PM, Anthony Liguori wrote:
>>> I'm wary of all plans that require to go through all the code once. What about
>>> simply /devices/default/child[...] or something like that?
>>
>> The paths would be unstable, but maybe that's okay. I'd suggest
>> doing child[rand()] to avoid the appearance that these paths are in
>> any way shape or form stable.
>
> Sounds a bit inconvenient for humans (who in the end are those who debug things
> :)).

There are tons of human readable paths to a single object so I don't think it's 
a problem.  But no big deal with way since /devices/default should go away anyway.

>
>>> BTW, I would like to change /i440fx to /devices/i440fx, so that we
>>> will have clean namespaces:
>>>
>>> /block
>>> /chardev
>>> /clocks
>>> /devices
>>
>> Yeah, this makes sense. By clocks, you mean things like rtc_clock,
>> vm_clock, etc? Not the omap clocks which happen to live in /clocks in
>> your series?
>
> No, I really meant the OMAP clocks. :) Basically if you have an abstract
> subclass TYPE_FOOS of TYPE_OBJECT, its instances would reside under /foos or
> something easily related to "foos".

Hrm, I don't like that very much.

OMAP clocks are devices.  Don't they belong in the devices hierarchy under the 
omap-clocks branch?

The fact that they aren't DeviceState's is because DeviceState is a pile of 
cruft.  Perhaps we should introduce a more streamlined Device base class and 
rename DeviceState to LegacyDevice or something like that.

Regards,

Anthony Liguori

>
> Paolo
>


WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: quintela@redhat.com,
	"Developers qemu-devel" <qemu-devel@nongnu.org>,
	"KVM devel mailing list" <kvm@vger.kernel.org>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] KVM call agenda for Tuesday 7
Date: Tue, 07 Feb 2012 10:33:44 -0600	[thread overview]
Message-ID: <4F315268.8030608@codemonkey.ws> (raw)
In-Reply-To: <4F3150F0.8060805@redhat.com>

On 02/07/2012 10:27 AM, Paolo Bonzini wrote:
> On 02/07/2012 05:24 PM, Anthony Liguori wrote:
>>> I'm wary of all plans that require to go through all the code once. What about
>>> simply /devices/default/child[...] or something like that?
>>
>> The paths would be unstable, but maybe that's okay. I'd suggest
>> doing child[rand()] to avoid the appearance that these paths are in
>> any way shape or form stable.
>
> Sounds a bit inconvenient for humans (who in the end are those who debug things
> :)).

There are tons of human readable paths to a single object so I don't think it's 
a problem.  But no big deal with way since /devices/default should go away anyway.

>
>>> BTW, I would like to change /i440fx to /devices/i440fx, so that we
>>> will have clean namespaces:
>>>
>>> /block
>>> /chardev
>>> /clocks
>>> /devices
>>
>> Yeah, this makes sense. By clocks, you mean things like rtc_clock,
>> vm_clock, etc? Not the omap clocks which happen to live in /clocks in
>> your series?
>
> No, I really meant the OMAP clocks. :) Basically if you have an abstract
> subclass TYPE_FOOS of TYPE_OBJECT, its instances would reside under /foos or
> something easily related to "foos".

Hrm, I don't like that very much.

OMAP clocks are devices.  Don't they belong in the devices hierarchy under the 
omap-clocks branch?

The fact that they aren't DeviceState's is because DeviceState is a pile of 
cruft.  Perhaps we should introduce a more streamlined Device base class and 
rename DeviceState to LegacyDevice or something like that.

Regards,

Anthony Liguori

>
> Paolo
>

  reply	other threads:[~2012-02-07 16:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 19:25 KVM call agenda for Tuesday 7 Juan Quintela
2012-02-06 19:25 ` [Qemu-devel] " Juan Quintela
2012-02-07 13:45 ` Andreas Färber
2012-02-07 13:45   ` Andreas Färber
2012-02-07 13:52   ` Paolo Bonzini
2012-02-07 13:52     ` Paolo Bonzini
2012-02-07 14:56     ` Anthony Liguori
2012-02-07 14:56       ` Anthony Liguori
2012-02-07 15:21       ` Paolo Bonzini
2012-02-07 15:21         ` Paolo Bonzini
2012-02-07 16:24         ` Anthony Liguori
2012-02-07 16:24           ` Anthony Liguori
2012-02-07 16:27           ` Paolo Bonzini
2012-02-07 16:27             ` Paolo Bonzini
2012-02-07 16:33             ` Anthony Liguori [this message]
2012-02-07 16:33               ` Anthony Liguori
2012-02-07 16:40               ` Peter Maydell
2012-02-07 16:40                 ` Peter Maydell
2012-02-07 17:04               ` Paolo Bonzini
2012-02-07 17:04                 ` Paolo Bonzini
2012-02-07 16:41         ` Andreas Färber
2012-02-07 16:41           ` Andreas Färber
2012-02-07 16:53           ` Anthony Liguori
2012-02-07 16:53             ` Anthony Liguori
2012-02-07 18:01   ` Anthony Liguori
2012-02-07 18:01     ` Anthony Liguori
2012-02-07 18:17     ` Andreas Färber
2012-02-07 18:17       ` Andreas Färber
2012-02-07 19:06       ` Anthony Liguori
2012-02-07 14:23 ` Juan Quintela
2012-02-07 14:23   ` [Qemu-devel] " Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F315268.8030608@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=afaerber@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.