From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: "Developers qemu-devel" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>,
"KVM devel mailing list" <kvm@vger.kernel.org>,
quintela@redhat.com
Subject: Re: [Qemu-devel] KVM call agenda for Tuesday 7
Date: Tue, 07 Feb 2012 18:04:33 +0100 [thread overview]
Message-ID: <4F3159A1.5060700@redhat.com> (raw)
In-Reply-To: <4F315268.8030608@codemonkey.ws>
On 02/07/2012 05:33 PM, Anthony Liguori wrote:
> Hrm, I don't like that very much.
Yes, me neither actually.
If the object representing the state of the OMAP board (struct
omap_mpu_state_s) is QOMified, the clocks can easily get under it in the
composition tree. Right now, that part is not even qdev. :)
> OMAP clocks are devices. Don't they belong in the devices hierarchy
> under the omap-clocks branch?
If they were devices, yes. But they're not, and it wouldn't have been a
great time investment to refactor them. :)
Perhaps we can have /machine instead of /devices, a more generic name
would do well. Then...
> The fact that they aren't DeviceState's is because DeviceState is a pile
> of cruft. Perhaps we should introduce a more streamlined Device base
> class and rename DeviceState to LegacyDevice or something like that.
... light-weight components can inherit straight from Object and go
under /machine. There would be /machine/clocks for example.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: quintela@redhat.com,
"Developers qemu-devel" <qemu-devel@nongnu.org>,
"KVM devel mailing list" <kvm@vger.kernel.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] KVM call agenda for Tuesday 7
Date: Tue, 07 Feb 2012 18:04:33 +0100 [thread overview]
Message-ID: <4F3159A1.5060700@redhat.com> (raw)
In-Reply-To: <4F315268.8030608@codemonkey.ws>
On 02/07/2012 05:33 PM, Anthony Liguori wrote:
> Hrm, I don't like that very much.
Yes, me neither actually.
If the object representing the state of the OMAP board (struct
omap_mpu_state_s) is QOMified, the clocks can easily get under it in the
composition tree. Right now, that part is not even qdev. :)
> OMAP clocks are devices. Don't they belong in the devices hierarchy
> under the omap-clocks branch?
If they were devices, yes. But they're not, and it wouldn't have been a
great time investment to refactor them. :)
Perhaps we can have /machine instead of /devices, a more generic name
would do well. Then...
> The fact that they aren't DeviceState's is because DeviceState is a pile
> of cruft. Perhaps we should introduce a more streamlined Device base
> class and rename DeviceState to LegacyDevice or something like that.
... light-weight components can inherit straight from Object and go
under /machine. There would be /machine/clocks for example.
Paolo
next prev parent reply other threads:[~2012-02-07 17:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 19:25 KVM call agenda for Tuesday 7 Juan Quintela
2012-02-06 19:25 ` [Qemu-devel] " Juan Quintela
2012-02-07 13:45 ` Andreas Färber
2012-02-07 13:45 ` Andreas Färber
2012-02-07 13:52 ` Paolo Bonzini
2012-02-07 13:52 ` Paolo Bonzini
2012-02-07 14:56 ` Anthony Liguori
2012-02-07 14:56 ` Anthony Liguori
2012-02-07 15:21 ` Paolo Bonzini
2012-02-07 15:21 ` Paolo Bonzini
2012-02-07 16:24 ` Anthony Liguori
2012-02-07 16:24 ` Anthony Liguori
2012-02-07 16:27 ` Paolo Bonzini
2012-02-07 16:27 ` Paolo Bonzini
2012-02-07 16:33 ` Anthony Liguori
2012-02-07 16:33 ` Anthony Liguori
2012-02-07 16:40 ` Peter Maydell
2012-02-07 16:40 ` Peter Maydell
2012-02-07 17:04 ` Paolo Bonzini [this message]
2012-02-07 17:04 ` Paolo Bonzini
2012-02-07 16:41 ` Andreas Färber
2012-02-07 16:41 ` Andreas Färber
2012-02-07 16:53 ` Anthony Liguori
2012-02-07 16:53 ` Anthony Liguori
2012-02-07 18:01 ` Anthony Liguori
2012-02-07 18:01 ` Anthony Liguori
2012-02-07 18:17 ` Andreas Färber
2012-02-07 18:17 ` Andreas Färber
2012-02-07 19:06 ` Anthony Liguori
2012-02-07 14:23 ` Juan Quintela
2012-02-07 14:23 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3159A1.5060700@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.