* [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header
@ 2012-02-02 12:04 Markos Chandras
2012-02-09 15:51 ` Markos Chandras
0 siblings, 1 reply; 6+ messages in thread
From: Markos Chandras @ 2012-02-02 12:04 UTC (permalink / raw)
To: ltp-list
The tst_print function is using the TEST_ERRNO symbol which is declared
as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int'
when this macro is not defined. We need to include this header on float and
echoes tests to ensure that TEST_ERRNO has been defined before calling
the tst_print function. Without this header, the compilation will fail with
an undefined symbol error.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
testcases/misc/math/float/main.c | 1 +
testcases/network/tcp_cmds/echo/echoes.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/testcases/misc/math/float/main.c b/testcases/misc/math/float/main.c
index 8998c33..870661b 100644
--- a/testcases/misc/math/float/main.c
+++ b/testcases/misc/math/float/main.c
@@ -26,6 +26,7 @@
#include "tfloat.h"
#include "test.h"
+#include "usctest.h"
#define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
/* LTP status reporting */
diff --git a/testcases/network/tcp_cmds/echo/echoes.c b/testcases/network/tcp_cmds/echo/echoes.c
index 877cfa5..2ce7968 100644
--- a/testcases/network/tcp_cmds/echo/echoes.c
+++ b/testcases/network/tcp_cmds/echo/echoes.c
@@ -29,6 +29,7 @@
#include <fcntl.h>
#include "test.h"
#include "netdefs.h"
+#include "usctest.h"
#if INET6
char *TCID = "echoes6";
@@ -372,4 +373,4 @@ void
cleanup(int s)
{
close(s);
-}
\ No newline at end of file
+}
--
1.7.1
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header
2012-02-02 12:04 [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header Markos Chandras
@ 2012-02-09 15:51 ` Markos Chandras
2012-02-09 16:14 ` Cyril Hrubis
0 siblings, 1 reply; 6+ messages in thread
From: Markos Chandras @ 2012-02-09 15:51 UTC (permalink / raw)
To: ltp-list
On 02/02/2012 12:04 PM, Markos Chandras wrote:
> The tst_print function is using the TEST_ERRNO symbol which is declared
> as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int'
> when this macro is not defined. We need to include this header on float and
> echoes tests to ensure that TEST_ERRNO has been defined before calling
> the tst_print function. Without this header, the compilation will fail with
> an undefined symbol error.
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> testcases/misc/math/float/main.c | 1 +
> testcases/network/tcp_cmds/echo/echoes.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/misc/math/float/main.c b/testcases/misc/math/float/main.c
> index 8998c33..870661b 100644
> --- a/testcases/misc/math/float/main.c
> +++ b/testcases/misc/math/float/main.c
> @@ -26,6 +26,7 @@
> #include "tfloat.h"
>
> #include "test.h"
> +#include "usctest.h"
>
> #define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
> /* LTP status reporting */
> diff --git a/testcases/network/tcp_cmds/echo/echoes.c b/testcases/network/tcp_cmds/echo/echoes.c
> index 877cfa5..2ce7968 100644
> --- a/testcases/network/tcp_cmds/echo/echoes.c
> +++ b/testcases/network/tcp_cmds/echo/echoes.c
> @@ -29,6 +29,7 @@
> #include <fcntl.h>
> #include "test.h"
> #include "netdefs.h"
> +#include "usctest.h"
>
> #if INET6
> char *TCID = "echoes6";
> @@ -372,4 +373,4 @@ void
> cleanup(int s)
> {
> close(s);
> -}
> \ No newline at end of file
> +}
> --
> 1.7.1
>
Ping? Just making sure this patch reached the list this time.
--
markos
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1326106637-5173-1-git-send-email-markos.chandras@imgtec.com>]
* Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header
[not found] <1326106637-5173-1-git-send-email-markos.chandras@imgtec.com>
@ 2012-01-26 10:15 ` Markos Chandras
2012-01-26 14:10 ` Cyril Hrubis
0 siblings, 1 reply; 6+ messages in thread
From: Markos Chandras @ 2012-01-26 10:15 UTC (permalink / raw)
To: ltp-list
On 01/09/2012 10:57 AM, Markos Chandras wrote:
> The tst_print function is using the TEST_ERRNO symbol which is declared
> as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int'
> when this macro is not defined. We need to include this header on float and
> echoes tests to ensure that TEST_ERRNO has been defined before calling
> the tst_print function. Without this header, the compilation will fail with
> an undefined symbol error.
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> testcases/misc/math/float/main.c | 1 +
> testcases/network/tcp_cmds/echo/echoes.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/misc/math/float/main.c b/testcases/misc/math/float/main.c
> index 8998c33..870661b 100644
> --- a/testcases/misc/math/float/main.c
> +++ b/testcases/misc/math/float/main.c
> @@ -26,6 +26,7 @@
> #include "tfloat.h"
>
> #include "test.h"
> +#include "usctest.h"
>
> #define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
> /* LTP status reporting */
> diff --git a/testcases/network/tcp_cmds/echo/echoes.c b/testcases/network/tcp_cmds/echo/echoes.c
> index 877cfa5..2ce7968 100644
> --- a/testcases/network/tcp_cmds/echo/echoes.c
> +++ b/testcases/network/tcp_cmds/echo/echoes.c
> @@ -29,6 +29,7 @@
> #include <fcntl.h>
> #include "test.h"
> #include "netdefs.h"
> +#include "usctest.h"
>
> #if INET6
> char *TCID = "echoes6";
> @@ -372,4 +373,4 @@ void
> cleanup(int s)
> {
> close(s);
> -}
> \ No newline at end of file
> +}
Ping?
Any comments on that? Compilation fails without that when using UCLINUX=1
--
markos
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header
2012-01-26 10:15 ` Markos Chandras
@ 2012-01-26 14:10 ` Cyril Hrubis
[not found] ` <4F22B4CA.8060507@imgtec.com>
0 siblings, 1 reply; 6+ messages in thread
From: Cyril Hrubis @ 2012-01-26 14:10 UTC (permalink / raw)
To: Markos Chandras; +Cc: ltp-list
Hi!
> > The tst_print function is using the TEST_ERRNO symbol which is declared
> > as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int'
> > when this macro is not defined. We need to include this header on float and
> > echoes tests to ensure that TEST_ERRNO has been defined before calling
> > the tst_print function. Without this header, the compilation will fail with
> > an undefined symbol error.
> >
> > Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> > ---
> > testcases/misc/math/float/main.c | 1 +
> > testcases/network/tcp_cmds/echo/echoes.c | 3 ++-
> > 2 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/testcases/misc/math/float/main.c b/testcases/misc/math/float/main.c
> > index 8998c33..870661b 100644
> > --- a/testcases/misc/math/float/main.c
> > +++ b/testcases/misc/math/float/main.c
> > @@ -26,6 +26,7 @@
> > #include "tfloat.h"
> >
> > #include "test.h"
> > +#include "usctest.h"
> >
> > #define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }
> > /* LTP status reporting */
> > diff --git a/testcases/network/tcp_cmds/echo/echoes.c b/testcases/network/tcp_cmds/echo/echoes.c
> > index 877cfa5..2ce7968 100644
> > --- a/testcases/network/tcp_cmds/echo/echoes.c
> > +++ b/testcases/network/tcp_cmds/echo/echoes.c
> > @@ -29,6 +29,7 @@
> > #include <fcntl.h>
> > #include "test.h"
> > #include "netdefs.h"
> > +#include "usctest.h"
> >
> > #if INET6
> > char *TCID = "echoes6";
> > @@ -372,4 +373,4 @@ void
> > cleanup(int s)
> > {
> > close(s);
> > -}
> > \ No newline at end of file
> > +}
>
> Ping?
>
> Any comments on that? Compilation fails without that when using UCLINUX=1
Strange, I've been unable to locate the original patch in the mailing
list...
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-09 16:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-02 12:04 [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header Markos Chandras
2012-02-09 15:51 ` Markos Chandras
2012-02-09 16:14 ` Cyril Hrubis
[not found] <1326106637-5173-1-git-send-email-markos.chandras@imgtec.com>
2012-01-26 10:15 ` Markos Chandras
2012-01-26 14:10 ` Cyril Hrubis
[not found] ` <4F22B4CA.8060507@imgtec.com>
2012-02-01 16:20 ` Cyril Hrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.