From: "Cousson, Benoit" <b-cousson-l0cyMroinI0@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/4] arm/dts: OMAP4: Add SPI controller nodes
Date: Wed, 15 Feb 2012 22:00:42 +0100 [thread overview]
Message-ID: <4F3C1CFA.3050705@ti.com> (raw)
In-Reply-To: <20120215200240.GA25779-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
On 2/15/2012 9:02 PM, Grant Likely wrote:
> On Wed, Feb 15, 2012 at 06:37:35PM +0100, Benoit Cousson wrote:
>> Add the 4 McSPI controller nodes present in an OMAP4 device.
>>
>> Remove SPI static device initialisation if DT is populated.
>>
>> Signed-off-by: Benoit Cousson<b-cousson-l0cyMroinI0@public.gmane.org>
>> Cc: Grant Likely<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
>> ---
>> arch/arm/boot/dts/omap4.dtsi | 32 ++++++++++++++++++++++++++++++++
>> arch/arm/mach-omap2/devices.c | 4 +++-
>> 2 files changed, 35 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 4b81f03..7fc0cbe 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -209,5 +209,37 @@
>> #size-cells =<0>;
>> ti,hwmods = "i2c4";
>> };
>> +
>> + mcspi1: mcspi@1 {
>> + compatible = "ti,omap4-mcspi";
>> + #address-cells =<1>;
>> + #size-cells =<0>;
>> + ti,hwmods = "mcspi1";
>> + ti,spi-num-cs =<4>;
>
> No reg or interrupts properties? And the @<num> in the name must match the
> first entry in a reg property. This looks wrong.
Well, it is done on purpose :-)
The idea being that since reg, irq and dma are still provided by hwmod
data, I'd rather not populate this information here at all and thus not
confuse people that will then think that these entries are valid and useful.
At some point, when I'll be able to migrate some of the hwmod data to
DT, I will use the hwmod Python generator to generate the OMAP DTS and
then populate the proper reg, interrupts and dma-requests.
It does not match with the DT convention yet, but this is to emphasis
the temporary situation due to hwmod data still in use to build a device.
@<num> might be populated, but again the point was to be *consistent* in
the overall inconsistency with regards to DT convention.
Does that make sense or not at all?
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm/dts: OMAP4: Add SPI controller nodes
Date: Wed, 15 Feb 2012 22:00:42 +0100 [thread overview]
Message-ID: <4F3C1CFA.3050705@ti.com> (raw)
In-Reply-To: <20120215200240.GA25779@ponder.secretlab.ca>
On 2/15/2012 9:02 PM, Grant Likely wrote:
> On Wed, Feb 15, 2012 at 06:37:35PM +0100, Benoit Cousson wrote:
>> Add the 4 McSPI controller nodes present in an OMAP4 device.
>>
>> Remove SPI static device initialisation if DT is populated.
>>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Grant Likely<grant.likely@secretlab.ca>
>> ---
>> arch/arm/boot/dts/omap4.dtsi | 32 ++++++++++++++++++++++++++++++++
>> arch/arm/mach-omap2/devices.c | 4 +++-
>> 2 files changed, 35 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> index 4b81f03..7fc0cbe 100644
>> --- a/arch/arm/boot/dts/omap4.dtsi
>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> @@ -209,5 +209,37 @@
>> #size-cells =<0>;
>> ti,hwmods = "i2c4";
>> };
>> +
>> + mcspi1: mcspi at 1 {
>> + compatible = "ti,omap4-mcspi";
>> + #address-cells =<1>;
>> + #size-cells =<0>;
>> + ti,hwmods = "mcspi1";
>> + ti,spi-num-cs =<4>;
>
> No reg or interrupts properties? And the @<num> in the name must match the
> first entry in a reg property. This looks wrong.
Well, it is done on purpose :-)
The idea being that since reg, irq and dma are still provided by hwmod
data, I'd rather not populate this information here at all and thus not
confuse people that will then think that these entries are valid and useful.
At some point, when I'll be able to migrate some of the hwmod data to
DT, I will use the hwmod Python generator to generate the OMAP DTS and
then populate the proper reg, interrupts and dma-requests.
It does not match with the DT convention yet, but this is to emphasis
the temporary situation due to hwmod data still in use to build a device.
@<num> might be populated, but again the point was to be *consistent* in
the overall inconsistency with regards to DT convention.
Does that make sense or not at all?
Regards,
Benoit
next prev parent reply other threads:[~2012-02-15 21:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 17:37 [PATCH 0/4] spi/omap: Adaptation to Device Tree Benoit Cousson
2012-02-15 17:37 ` Benoit Cousson
2012-02-15 17:37 ` [PATCH 1/4] spi/omap: Add DT support to McSPI driver Benoit Cousson
2012-02-15 17:37 ` Benoit Cousson
2012-02-15 19:34 ` Rob Herring
2012-02-15 19:34 ` Rob Herring
2012-02-15 20:04 ` Grant Likely
2012-02-15 20:04 ` Grant Likely
2012-02-15 21:10 ` Cousson, Benoit
2012-02-15 21:10 ` Cousson, Benoit
2012-02-15 17:37 ` [PATCH 2/4] arm/dts: OMAP4: Add SPI controller nodes Benoit Cousson
2012-02-15 17:37 ` Benoit Cousson
2012-02-15 20:02 ` Grant Likely
2012-02-15 20:02 ` Grant Likely
[not found] ` <20120215200240.GA25779-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2012-02-15 21:00 ` Cousson, Benoit [this message]
2012-02-15 21:00 ` Cousson, Benoit
2012-02-15 17:37 ` [PATCH 3/4] arm/dts: OMAP3: " Benoit Cousson
2012-02-15 17:37 ` Benoit Cousson
2012-02-15 17:37 ` [PATCH 4/4] arm/dts: omap4-sdp: Add ks8851 ethernet SPI device Benoit Cousson
2012-02-15 17:37 ` Benoit Cousson
2012-02-15 20:03 ` [PATCH 0/4] spi/omap: Adaptation to Device Tree Grant Likely
2012-02-15 20:03 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3C1CFA.3050705@ti.com \
--to=b-cousson-l0cymroini0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.