* [patch] svcrdma: silence a Sparse warning
@ 2012-02-21 7:28 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2012-02-21 7:28 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Trond Myklebust, linux-nfs, kernel-janitors
Sparse complains that the definition function definition and the
implementation aren't anotated the same way.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
index d205e9f..0b8e3e6 100644
--- a/include/linux/sunrpc/svc_rdma.h
+++ b/include/linux/sunrpc/svc_rdma.h
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
- u32, u64, u32);
+ __be32, __be64, u32);
extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
struct rpcrdma_msg *,
struct rpcrdma_msg *,
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [patch] svcrdma: silence a Sparse warning
@ 2012-02-21 7:28 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2012-02-21 7:28 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Trond Myklebust, linux-nfs, kernel-janitors
Sparse complains that the definition function definition and the
implementation aren't anotated the same way.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
index d205e9f..0b8e3e6 100644
--- a/include/linux/sunrpc/svc_rdma.h
+++ b/include/linux/sunrpc/svc_rdma.h
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
- u32, u64, u32);
+ __be32, __be64, u32);
extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
struct rpcrdma_msg *,
struct rpcrdma_msg *,
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
2012-02-21 7:28 ` Dan Carpenter
@ 2012-02-21 21:06 ` J. Bruce Fields
-1 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2012-02-21 21:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Trond Myklebust, linux-nfs, kernel-janitors, Tom Tucker
(Cc'ing Tom).
On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> Sparse complains that the definition function definition and the
> implementation aren't anotated the same way.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> index d205e9f..0b8e3e6 100644
> --- a/include/linux/sunrpc/svc_rdma.h
> +++ b/include/linux/sunrpc/svc_rdma.h
> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> - u32, u64, u32);
> + __be32, __be64, u32);
> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> struct rpcrdma_msg *,
> struct rpcrdma_msg *,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
@ 2012-02-21 21:06 ` J. Bruce Fields
0 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2012-02-21 21:06 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Trond Myklebust, linux-nfs, kernel-janitors, Tom Tucker
(Cc'ing Tom).
On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> Sparse complains that the definition function definition and the
> implementation aren't anotated the same way.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> index d205e9f..0b8e3e6 100644
> --- a/include/linux/sunrpc/svc_rdma.h
> +++ b/include/linux/sunrpc/svc_rdma.h
> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> - u32, u64, u32);
> + __be32, __be64, u32);
> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> struct rpcrdma_msg *,
> struct rpcrdma_msg *,
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
2012-02-21 21:06 ` J. Bruce Fields
@ 2012-02-21 21:08 ` Tom Tucker
-1 siblings, 0 replies; 8+ messages in thread
From: Tom Tucker @ 2012-02-21 21:08 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Dan Carpenter, Trond Myklebust, linux-nfs, kernel-janitors
This is my bad. I don't know why my sparse didn't catch it, it seems like
it should have. Thanks for
fixing it Dan.
Tom
On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> (Cc'ing Tom).
>
> On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
>> Sparse complains that the definition function definition and the
>> implementation aren't anotated the same way.
>>
>> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>>
>> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
>> index d205e9f..0b8e3e6 100644
>> --- a/include/linux/sunrpc/svc_rdma.h
>> +++ b/include/linux/sunrpc/svc_rdma.h
>> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
>> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
>> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
>> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
>> - u32, u64, u32);
>> + __be32, __be64, u32);
>> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
>> struct rpcrdma_msg *,
>> struct rpcrdma_msg *,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
@ 2012-02-21 21:08 ` Tom Tucker
0 siblings, 0 replies; 8+ messages in thread
From: Tom Tucker @ 2012-02-21 21:08 UTC (permalink / raw)
To: J. Bruce Fields
Cc: Dan Carpenter, Trond Myklebust, linux-nfs, kernel-janitors
This is my bad. I don't know why my sparse didn't catch it, it seems like
it should have. Thanks for
fixing it Dan.
Tom
On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> (Cc'ing Tom).
>
> On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
>> Sparse complains that the definition function definition and the
>> implementation aren't anotated the same way.
>>
>> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>>
>> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
>> index d205e9f..0b8e3e6 100644
>> --- a/include/linux/sunrpc/svc_rdma.h
>> +++ b/include/linux/sunrpc/svc_rdma.h
>> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
>> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
>> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
>> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
>> - u32, u64, u32);
>> + __be32, __be64, u32);
>> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
>> struct rpcrdma_msg *,
>> struct rpcrdma_msg *,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
2012-02-21 21:08 ` Tom Tucker
@ 2012-02-21 21:23 ` J. Bruce Fields
-1 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2012-02-21 21:23 UTC (permalink / raw)
To: Tom Tucker; +Cc: Dan Carpenter, Trond Myklebust, linux-nfs, kernel-janitors
On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
>
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.
Thanks, applying.--b.
>
> Tom
>
>
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>- u32, u64, u32);
> >>+ __be32, __be64, u32);
> >> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >> struct rpcrdma_msg *,
> >> struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] svcrdma: silence a Sparse warning
@ 2012-02-21 21:23 ` J. Bruce Fields
0 siblings, 0 replies; 8+ messages in thread
From: J. Bruce Fields @ 2012-02-21 21:23 UTC (permalink / raw)
To: Tom Tucker; +Cc: Dan Carpenter, Trond Myklebust, linux-nfs, kernel-janitors
On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
>
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.
Thanks, applying.--b.
>
> Tom
>
>
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>- u32, u64, u32);
> >>+ __be32, __be64, u32);
> >> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >> struct rpcrdma_msg *,
> >> struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-02-21 21:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-21 7:28 [patch] svcrdma: silence a Sparse warning Dan Carpenter
2012-02-21 7:28 ` Dan Carpenter
2012-02-21 21:06 ` J. Bruce Fields
2012-02-21 21:06 ` J. Bruce Fields
2012-02-21 21:08 ` Tom Tucker
2012-02-21 21:08 ` Tom Tucker
2012-02-21 21:23 ` J. Bruce Fields
2012-02-21 21:23 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.