From: Zhengwang Ruan <ruan.zhengwang@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Valdis.Kletnieks@vt.edu, fweisbec@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Trace: initialize variable to clear warning
Date: Thu, 01 Mar 2012 02:08:56 +0000 [thread overview]
Message-ID: <4F4EDA38.2070803@gmail.com> (raw)
In-Reply-To: <1330564158.25686.230.camel@gandalf.stny.rr.com>
-------- Original Message --------
From: Steven Rostedt
Sent: 2012年02月29日 星期三 20时09分18秒
To: Valdis.Kletnieks
Subject: Re: [PATCH] Trace: initialize variable to clear warning
> On Wed, 2012-02-29 at 17:40 -0500, Valdis.Kletnieks@vt.edu wrote:
>> On Tue, 28 Feb 2012 09:16:31 EST, Steven Rostedt said:
>>
>>> This is a bug in gcc that's fixed in 4.6 and beyond. I don't want to
>>> remove this warning because it will hide a real bug if page2 really does
>>> become uninitialized. If 4.6 gives a warning here, then I'll fix it.
>>>> - void *page2;
>>>> + void *uninitialized_var(page2);
>> How would you feel about this?
>>
>> - void *page2;
>> + void *page2; /* gcc 4.5 bug causes incorrect "uninitialized" warning */
>>
>> or something similar?
> /* if you get a warning here, upgrade your gcc to 4.6 */
>
OK, I will resend this patch.
Thanks,
-Zhengwang
> -- Steve
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Zhengwang Ruan <ruan.zhengwang@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Valdis.Kletnieks@vt.edu, fweisbec@gmail.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Trace: initialize variable to clear warning
Date: Thu, 01 Mar 2012 10:08:56 +0800 [thread overview]
Message-ID: <4F4EDA38.2070803@gmail.com> (raw)
In-Reply-To: <1330564158.25686.230.camel@gandalf.stny.rr.com>
-------- Original Message --------
From: Steven Rostedt
Sent: 2012年02月29日 星期三 20时09分18秒
To: Valdis.Kletnieks
Subject: Re: [PATCH] Trace: initialize variable to clear warning
> On Wed, 2012-02-29 at 17:40 -0500, Valdis.Kletnieks@vt.edu wrote:
>> On Tue, 28 Feb 2012 09:16:31 EST, Steven Rostedt said:
>>
>>> This is a bug in gcc that's fixed in 4.6 and beyond. I don't want to
>>> remove this warning because it will hide a real bug if page2 really does
>>> become uninitialized. If 4.6 gives a warning here, then I'll fix it.
>>>> - void *page2;
>>>> + void *uninitialized_var(page2);
>> How would you feel about this?
>>
>> - void *page2;
>> + void *page2; /* gcc 4.5 bug causes incorrect "uninitialized" warning */
>>
>> or something similar?
> /* if you get a warning here, upgrade your gcc to 4.6 */
>
OK, I will resend this patch.
Thanks,
-Zhengwang
> -- Steve
>
>
>
>
next prev parent reply other threads:[~2012-03-01 2:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 9:09 [PATCH] Trace: initialize variable to clear warning Zhengwang Ruan
2012-02-28 9:09 ` Zhengwang Ruan
2012-02-28 10:27 ` Borislav Petkov
2012-02-28 10:27 ` Borislav Petkov
2012-02-28 14:16 ` Steven Rostedt
2012-02-28 14:16 ` Steven Rostedt
2012-02-29 22:40 ` Valdis.Kletnieks
2012-02-29 22:40 ` Valdis.Kletnieks
2012-03-01 1:09 ` Steven Rostedt
2012-03-01 1:09 ` Steven Rostedt
2012-03-01 2:08 ` Zhengwang Ruan [this message]
2012-03-01 2:08 ` Zhengwang Ruan
2012-03-01 2:23 ` Valdis.Kletnieks
2012-03-01 2:23 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4EDA38.2070803@gmail.com \
--to=ruan.zhengwang@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=fweisbec@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.