All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC 2/2] ath9k_htc: use ieee80211_free_txskb
Date: Thu, 1 Mar 2012 19:28:45 +0530	[thread overview]
Message-ID: <4F4F8095.4010706@qca.qualcomm.com> (raw)
In-Reply-To: <88bea301177cac98e77cd49490ac576d36b10c81.1330360738.git.chunkeey@googlemail.com>

Hi Christian,


On Monday 27 February 2012 10:02 PM, Christian Lamparter wrote:
> With the new tx status API: "mac80211: implement wifi TX status"
> All skb originating from mac80211 needs to be given back to mac80211.
>
> Signed-off-by: Christian Lamparter<chunkeey@googlemail.com>
> ---
> It compiles, but not tested.
> ---
>   drivers/net/wireless/ath/ath9k/htc_drv_txrx.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index 3e40a64..e958704 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -451,7 +451,7 @@ static void ath9k_htc_tx_process(struct ath9k_htc_priv *priv,
>
>   	slot = strip_drv_header(priv, skb);
>   	if (slot<  0) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>
> @@ -687,7 +687,7 @@ void ath9k_htc_txep(void *drv_priv, struct sk_buff *skb,
>
>   	epid_queue = get_htc_epid_queue(priv, ep_id);
>   	if (!epid_queue) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>

also we should do it ath9k_htc_tx in htc_drv_main.c, i don't know very 
much about ath9k_htc.


-- 
thanks,
shafi

WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: <linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>,
	<senthilb@qca.qualcomm.com>, <vthiagar@qca.qualcomm.com>,
	<rodrigue@qca.qualcomm.com>
Subject: Re: [RFC 2/2] ath9k_htc: use ieee80211_free_txskb
Date: Thu, 1 Mar 2012 19:28:45 +0530	[thread overview]
Message-ID: <4F4F8095.4010706@qca.qualcomm.com> (raw)
In-Reply-To: <88bea301177cac98e77cd49490ac576d36b10c81.1330360738.git.chunkeey@googlemail.com>

Hi Christian,


On Monday 27 February 2012 10:02 PM, Christian Lamparter wrote:
> With the new tx status API: "mac80211: implement wifi TX status"
> All skb originating from mac80211 needs to be given back to mac80211.
>
> Signed-off-by: Christian Lamparter<chunkeey@googlemail.com>
> ---
> It compiles, but not tested.
> ---
>   drivers/net/wireless/ath/ath9k/htc_drv_txrx.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> index 3e40a64..e958704 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
> @@ -451,7 +451,7 @@ static void ath9k_htc_tx_process(struct ath9k_htc_priv *priv,
>
>   	slot = strip_drv_header(priv, skb);
>   	if (slot<  0) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>
> @@ -687,7 +687,7 @@ void ath9k_htc_txep(void *drv_priv, struct sk_buff *skb,
>
>   	epid_queue = get_htc_epid_queue(priv, ep_id);
>   	if (!epid_queue) {
> -		dev_kfree_skb_any(skb);
> +		ieee80211_free_txskb(priv->hw, skb);
>   		return;
>   	}
>

also we should do it ath9k_htc_tx in htc_drv_main.c, i don't know very 
much about ath9k_htc.


-- 
thanks,
shafi

  reply	other threads:[~2012-03-01 13:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27 16:10 [ath9k-devel] [RFC 1/2] ath9k: use ieee80211_free_txskb Christian Lamparter
2012-02-27 16:10 ` Christian Lamparter
2012-02-27 16:32 ` [ath9k-devel] [RFC 2/2] ath9k_htc: " Christian Lamparter
2012-02-27 16:32   ` Christian Lamparter
2012-03-01 13:58   ` Mohammed Shafi Shajakhan [this message]
2012-03-01 13:58     ` Mohammed Shafi Shajakhan
2012-03-01  5:39 ` [ath9k-devel] [RFC 1/2] ath9k: " Mohammed Shafi Shajakhan
2012-03-01  5:39   ` Mohammed Shafi Shajakhan
2012-03-01 11:42   ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-03-01 11:42     ` Mohammed Shafi Shajakhan
2012-03-01 13:46     ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-03-01 13:46       ` Mohammed Shafi Shajakhan
2012-03-05 15:00       ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-03-05 15:00         ` Mohammed Shafi Shajakhan
2012-03-05 15:01       ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-03-05 15:01         ` Mohammed Shafi Shajakhan
2012-03-05 18:43         ` [ath9k-devel] " Christian Lamparter
2012-03-05 18:43           ` Christian Lamparter
2012-03-06  5:06           ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-03-06  5:06             ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4F8095.4010706@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.