From: Kukjin Kim <kgene.kim@samsung.com>
To: Gusakov Andrey <dron0gus@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, heiko@sntech.de
Subject: Re: [PATCH v3] ARM: S3C24XX DMA resume regression fix
Date: Sat, 03 Mar 2012 08:57:27 +0900 [thread overview]
Message-ID: <4F515E67.20500@samsung.com> (raw)
In-Reply-To: <1330610031-2237-1-git-send-email-dron0gus@gmail.com>
On 03/01/12 22:53, Gusakov Andrey wrote:
> s3c2410_dma_suspend suspends channels from 0 to dma_channels.
> s3c2410_dma_resume resumes channels in reverse order. So
> pointer should be decremented instead of being incremented.
>
> Signed-off-by: Gusakov Andrey<dron0gus@gmail.com>
> Reviewed-by: Heiko Stuebner<heiko@sntech.de>
> ---
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> index 57abec9..16510d5 100644
> --- a/arch/arm/plat-s3c24xx/dma.c
> +++ b/arch/arm/plat-s3c24xx/dma.c
> @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
> struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
> int channel;
>
> - for (channel = dma_channels - 1; channel>= 0; cp++, channel--)
> + for (channel = dma_channels - 1; channel>= 0; cp--, channel--)
> s3c2410_dma_resume_chan(cp);
> }
>
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: S3C24XX DMA resume regression fix
Date: Sat, 03 Mar 2012 08:57:27 +0900 [thread overview]
Message-ID: <4F515E67.20500@samsung.com> (raw)
In-Reply-To: <1330610031-2237-1-git-send-email-dron0gus@gmail.com>
On 03/01/12 22:53, Gusakov Andrey wrote:
> s3c2410_dma_suspend suspends channels from 0 to dma_channels.
> s3c2410_dma_resume resumes channels in reverse order. So
> pointer should be decremented instead of being incremented.
>
> Signed-off-by: Gusakov Andrey<dron0gus@gmail.com>
> Reviewed-by: Heiko Stuebner<heiko@sntech.de>
> ---
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> index 57abec9..16510d5 100644
> --- a/arch/arm/plat-s3c24xx/dma.c
> +++ b/arch/arm/plat-s3c24xx/dma.c
> @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
> struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
> int channel;
>
> - for (channel = dma_channels - 1; channel>= 0; cp++, channel--)
> + for (channel = dma_channels - 1; channel>= 0; cp--, channel--)
> s3c2410_dma_resume_chan(cp);
> }
>
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-02 23:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <077201ccf767c6d1ec05475c40$%kim@samsung.com>
2012-03-01 13:53 ` [PATCH v3] ARM: S3C24XX DMA resume regression fix Gusakov Andrey
2012-03-01 13:53 ` Gusakov Andrey
2012-03-02 23:57 ` Kukjin Kim [this message]
2012-03-02 23:57 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F515E67.20500@samsung.com \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dron0gus@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.